From: Alan Donovan via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: philipk@posteo.net, 71435@debbugs.gnu.org,
stefankangas@gmail.com, juri@linkov.net
Subject: bug#71435: interactive xref-find-definitions-at-mouse
Date: Mon, 10 Jun 2024 13:26:59 -0400 [thread overview]
Message-ID: <CAPVWWDU80EiU=RTofLZHVWqU3b=hiQEx87uOFX55sqxBrRo5PA@mail.gmail.com> (raw)
In-Reply-To: <86le3c95zk.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2594 bytes --]
I can reliably reproduce the problem using this script:
;; reproducer for use in emacs -Q:
;; invoke load-file on this file,
;; then follow the interactive steps at the very end.
(emacs-version) ; 29.3
(require 'eglot) ; 1.17.0
;; --- these steps are documented at
;;
https://github.com/golang/tools/blob/master/gopls/doc/emacs.md#configuring-project-for-go-modules-in-emacs
(require 'project) ; 0.11.0
(defun project-find-go-module (dir)
(when-let ((root (locate-dominating-file dir "go.mod")))
(cons 'go-module root)))
(cl-defmethod project-root ((project (head go-module)))
(cdr project))
(add-hook 'project-find-functions #'project-find-go-module)
;; -----
; Use your favorite modifier; s is super, aka ⌘ key on Mac.
(global-set-key (kbd "s-<mouse-1>") #'xref-find-definitions-at-mouse)
;; This file comes from github.com/dominikh/go-mode.el@master.
(load-file "~/w/go-mode.el/go-mode.el")
;; Create a new Go buffer.
(with-current-buffer (find-file "/tmp/a.go")
(eglot-ensure)
(insert "package main\n\nimport \"fmt\"\n\nfunc main()
{\n\tfmt.Println()\n}\n")
(set-buffer (current-buffer)))
;; You should now be in a Go buffer in go-mode with eglot enabled.
;;
;; Now: position the point in "fmt", and then ⌘-click on "Println".
;; For me, Emacs navigates to the declaration of "fmt", not "Println".
;; The converse is true as well: with the point in Println,
;; a ⌘-click on fmt goes to the declaration of Println.
On Mon, 10 Jun 2024 at 11:23, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Alan Donovan <adonovan@google.com>
> > Date: Mon, 10 Jun 2024 10:39:04 -0400
> > Cc: Juri Linkov <juri@linkov.net>, Stefan Kangas <stefankangas@gmail.com>,
>
> > Eli Zaretskii <eliz@gnu.org>, 71435@debbugs.gnu.org
> >
> > > ?? This works for me:
> > > (global-set-key [C-down-mouse-1] 'xref-find-definitions-at-mouse)
> >
> > Ah, I remember the problem now: if the point is at position A and the
> mouse click occurs at some unrelated
> > position B, plain old xref-find-definitions-at-mouse will use position A
> as the basis of the query
>
> I cannot reproduce thus. I just tried, and the mouse click shows the
> definition of identifier at mouse click, not at point.
>
> > So perhaps my request should instead have been expressed as a bug
> report: xref-find-definitions-at-mouse
> > uses the point instead of the mouse event position.
>
> Please show a recipe for reproducing this, and please also tell what
> version of Emacs are you using and on which platform.
>
> Thanks.
>
[-- Attachment #2: Type: text/html, Size: 3685 bytes --]
next prev parent reply other threads:[~2024-06-10 17:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 15:28 bug#71435: interactive xref-find-definitions-at-mouse Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 16:31 ` Eli Zaretskii
2024-06-09 18:29 ` Stefan Kangas
2024-06-09 18:58 ` Eli Zaretskii
2024-06-10 6:11 ` Philip Kaludercic
2024-06-10 6:32 ` Juri Linkov
2024-06-10 7:07 ` Philip Kaludercic
2024-06-10 14:39 ` Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-10 14:44 ` Stefan Kangas
2024-06-10 15:23 ` Eli Zaretskii
2024-06-10 17:26 ` Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-06-10 17:43 ` Philip Kaludercic
2024-06-10 18:47 ` Alan Donovan via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-10 18:59 ` Stefan Kangas
2024-06-10 17:55 ` Eli Zaretskii
2024-06-09 16:46 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPVWWDU80EiU=RTofLZHVWqU3b=hiQEx87uOFX55sqxBrRo5PA@mail.gmail.com' \
--to=bug-gnu-emacs@gnu.org \
--cc=71435@debbugs.gnu.org \
--cc=adonovan@google.com \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=philipk@posteo.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).