unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noah Peart <noah.v.peart@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71209@debbugs.gnu.org, dmitry@gutov.dev, dev@rjt.dev
Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses
Date: Thu, 27 Jun 2024 05:29:21 -0400	[thread overview]
Message-ID: <CAPVBTSfYEumHZeHRg4Bqnju4z--iG2ufLvwCyGC7OML0pAZHKQ@mail.gmail.com> (raw)
In-Reply-To: <8634oy7s3s.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

Ah yes, sorry to be slow, I can submit a patch for those settings.  I'll
take a look today!

On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii <eliz@gnu.org> wrote:

> Ping! Ping!  Noah, are you still interested in working on this?
>
> > Cc: 71209@debbugs.gnu.org, dev@rjt.dev
> > Date: Sat, 15 Jun 2024 10:56:36 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> >
> > Ping!  Noah, would you please answer Dmitry?
> >
> > > Cc: 71209@debbugs.gnu.org
> > > Date: Sat, 1 Jun 2024 17:13:57 +0300
> > > From: Dmitry Gutov <dmitry@gutov.dev>
> > >
> > > On 01/06/2024 04:42, Noah Peart wrote:
> > > >
> > > > I've been using these for c++, I think they are still missing
> > > >
> > > >      ;; for (auto x: ...)
> > > >      (for_range_loop
> > > >       declarator: (identifier) @font-lock-variable-name-face)
> > > >      ;; auto& x
> > > >      (reference_declarator
> > > >       (identifier) @font-lock-variable-name-face)
> > > >      ;; auto[&] [x, y]
> > > >      (structured_binding_declarator
> > > >       _ [(identifier)] @font-lock-variable-name-face)
> > > >
> > > > I suppose most people keep the default font-locking for variable-name
> > > > and variable-use, so these missing rules go unnoticed.
> > >
> > > Do you want to submit a full patch with these as well?
> > >
> > >
> > >
> > >
> >
> >
> >
> >
>

[-- Attachment #2: Type: text/html, Size: 2278 bytes --]

  reply	other threads:[~2024-06-27  9:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-26 12:41 bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Noah Peart
2024-05-28  2:46 ` Randy Taylor
2024-05-30 13:25   ` Noah Peart
2024-05-30 23:23     ` Dmitry Gutov
2024-06-01  1:09     ` Randy Taylor
2024-06-01  1:42       ` Noah Peart
2024-06-01  1:50         ` Noah Peart
2024-06-01 14:13           ` Dmitry Gutov
2024-06-01  1:51         ` Dmitry Gutov
2024-06-01  1:56           ` Noah Peart
2024-06-01  1:59             ` Dmitry Gutov
2024-06-01  2:04               ` Noah Peart
2024-06-01 14:13         ` Dmitry Gutov
2024-06-15  7:56           ` Eli Zaretskii
2024-06-27  7:38             ` Eli Zaretskii
2024-06-27  9:29               ` Noah Peart [this message]
2024-07-06  7:46                 ` Eli Zaretskii
2024-07-20  9:42                   ` Eli Zaretskii
2024-08-04  7:52                     ` Eli Zaretskii
2024-06-01  1:56       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPVBTSfYEumHZeHRg4Bqnju4z--iG2ufLvwCyGC7OML0pAZHKQ@mail.gmail.com \
    --to=noah.v.peart@gmail.com \
    --cc=71209@debbugs.gnu.org \
    --cc=dev@rjt.dev \
    --cc=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).