From: nvp <noah.v.peart@gmail.com>
To: 66431@debbugs.gnu.org
Subject: bug#66431: [PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed
Date: Mon, 9 Oct 2023 23:02:48 -0700 [thread overview]
Message-ID: <CAPVBTSfDS1es0sX8R_GCSDi7iZ6M2rPOoNe5Kvrr+pBjumV5zA@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1049 bytes --]
Tags: patch
Bug: After `treesit-explorer-mode` is enabled in a buffer and its
associated `treesit--explorer-buffer` is killed, a subsequent call
to `treesit-explorer-mode` initially displays an empty explorer
buffer b/c `treesit--explorer-refresh` sees old value for
`treesit--explorer-last-node`.
* lisp/treesit.el (treesit-explorer-mode): reset
`treesit--explorer-last-node` when `treesit--explorer-buffer` was killed
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-10-05 built on noah-X580VD
Repository revision: 505c80623049d9e181918acdac8229c9a2041b1e
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS
Configured using:
'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'
[-- Attachment #1.2: Type: text/html, Size: 1190 bytes --]
[-- Attachment #2: fix-treesit-explorer-last-node.patch --]
[-- Type: text/x-patch, Size: 841 bytes --]
From f0d420133b58d0506173f2f1539867b2d9e7f014 Mon Sep 17 00:00:00 2001
From: nverno <noah.v.peart@gmail.com>
Date: Mon, 9 Oct 2023 22:52:38 -0700
Subject: [PATCH] Fix reset treesit--explorer-last-node
---
lisp/treesit.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/treesit.el b/lisp/treesit.el
index 402417c6ca9..e798abac079 100644
--- a/lisp/treesit.el
+++ b/lisp/treesit.el
@@ -3192,6 +3192,7 @@ treesit-explore-mode
(format "*tree-sitter explorer for %s*"
(buffer-name))))
(setq-local treesit--explorer-language language)
+ (setq-local treesit--explorer-last-node nil)
(with-current-buffer treesit--explorer-buffer
(treesit--explorer-tree-mode)))
(display-buffer treesit--explorer-buffer
--
2.34.1
next reply other threads:[~2023-10-10 6:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 6:02 nvp [this message]
2023-10-14 8:17 ` bug#66431: [PATCH] Fix reset treesit--explorer-last-node when explorer buffer was killed Eli Zaretskii
2023-10-14 17:08 ` Yuan Fu
2023-10-15 4:20 ` nvp
2023-10-19 4:35 ` Yuan Fu
2023-10-20 21:22 ` nvp
2023-10-21 18:33 ` Yuan Fu
2023-10-22 0:40 ` nvp
2023-10-22 3:35 ` Yuan Fu
2023-10-14 17:08 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPVBTSfDS1es0sX8R_GCSDi7iZ6M2rPOoNe5Kvrr+pBjumV5zA@mail.gmail.com \
--to=noah.v.peart@gmail.com \
--cc=66431@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).