From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Noah Peart Newsgroups: gmane.emacs.bugs Subject: bug#70665: [PATCH] Add font-locking for typed parameters in python-ts-mode Date: Tue, 30 Apr 2024 03:27:36 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000041303906174dd2ac" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40222"; mail-complaints-to="usenet@ciao.gmane.io" To: 70665@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 30 12:29:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s1kjO-000ACX-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Apr 2024 12:29:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1kj5-0003uK-OZ; Tue, 30 Apr 2024 06:28:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1kj3-0003t1-Pf for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2024 06:28:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s1kj3-0005OH-HH for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2024 06:28:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s1kjO-00040X-0C for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2024 06:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noah Peart Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2024 10:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70665 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171447292215399 (code B ref -1); Tue, 30 Apr 2024 10:29:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Apr 2024 10:28:42 +0000 Original-Received: from localhost ([127.0.0.1]:59333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1kiz-00040D-HW for submit@debbugs.gnu.org; Tue, 30 Apr 2024 06:28:42 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:36948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1kiv-000402-Cc for submit@debbugs.gnu.org; Tue, 30 Apr 2024 06:28:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1kiS-0003QZ-WF for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2024 06:28:05 -0400 Original-Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s1kiD-0005Ey-R0 for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2024 06:28:04 -0400 Original-Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3c844b6edbbso3270139b6e.1 for ; Tue, 30 Apr 2024 03:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714472868; x=1715077668; darn=gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=noXLl3kZqBzdwkisr0lU9z0wUVacNJoFnQD9GLPB/yQ=; b=l3/Y6wlHjt9CTZrnUHZw5sIRCajWNW1g35enKUfi2WdhbRCzDAKuWPwp+TQdrGYDaB PA0BKQbTu+6wnzfS+PtS8D5Xf6jQQDrKANQzxVIVwTbghe0d6Rmr3aUth3GMauHxC/Dq TvoakMw3BY1G36itxnC/NyDM3sKixXSkBCK69YkPdLWYGAbr4CkX2d+E2YOYpIS2gqXz 702+qr78nnTgvp1eND6NxTyyLjgd7yn6z+ZbnbNy/bEDyldBwqsiegWMtIJFQz9OSlrA KCDttvVt0ft2ebDtn0wRnIaow9RjFn6zGn58ImJyvCGZYJ7QjsXZlqwuWPHgS4aNLm1P NPpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714472868; x=1715077668; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=noXLl3kZqBzdwkisr0lU9z0wUVacNJoFnQD9GLPB/yQ=; b=keEebO6HTutns6epq9MRRYI1vKD3CtBbAG5EjFHf+8EmqGKdDAmAgcuWsfHRTz0ReX Q9NANm+8Ul4M5HSojZMttxziUgumYy6yfd+Cd7LemTnU8D3gUiunYuJX8kfYUw5lH0bt ijhcrwy7s6WM8/qEYgOsGJNo+9XFH7ayZsUMZMJZ0xOzVho3uuXNLSSY4nzUYXlgMV5t 5wlT+X88zby1dN1CADUsz3jzct5G8B59OBiA/5Sarcv+tJwVjq7jEKyhTUrOOkDMyQci 8Ky9wwOX980fCfNbtvYHMiWc73i/+SVAiNJaTzTr86zRjcLwmuqOX77CQucw/VOnfdOM i9jA== X-Gm-Message-State: AOJu0YwihFKWNgMLThzrtF/eUDb1xlQOCKipDUubLSmzNj0EzQ6zf0tT dy1pI71tTXNuXeeN3JqcL2Q5Gvnc2G4YTzHjIpgdtM2M9LXU4clvFgbO/ju/15rJq2hx6GIG/A5 7g00UW1ORqbIg7as1v76tZgbdMG2dIbT17h8= X-Google-Smtp-Source: AGHT+IHdNWwTvKUE6s2WoOknqrbUeL3wlLQxcKh1Z2ia7xOpSm2GcjGGxg++pKQAf8/Y8wrcY75TW+gbFuXpCrHf/o0= X-Received: by 2002:a05:6870:fe94:b0:238:dd2e:b3ef with SMTP id qm20-20020a056870fe9400b00238dd2eb3efmr13709659oab.59.1714472867662; Tue, 30 Apr 2024 03:27:47 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::22b; envelope-from=noah.v.peart@gmail.com; helo=mail-oi1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284196 Archived-At: --00000000000041303906174dd2ac Content-Type: multipart/alternative; boundary="00000000000041303706174dd2aa" --00000000000041303706174dd2aa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, previous patch added an extra file by accident. Fixed patch attached. On Tue, Apr 30, 2024 at 3:09=E2=80=AFAM Noah Peart = wrote: > Tags: patch > > This patch adds a rule to python--treesit-settings to apply > font-lock-variable-name-face to typed parameters in python-ts-mode. > Currently, function parameters with type annotations are missing > font-lock-variable-name-face. > > For example, this patch adds font-locking in the following case: > > def foo(val: str) -> str > # ^ font-lock-variable-name-face > > > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.33, cairo version 1.16.0) of 2024-04-29 built on noah-X580VD > Repository revision: 3000edc6179dfe0b5f24ae2e472826530809dfd1 > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.1210100= 4 > System Description: Ubuntu 22.04.4 LTS > > Configured using: > 'configure --prefix=3D/usr/local --with-modules --with-tree-sitter > --with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls > --with-json --with-mailutils --with-jpeg --with-png --with-rsvg > --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12 > CXX=3Dgcc-12' > --00000000000041303706174dd2aa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, previous patch added an extra file by accident= .

Fixed patch attached.


On Tue, Apr = 30, 2024 at 3:09=E2=80=AFAM Noah Peart <noah.v.peart@gmail.com> wrote:
Tags: patch

This p= atch adds a rule to python--treesit-settings to apply
font-lock-variable= -name-face to typed parameters in python-ts-mode.
Currently, function pa= rameters with type annotations are missing
font-lock-variable-name-face.=

For example, this patch adds font-locking in the following case:
=C2=A0 =C2=A0 def foo(val: str) -> str
=C2=A0 =C2=A0 # =C2=A0 = =C2=A0 =C2=A0 =C2=A0^ font-lock-variable-name-face


In GNU Emacs = 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo versi= on 1.16.0) of 2024-04-29 built on noah-X580VD
Repository revision: 3000e= dc6179dfe0b5f24ae2e472826530809dfd1
Repository branch: master
Windowi= ng system distributor 'The X.Org Foundation', version 11.0.12101004=
System Description: Ubuntu 22.04.4 LTS

Configured using:
=C2= =A0'configure --prefix=3D/usr/local --with-modules --with-tree-sitter--with-threads --with-x-toolkit=3Dgtk3 --with-xwidgets --with-gnutls
-= -with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-ti= ff --with-xml2 --with-xpm --with-imagemagick CC=3Dgcc-12
CXX=3Dgcc-12= 9;
--00000000000041303706174dd2aa-- --00000000000041303906174dd2ac Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-font-locking-for-typed-parameters-in-python-ts-m.patch" Content-Disposition: attachment; filename="0001-Add-font-locking-for-typed-parameters-in-python-ts-m.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvm8uo6d0 RnJvbSBkYjlmMzJjMzFmZjFiZWM0OWYyZGI3MjdjNTE4MjNiZDk4NDIyZjM2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOb2FoIFBlYXJ0IDxub2FoLnYucGVhcnRAZ21haWwuY29tPgpE YXRlOiBUdWUsIDMwIEFwciAyMDI0IDAyOjU1OjE4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRk IGZvbnQtbG9ja2luZyBmb3IgdHlwZWQgcGFyYW1ldGVycyBpbiBweXRob24tdHMtbW9kZQoKKiBs aXNwL3Byb2dtb2Rlcy9weXRob24uZWwgKHB5dGhvbi0tdHJlZXNpdC1zZXR0aW5ncyk6IEFkZAp0 cmVlLXNpdHRlciBmb250LWxvY2tpbmcgcnVsZSBmb3IgdHlwZWQgcGFyYW1ldGVycy4KKiB0ZXN0 L2xpc3AvcHJvZ21vZGVzL3B5dGhvbi10ZXN0cy5lbAoocHl0aG9uLXRzLW1vZGUtdHlwZXMtZmFj ZS0xKTogVGVzdCBmb3IKZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZSBpbiB0eXBlZCBwYXJh bWV0ZXIuCi0tLQogbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsICAgICAgICAgICAgfCAxICsKIHRl c3QvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLXRlc3RzLmVsIHwgMyArKysKIDIgZmlsZXMgY2hhbmdl ZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVs IGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCmluZGV4IGQ2YzI5ZTVmZmM2Li40ZmY1ZTlkNDg3 OCAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCisrKyBiL2xpc3AvcHJvZ21v ZGVzL3B5dGhvbi5lbApAQCAtMTIwMiw2ICsxMjAyLDcgQEAgcHl0aG9uLS10cmVlc2l0LXNldHRp bmdzCiAgICAgIChjbGFzc19kZWZpbml0aW9uCiAgICAgICBuYW1lOiAoaWRlbnRpZmllcikgQGZv bnQtbG9jay10eXBlLWZhY2UpCiAgICAgIChwYXJhbWV0ZXJzIChpZGVudGlmaWVyKSBAZm9udC1s b2NrLXZhcmlhYmxlLW5hbWUtZmFjZSkKKyAgICAgKHBhcmFtZXRlcnMgKHR5cGVkX3BhcmFtZXRl ciAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQogICAgICAocGFy YW1ldGVycyAoZGVmYXVsdF9wYXJhbWV0ZXIgbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2st dmFyaWFibGUtbmFtZS1mYWNlKSkpCiAKICAgIDpmZWF0dXJlICdidWlsdGluCmRpZmYgLS1naXQg YS90ZXN0L2xpc3AvcHJvZ21vZGVzL3B5dGhvbi10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9wcm9nbW9k ZXMvcHl0aG9uLXRlc3RzLmVsCmluZGV4IGUxMTQ0MGNkYjViLi44NzhmNjBmMTYxNCAxMDA2NDQK LS0tIGEvdGVzdC9saXNwL3Byb2dtb2Rlcy9weXRob24tdGVzdHMuZWwKKysrIGIvdGVzdC9saXNw L3Byb2dtb2Rlcy9weXRob24tdGVzdHMuZWwKQEAgLTc1NDUsNiArNzU0NSw5IEBAIHB5dGhvbi10 cy1tb2RlLXVuaW9uLXR5cGVzLWZhY2UtMgogKGVydC1kZWZ0ZXN0IHB5dGhvbi10cy1tb2RlLXR5 cGVzLWZhY2UtMSAoKQogICAocHl0aG9uLXRzLXRlc3RzLXdpdGgtdGVtcC1idWZmZXIKICAgICJk ZWYgZih2YWw6IENhbGxhYmxlW1tUeXBlMF0sIChUeXBlMSwgVHlwZTIpXSk6IgorICAgKHNlYXJj aC1mb3J3YXJkICJ2YWwiKQorICAgKGdvdG8tY2hhciAobWF0Y2gtYmVnaW5uaW5nIDApKQorICAg KHNob3VsZCAoZXEgKGZhY2UtYXQtcG9pbnQpIGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2Up KQogICAgKGRvbGlzdCAodGVzdCAnKCJDYWxsYWJsZSIgIlR5cGUwIiAiVHlwZTEiICJUeXBlMiIp KQogICAgICAoc2VhcmNoLWZvcndhcmQgdGVzdCkKICAgICAgKGdvdG8tY2hhciAobWF0Y2gtYmVn aW5uaW5nIDApKQotLSAKMi4zNC4xCgo= --00000000000041303906174dd2ac--