unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noah Peart <noah.v.peart@gmail.com>
To: john muhl <jm@pub.pink>
Cc: 67616@debbugs.gnu.org
Subject: bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua
Date: Sun, 3 Dec 2023 23:58:46 -0800	[thread overview]
Message-ID: <CAPVBTSckqHnegi4SqQ-vafpbTTw133iMST4JAO4WU-UZ6Q_65w@mail.gmail.com> (raw)
In-Reply-To: <87wmtua8t6.fsf@pub.pink>

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Yea, that looks good to me.  Is it necessary to set
`comint-use-prompt-regexp` to `t`?
The behaviour of `comint-previous/next-prompt` seems better when that is
nil.
Thanks!

On Sun, Dec 3, 2023 at 8:30 PM john muhl <jm@pub.pink> wrote:

> Noah Peart <noah.v.peart@gmail.com> writes:
>
> > Tags: patch
> >
> > Bug: In `lua-ts-inferior-lua`, `comint-preoutput-filter-functions` hook
> > isn't added locally.
>
> Thanks. I think that obsoletes the buffer-name check at the
> beginning. A quick test looks that way to me. Could you give a try?
>
>

[-- Attachment #2: Type: text/html, Size: 918 bytes --]

  reply	other threads:[~2023-12-04  7:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04  3:26 bug#67616: [PATCH] Fix: add comint hook locally in lua-ts-inferior-lua Noah Peart
2023-12-04  4:18 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-04  7:58   ` Noah Peart [this message]
2023-12-04 18:17     ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16  9:39       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPVBTSckqHnegi4SqQ-vafpbTTw133iMST4JAO4WU-UZ6Q_65w@mail.gmail.com \
    --to=noah.v.peart@gmail.com \
    --cc=67616@debbugs.gnu.org \
    --cc=jm@pub.pink \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).