From: Noah Peart <noah.v.peart@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 70361@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>
Subject: bug#70361: [PATCH] Add font-locking for operators in go-ts-mode.
Date: Sat, 13 Apr 2024 00:53:45 -0700 [thread overview]
Message-ID: <CAPVBTSccb5e=pU1c9YSgoh828Wy5ey7zpzR80MSMxpL+GSRGrQ@mail.gmail.com> (raw)
In-Reply-To: <86mspxr9ra.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]
> What problems do you see with the current approach that would require
more fine-grained user control?
The main issue for me is removing the `error` feature from any mode
that adds it with `:override t`. I find the override font-locking is
jarring - in some
Languages half the buffer can switch in and out of parse errors when you
do something as simple as removing a closing paren.
Also, allowing users to rearrange features at different levels seems like a
bonus.
> And why do you think a defvar is the proper way of providing such control?
You're right, I don't think it's the best way - it's just what I've been
doing in
treesit modes I've written till now.
On Sat, Apr 13, 2024 at 12:40 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Noah Peart <noah.v.peart@gmail.com>
> > Date: Sat, 13 Apr 2024 00:32:59 -0700
> > Cc: 70361@debbugs.gnu.org
> >
> > On a somewhat related note, I was wondering why the treesit modes in
> emacs
> > define their `treesit-font-lock-feature-list`s in the mode definitions.
> >
> > Wouldn't it be more user-friendly to `defvar` the feature list?
>
> AFAIR, we do that in the mode's settings because the translation of
> general categories into mode-specific settings is not easy, and
> because we want users to control that via the fontification level, not
> below that.
>
> What problems do you see with the current approach that would require
> more fine-grained user control? And why do you think a defvar is the
> proper way of providing such control?
>
[-- Attachment #2: Type: text/html, Size: 2155 bytes --]
next prev parent reply other threads:[~2024-04-13 7:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 5:23 bug#70361: [PATCH] Add font-locking for operators in go-ts-mode Noah Peart
2024-04-13 7:20 ` Eli Zaretskii
2024-04-13 7:27 ` Noah Peart
2024-04-13 7:32 ` Noah Peart
2024-04-13 7:40 ` Eli Zaretskii
2024-04-13 7:53 ` Noah Peart [this message]
2024-04-13 9:33 ` Eli Zaretskii
2024-04-14 23:25 ` Yuan Fu
2024-04-14 23:34 ` Yuan Fu
2024-04-15 12:05 ` Noah Peart
2024-04-16 1:49 ` Randy Taylor
2024-04-16 5:57 ` Yuan Fu
2024-04-16 5:58 ` Yuan Fu
2024-04-16 12:34 ` Eli Zaretskii
2024-04-17 2:47 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPVBTSccb5e=pU1c9YSgoh828Wy5ey7zpzR80MSMxpL+GSRGrQ@mail.gmail.com' \
--to=noah.v.peart@gmail.com \
--cc=70361@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).