unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noah Peart <noah.v.peart@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 71209@debbugs.gnu.org, Randy Taylor <dev@rjt.dev>
Subject: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses
Date: Fri, 31 May 2024 19:04:58 -0700	[thread overview]
Message-ID: <CAPVBTScGd1u8U7EBaJx9vE0iCaoqhUGuiFpteAk-XGgwFb1Rdg@mail.gmail.com> (raw)
In-Reply-To: <bb1ea56c-d59b-433c-9eef-dfd53851b813@gutov.dev>

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

> Personally, I stay with the default, among other things because most of
> the level 4 'variable' highlights just take the easy route and highlight
> all the tokens that haven't been matched by any other existing rule.
> That doesn't feel useful to me.

I agree, I used level 4 with the use-face and name-faces being the same
for while, but have since changed use-faces to be only a shade different
from the default face.  It's way more informative to have the decls solidly
stand out.

On Fri, May 31, 2024 at 6:59 PM Dmitry Gutov <dmitry@gutov.dev> wrote:

> On 01/06/2024 04:56, Noah Peart wrote:
> >  > Only if you set treesit-font-lock-level to 4, right?
> >
> > Yea, that's true - I assumed most people(?) do, but I just realized
> > I hadn't been doing that for years until tree-sitter - and now I've
> > become obsessive compulsive about my fonts.
>
> I imagine most actual users just keep in on the default value. But a lot
> customize it, of course, to get closer to "VS Code look".
>
> Personally, I stay with the default, among other things because most of
> the level 4 'variable' highlights just take the easy route and highlight
> all the tokens that haven't been matched by any other existing rule.
> That doesn't feel useful to me.
>

[-- Attachment #2: Type: text/html, Size: 1791 bytes --]

  reply	other threads:[~2024-06-01  2:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-26 12:41 bug#71209: [PATCH] Add font-locking for variables in go-ts-mode range clauses Noah Peart
2024-05-28  2:46 ` Randy Taylor
2024-05-30 13:25   ` Noah Peart
2024-05-30 23:23     ` Dmitry Gutov
2024-06-01  1:09     ` Randy Taylor
2024-06-01  1:42       ` Noah Peart
2024-06-01  1:50         ` Noah Peart
2024-06-01 14:13           ` Dmitry Gutov
2024-06-01  1:51         ` Dmitry Gutov
2024-06-01  1:56           ` Noah Peart
2024-06-01  1:59             ` Dmitry Gutov
2024-06-01  2:04               ` Noah Peart [this message]
2024-06-01 14:13         ` Dmitry Gutov
2024-06-15  7:56           ` Eli Zaretskii
2024-06-27  7:38             ` Eli Zaretskii
2024-06-27  9:29               ` Noah Peart
2024-07-06  7:46                 ` Eli Zaretskii
2024-07-20  9:42                   ` Eli Zaretskii
2024-08-04  7:52                     ` Eli Zaretskii
2024-06-01  1:56       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPVBTScGd1u8U7EBaJx9vE0iCaoqhUGuiFpteAk-XGgwFb1Rdg@mail.gmail.com \
    --to=noah.v.peart@gmail.com \
    --cc=71209@debbugs.gnu.org \
    --cc=dev@rjt.dev \
    --cc=dmitry@gutov.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).