unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: David Ventimiglia <davidaventimiglia@neptunestation.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: 59824@debbugs.gnu.org
Subject: bug#59824: flymake-show-project-diagnotics not updating (eglot for Java with jdtls)
Date: Mon, 5 Dec 2022 14:28:01 -0800	[thread overview]
Message-ID: <CAPTUb8ZtCdWmcDotkbvY0CtbSVGY5ZjUshkwBfQi17VB3VkybQ@mail.gmail.com> (raw)
In-Reply-To: <CALDnm52nYtx3sDaPfACbNOSve0sy1e8EWdCmeSJLeyP_Pess0Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

No worries.  I just updated the bug with the additional info.  I trust you
can take it from here.  Thanks!

On Mon, Dec 5, 2022 at 3:31 AM João Távora <joaotavora@gmail.com> wrote:

> On Sun, Dec 4, 2022 at 11:23 PM David Ventimiglia <
> davidaventimiglia@neptunestation.com> wrote:
> >
> > That seems to have fixed it.  Can you explain what's going on here?
>
> What's going on is "a lot" or "not much" depending on the level of detail
> you're after.
>
> There are two main types of project-wide diagnostic, as described in the
> manual,
> depending on whether the file that the diagnostic refers to is or isn't
> visited by emacs
> with Flymake enabled.
>
> As [1] explains, the unvisited type can be handled by "foreign" or
> "list-only" diagnostics.
> Eglot uses the latter.  When Eglot is activated in a buffer visiting one
> of the files that
> were in 'flymake-list-only-diagnostics' it needs to remember to remove
> that file from
> that list, as it is no longer needed there.  This wasn't happening and my
> patch fixes it.
> The project listing is then refreshed automatically (at least it seems it
> is, according to
> your report).
>
> Hope this helps.
>
> > To my untutored  eye, it looks we're doing the following. [...] Am I
> close?
>
> To be honest, I don't think so. At least I don't recognize in your
> description the design
> I put forth some time ago (and which I had since forgotten until this bug).
>
> João
>
> [1]:
> https://www.gnu.org/software/emacs/manual/html_node/flymake/Foreign-and-list_002donly-diagnostics.html
>
>

[-- Attachment #2: Type: text/html, Size: 2410 bytes --]

  reply	other threads:[~2022-12-05 22:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-04 20:38 bug#59826: flymake-show-project-diagnotics not updating (eglot for Java with jdtls) David Ventimiglia
2022-12-04 20:46 ` bug#59824: " João Távora
2022-12-04 21:03 ` João Távora
2022-12-04 23:22   ` David Ventimiglia
2022-12-05 11:30     ` João Távora
2022-12-05 22:28       ` David Ventimiglia [this message]
2022-12-07 11:34         ` João Távora
2022-12-05 22:27 ` bug#59826: additional info David Ventimiglia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPTUb8ZtCdWmcDotkbvY0CtbSVGY5ZjUshkwBfQi17VB3VkybQ@mail.gmail.com \
    --to=davidaventimiglia@neptunestation.com \
    --cc=59824@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).