From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Pablo Mercader =?UTF-8?Q?Alc=C3=A1ntara?= Newsgroups: gmane.emacs.bugs Subject: bug#25641: 25.1; insert-char function inconsistency Date: Wed, 8 Feb 2017 18:01:06 -0400 Message-ID: References: <83tw8656gf.fsf@gnu.org> <87a89y6ifh.fsf@rosalinde> <87inok7rjf.fsf@rosalinde> <83zihw4lh7.fsf@gnu.org> <87poisgxyh.fsf@rosalinde> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1486591347 21722 195.159.176.226 (8 Feb 2017 22:02:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Feb 2017 22:02:27 +0000 (UTC) Cc: 25641@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 08 23:02:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbaJb-00057u-HO for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 23:02:15 +0100 Original-Received: from localhost ([::1]:33444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbaJh-0005Sm-75 for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 17:02:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbaJS-0005NN-1Q for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 17:02:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbaJO-0008U2-3b for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 17:02:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbaJN-0008Ty-W5 for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 17:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cbaJN-0001Q0-OB for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 17:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pablo Mercader =?UTF-8?Q?Alc=C3=A1ntara?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2017 22:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25641-submit@debbugs.gnu.org id=B25641.14865912745384 (code B ref 25641); Wed, 08 Feb 2017 22:02:01 +0000 Original-Received: (at 25641) by debbugs.gnu.org; 8 Feb 2017 22:01:14 +0000 Original-Received: from localhost ([127.0.0.1]:60598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbaIc-0001Om-83 for submit@debbugs.gnu.org; Wed, 08 Feb 2017 17:01:14 -0500 Original-Received: from mail-io0-f173.google.com ([209.85.223.173]:33832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbaIa-0001OZ-A6 for 25641@debbugs.gnu.org; Wed, 08 Feb 2017 17:01:13 -0500 Original-Received: by mail-io0-f173.google.com with SMTP id l66so2222177ioi.1 for <25641@debbugs.gnu.org>; Wed, 08 Feb 2017 14:01:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yyAnPCGW7+Sph05nJyIr3ze9URpc9cVR9I0/9uhL6dQ=; b=doky/jVw31p9LjNWbhyS6iWYQsyQicE1kAmGGcn+HWCYcb84ZRkSKoge9txShC6SNn djgJxHAOKO/Px1H5iH5PhbE7i94sayXKhUpdQpa+bxUQS6ly7ISa4Yee/ZQ0xDln+9ql 8wrorDk6bkU/SosL/G19vs66YGLIcB2GnBDAVIl1QwsNEWqy7uoGO70zhRfeBs75lVcC vysnMhrf77tfS1v6gY+UKIqhp0JH5GjWA8oIr2Xu8gIPWYnyKd5zqm0mDmqQw6gj4tQF 2C8LWwQa3IeZLp/POCf0Jk6KbUXVAPfIE/9GaE30oasrUIK6yk4BPJfrNslinQbHKuu9 yhJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yyAnPCGW7+Sph05nJyIr3ze9URpc9cVR9I0/9uhL6dQ=; b=IwD7fAyAn2+8CwuXaVDm+3KNJqPqSUlmGdpHBVL4qjXetGn8LC/EHu5DMup9GrhEv2 T89whbPJAy2IYgUwgqO6T+y0YuuPd+9DmU3JVSzZRJ8ZpHg3S0CUwLPoJ/IYhAd4LZu2 TKoJ31w/ztV+hhVgI73Ff/7G3Wy8GKBu/GVHLxe24zZs85tSxeOfDSTSliZEpr6YEt84 nByrdUjXnRQb5FhbcB/2s83QUXPvWX1G0M0Qrqnf7tAq00scom1R+4ciy18Pc5C7xU5s oLQiQXVaDlUh1MHiM/PoE4LRL1gK3KQBdaufc11adGLPcYoMuuRJ5ksMULkYNtLBJYcv MpjQ== X-Gm-Message-State: AMke39l7TjF7qAxgczAPS5bfhtD8+d5vVLZAu4XV8FtNMv0+SIDhLk0wnkaqIwYtyvwu4TDLh0beS6N19WQHRg== X-Received: by 10.107.48.199 with SMTP id w190mr381646iow.117.1486591266542; Wed, 08 Feb 2017 14:01:06 -0800 (PST) Original-Received: by 10.107.132.1 with HTTP; Wed, 8 Feb 2017 14:01:06 -0800 (PST) In-Reply-To: <87poisgxyh.fsf@rosalinde> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129134 Archived-At: oooh cool! thanks again! 2017-02-08 17:43 GMT-04:00 Stephen Berman : > On Wed, 08 Feb 2017 19:54:12 +0200 Eli Zaretskii wrote: > >>> From: Stephen Berman >>> Date: Wed, 08 Feb 2017 14:15:00 +0100 >>> Cc: 25641@debbugs.gnu.org >>> >>> I agree. The following patch does that (the special-casing here has a >>> precedent in ucs-names in mule-cmds.el, from which the comment is >>> copied): >>> >>> diff --git a/lisp/descr-text.el b/lisp/descr-text.el >>> index 3971dbb..a1efb67 100644 >>> --- a/lisp/descr-text.el >>> +++ b/lisp/descr-text.el >>> @@ -617,7 +617,14 @@ describe-char >>> "input method") >>> (list >>> (let ((name >>> - (or (get-char-code-property char 'name) >>> + (or (when (= char 7) >>> + ;; Special case for "BELL" which is >>> + ;; apparently the only char which >>> + ;; doesn't have a new name and whose >>> + ;; old-name is shadowed by a newer char >>> + ;; with that name. >>> + (car (rassoc char ucs-names))) >>> + (get-char-code-property char 'name) >>> (get-char-code-property char 'old-name)))) >>> (if (and name (assoc-string name (ucs-names))) >>> (format >>> >>> Eli, what do you say? >> >> I don't mind, but ucs-names might be nil if the function by the same >> name was not yet called, so I think we should call it first. > > Oh yes, I should have noticed that. > >> Also, I think it would be good to mention this bug report in the >> comment. > > Done and pushed to master as 90f76eb. > > Steve Berman