From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Al Petrofsky Newsgroups: gmane.emacs.bugs Subject: bug#64075: 28.2; ispell broken on uncolored terminals Date: Thu, 15 Jun 2023 02:34:48 -0400 Message-ID: References: <42ff58c7e8e4095a1f34@heytings.org> <835y7puw0z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009729f805fe2544cd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32774"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64075@debbugs.gnu.org, gregory@heytings.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 15 08:37:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9gbw-0008QA-49 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jun 2023 08:37:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9gbe-0004EE-NR; Thu, 15 Jun 2023 02:37:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9gaS-0002jt-K7 for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 02:36:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9gaR-0005GZ-0J for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 02:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9gaQ-0007lg-GA for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 02:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Al Petrofsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jun 2023 06:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64075 X-GNU-PR-Package: emacs Original-Received: via spool by 64075-submit@debbugs.gnu.org id=B64075.168681090929778 (code B ref 64075); Thu, 15 Jun 2023 06:36:02 +0000 Original-Received: (at 64075) by debbugs.gnu.org; 15 Jun 2023 06:35:09 +0000 Original-Received: from localhost ([127.0.0.1]:46014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9gZY-0007kE-MK for submit@debbugs.gnu.org; Thu, 15 Jun 2023 02:35:09 -0400 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]:41310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9gZX-0007jk-SS for 64075@debbugs.gnu.org; Thu, 15 Jun 2023 02:35:08 -0400 Original-Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-25bc399535bso1027453a91.1 for <64075@debbugs.gnu.org>; Wed, 14 Jun 2023 23:35:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686810902; x=1689402902; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hDWrPe4GcnhgNZvVuuXVb4NgKUXMvuuRw3ZM+CrZY/A=; b=EDiGs1wBEcuvVJaEpsMMEDQ4vdChS7q/oobvTrHDWtTgjHOpslRFtk2IwKCiBU/8aK wlYdZDie2dVvo9ShlnrmTP4eX71+NwBgqCBNFSAEtUtWoDZ/laA5a1mM7EyUMC+7p9Qe IRKC4WxTpieBYfAP5tSHe4WDtMsZKa2Pb/wXs5XkTSO3UKh3RNrF1wlUhRxbbZODPY9P 1SJjsGVd9FGZ/6d1zeNup1IIAcd5UAfwlVbTG2up+OH6ZFHekYwUqK00kCZRUcxrThlK j9n0eLTfwML6mqVZ8L3sFzwhH+3TxDUEm+btAWitTjdzU0getND2ADuhyZPVJxrAnLxs O6vw== X-Gm-Message-State: AC+VfDwBInJRSFCJrL8uEpSSEZAQ2IRm2mkDKhr843pgSsPCPLx9pWCF wuhIncfbe18LuFbIuwZwHdn0tAB+f4/qNgbA0xc= X-Google-Smtp-Source: ACHHUZ567qYvCRjOehZoAbS/N/0K6YyX4CG9vN9byUFz+dWLO2BF7rDaMEzHK4lSGRYHdZvPCk1o+PUkuGMVkow6TxE= X-Received: by 2002:a17:90b:1c08:b0:252:b342:a84a with SMTP id oc8-20020a17090b1c0800b00252b342a84amr20135581pjb.0.1686810901554; Wed, 14 Jun 2023 23:35:01 -0700 (PDT) In-Reply-To: <835y7puw0z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263402 Archived-At: --0000000000009729f805fe2544cd Content-Type: text/plain; charset="UTF-8" I apologize if I'm misunderstanding things. I'm certainly not suggesting removing any functionality that is useful on old monochrome ttys. The reason I became aware of this bug is that I am using a monochrome tty. > > Still, this anachronistic kludge should really be nuked entirely. > Why? And what's "anachronistic" about that code? What's anachronistic about that code (meaning the ispell-highlight-spelling-error-generic function) is that it uses a kludge that made it possible in pre-version-21 emacs to get some text displayed in inverse video on a tty even though emacs could not display faces on ttys. But since Emacs 21, on any tty that has a termcap "so" capability, you can get inverse-video simply by using an inverse-video face. So I don't think ispell-highlight-spelling-error-generic currently provides any functionality that isn't more conveniently and maintainably provided by ispell-highlight-spelling-error-overlay, with the additional benefit that the user can, if he wants, customize ispell-highlight-face to something other than inverse-video. (Making the default isearch face (and therefore the default ispell-highlight-face) be blue-on-magenta on color terminals but inverse-video on monochrome terminals is already handled automatically.) --0000000000009729f805fe2544cd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

I apologize= if I'm misunderstanding things.=C2=A0 I'm certainly not
suggest= ing removing any functionality that is useful on old monochrome
ttys.=C2= =A0 The reason I became aware of this bug is that I am using a
monochrom= e tty.

> > Still, this anachronistic kludge s= hould really be nuked entirely.

> Why?=C2=A0 And what's "= ;anachronistic" about that code?

What's anachronistic about= that code (meaning the
ispell-highlight-spelling-error-generic function= ) is that it uses a
kludge that made it possible in pre-version-21 emacs= to get some text
displayed in inverse video on a tty even though emacs = could not
display faces on ttys.=C2=A0 But since Emacs 21, on any tty th= at has a
termcap "so" capability, you can get inverse-video si= mply by using an
inverse-video face.

So I don't think ispell-= highlight-spelling-error-generic currently
provides any functionality th= at isn't more conveniently and
maintainably provided by ispell-highl= ight-spelling-error-overlay, with
the additional benefit that the user c= an, if he wants, customize
ispell-highlight-face to something other than= inverse-video.

(Making the default= isearch face (and therefore the default
ispell-highlight-face) be blue-= on-magenta on color terminals but
inverse-video on monochrome terminals = is already handled
automatically.)
=C2=A0
--0000000000009729f805fe2544cd--