From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#41934: reverse-region no longer works Date: Thu, 18 Jun 2020 18:59:21 +0100 Message-ID: References: <83lfkkz2wr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="29919"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41934@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 18 20:00:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlyph-0007ex-8i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Jun 2020 20:00:13 +0200 Original-Received: from localhost ([::1]:35594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlypg-0001v1-9Z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Jun 2020 14:00:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlypW-0001us-Hr for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 14:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42803) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlypW-00036H-3r for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 14:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jlypV-0006cD-Vo for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 14:00:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jun 2020 18:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41934 X-GNU-PR-Package: emacs Original-Received: via spool by 41934-submit@debbugs.gnu.org id=B41934.159250319625394 (code B ref 41934); Thu, 18 Jun 2020 18:00:01 +0000 Original-Received: (at 41934) by debbugs.gnu.org; 18 Jun 2020 17:59:56 +0000 Original-Received: from localhost ([127.0.0.1]:54349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlypP-0006bW-Pe for submit@debbugs.gnu.org; Thu, 18 Jun 2020 13:59:56 -0400 Original-Received: from mail-oi1-f171.google.com ([209.85.167.171]:37292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlypN-0006bI-A1 for 41934@debbugs.gnu.org; Thu, 18 Jun 2020 13:59:54 -0400 Original-Received: by mail-oi1-f171.google.com with SMTP id a3so5910909oid.4 for <41934@debbugs.gnu.org>; Thu, 18 Jun 2020 10:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xPNmThfehWpYRCU0MsDcmcXs81cQl0ZZ46UnyC83xOc=; b=Y1lwo94gCTzBHKq6n8UiCXND68LUiB+MCE5Nvl8mV0EgGpX2V33b/M4ct6rKra4SJf SKUMWw6LxTfBpHjSoPe96QqWPI4Wtjh0THUSFfmSlwQih0PA+c4LQ+5s55OIPE+sk7Ie vmN3LUgL0rgu5pBwZtku0ftn8Hihm/ujfxfK5H5+6HyxcB4x14VwPjLcB4Hwp//eXHbt n4mCZP3Y/BeS6frLB1d1vEZEKcCpQJtuxwB/7ROIWXRWGXBJCEi3kTk56PWP+xM9V1Mc upLWqqtRBJ18iBJ7P25TmWbAue0GTPJfukiuaLlRoYp6EaaqIVfvSA33FqyHwTj1aZcS H0Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xPNmThfehWpYRCU0MsDcmcXs81cQl0ZZ46UnyC83xOc=; b=XIIhE9BRfCVlKJtE/z+Y/h4Kok1XPgZlUw9AUgCj7iSpgFSgBcx1aihE25k/fNTJuw ufLet/BNq3YUbvLdM7xjfQIKEpvbyRnAcpZV4+UN7DNo8C9rfxlSE6gH7VwAf2dngfBL +RTIDYBpDYvrg19nYBDjrC9dWFBSAKqFHWSLb6dfI5Yt6Fv8h7+4gwSC1SwXD3IC8rQU VxjKjFVoW6jgAVeKzai74y1/p3PZgfkrZjGXY24aBvzgxGv6OC1z7LaB+099c2Zp5Z7d 8feIzhD4C9R6oYF4MUE5/IJ0u3dgoKDWG6eCXsk2vFdG+hSGZkKGIExlzZJrB46Wj1xK vJJg== X-Gm-Message-State: AOAM531C+tdh3s0d5HKCT5vrXyaNzuAVj8/+JJ00li6XxDO3c9vZ/+Ld MCWdz4zytvff968bnIe6tKlt6AigiUzCmIVBUQQ7lpPN X-Google-Smtp-Source: ABdhPJxDK+Fbu+ynH+anubQiGtoqgXkMVRF7BL5hB11QOCcKcQ3nE6JRs92jvZBeNoxGqyqR378lMC+H0QaWjb9PrB0= X-Received: by 2002:aca:f255:: with SMTP id q82mr3863195oih.153.1592503187652; Thu, 18 Jun 2020 10:59:47 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182130 Archived-At: On Thu, 18 Jun 2020 at 18:52, Richard Copley wrote: > On Thu, 18 Jun 2020 at 18:42, Eli Zaretskii wrote: > Thanks, > No, that fails on this example [...] How's this? diff --git a/lisp/sort.el b/lisp/sort.el index de0e1b9519..f878db24a3 100644 --- a/lisp/sort.el +++ b/lisp/sort.el @@ -554,9 +554,6 @@ is the one that ends before END." (if (> beg end) (let (mid) (setq mid end end beg beg mid))) (save-excursion - (when (or (< (line-beginning-position) beg) - (< end (line-end-position))) - (user-error "There are no full lines in the region")) ;; Put beg at the start of a line and end and the end of one -- ;; the largest possible region which fits this criteria. (goto-char beg) @@ -568,6 +565,8 @@ is the one that ends before END." ;; reversal; it isn't difficult to add it afterward. (or (and (eolp) (not (bolp))) (progn (forward-line -1) (end-of-line))) (setq end (point-marker)) + (when (<= end beg) + (user-error "There are no full lines in the region")) ;; The real work. This thing cranks through memory on large regions. (let (ll (do t)) (while do