From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#28268: 26.0.50; (MS Windows) crash on C-g after closing Git GUI Date: Tue, 29 Aug 2017 17:48:36 +0100 Message-ID: References: <83wp5m2yim.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1504025425 32413 195.159.176.226 (29 Aug 2017 16:50:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 29 Aug 2017 16:50:25 +0000 (UTC) Cc: 28268@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 29 18:50:18 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmjiI-0007Uw-VV for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Aug 2017 18:50:07 +0200 Original-Received: from localhost ([::1]:46100 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmjiP-0004Ek-TJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Aug 2017 12:50:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmjiI-0004Bs-Df for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2017 12:50:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmjiF-0000Yp-BI for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2017 12:50:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dmjiF-0000Ye-8E for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2017 12:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dmjiF-0004GU-1F for bug-gnu-emacs@gnu.org; Tue, 29 Aug 2017 12:50:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Aug 2017 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28268-submit@debbugs.gnu.org id=B28268.150402535416317 (code B ref 28268); Tue, 29 Aug 2017 16:50:02 +0000 Original-Received: (at 28268) by debbugs.gnu.org; 29 Aug 2017 16:49:14 +0000 Original-Received: from localhost ([127.0.0.1]:60939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmjhS-0004F7-H8 for submit@debbugs.gnu.org; Tue, 29 Aug 2017 12:49:14 -0400 Original-Received: from mail-vk0-f48.google.com ([209.85.213.48]:35189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmjhQ-0004Es-HR for 28268@debbugs.gnu.org; Tue, 29 Aug 2017 12:49:13 -0400 Original-Received: by mail-vk0-f48.google.com with SMTP id z187so11148830vkd.2 for <28268@debbugs.gnu.org>; Tue, 29 Aug 2017 09:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Ew/1uyMB2FeVJHBee++6WxN4b1J/nKQtKxDImuiSne8=; b=cXyPl1Cv6U/1Ui+/onoY2gs1uTitzPZBvk+SnrGBAVhd2K93RIB0Lm9f7tAI2x3HbX vSm4+CClj6+wELlQTi6kPgXisSsp6uarbkJS/w2vavCfKyEXq7xQE42oneBLU93diWtW OYRGQgdoW65KtXiy1aC673uWSVdzTFC2rFa/471pMXmtFn5c284xqKLoNXLPej49QBvk 0jpha42ajWJL262ToblCBJ4l12Zd/PWl65TNw9j9hM6NRuZFAER4C+qLE7QWNkg89RFf zQx3w3SM5g29eMTf6GuLsRsVFY79KYK9VDBRjfT1TjW5qKHU2161ubRDn/KIficATQ7s pe+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ew/1uyMB2FeVJHBee++6WxN4b1J/nKQtKxDImuiSne8=; b=K0WlVLJ2di/f6YQOMFni7kCPlKP7WFbVxMB7CMqXHCRJc0vgHKotrFLZ5jw8wmsvre tekojWRkSXK1DfpOGieNsx364AnKutbCETE78dbJrt5FWpTXcArastcw8qxAS1awkofi dYG90qLiFnSixX/rZe3Yd0WRt2foNO5tcM65E5GyfZaVF23/sQaXbtc0qxZPhd0pW/Ar Mh64W6NT2Q5wjA8MX7GLmA7zZZ89++5GKbpc3STlDi2mn8a/TcMQBZq3dwCkCIcHuYV3 W5eL1fYO1sEmX7l/8G5rwR4ZGJEcQFmitUwt5+t9xSj5IfYTGYn701iqQBp9iGF6nL65 ajEQ== X-Gm-Message-State: AHYfb5gcUYI6/DQUcLKZfwc0yetxNa777TcTLlqQIbExDGxIzRQ86kS4 mx/wJb5SOc5UQlkfStMwYfjhTmsC1Q== X-Received: by 10.31.238.198 with SMTP id m189mr590351vkh.87.1504025346900; Tue, 29 Aug 2017 09:49:06 -0700 (PDT) Original-Received: by 10.176.81.167 with HTTP; Tue, 29 Aug 2017 09:48:36 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136335 Archived-At: On 29 August 2017 at 17:38, Noam Postavsky wrote: > On Tue, Aug 29, 2017 at 11:18 AM, Eli Zaretskii wrote: >>> Recipe: >>> >>> Visit a git repo. >>> C-x g ; magit-status >>> ! g ; magit-run-popup, magit-run-git-gui >>> ;; A nasty-looking window pops up (Git GUI, I presume). Close it. >>> C-g ; Crashes. >> >> I couldn't reproduce this here: the Git GUI didn't pop up for me. >> Perhaps something is missing from the recipe ("C-x g" was also >> unbound), or maybe it's because my Git is configured to be run only >> from Git Bash, not from anywhere else on Windows. > > I can't reproduce this here either. I need the patch at [1] to make > the GUI pop up, but even after applying that I get no crash. > > (magit provides a Makefile such that "C-x g" is bound to magit-status > if you do 'make emacs-Q', although I don't normally use this on > Windows since I don't have 'make' on PATH) > > [1]: https://patch-diff.githubusercontent.com/raw/magit/magit/pull/3155.patch It doesn't turn out to be a Magit bug. Please try this recipe instead. Evaluate this: (async-shell-command "\"C:\\Program Files\\Git\\cmd\\Git-GUI.exe\"") Now type C-g in Emacs about 6 times to see the abort. Note that the abort is fixed by Eli's recent change.