From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#70541: track-changes-mode logs warnings (with input method, in Eglot buffer) Date: Sat, 4 May 2024 19:08:14 +0100 Message-ID: References: <86ttjr2pzw.fsf@gnu.org> <86edau3gyy.fsf@gnu.org> <8634ra36ny.fsf@gnu.org> <861q6ou2cs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6103"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70541@debbugs.gnu.org, Eli Zaretskii , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 04 20:10:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3Jq3-0001Gq-9S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 May 2024 20:10:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3Jpb-0004gy-V5; Sat, 04 May 2024 14:09:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3JpN-0004eT-Ml for bug-gnu-emacs@gnu.org; Sat, 04 May 2024 14:09:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3JpL-0006Xt-3x for bug-gnu-emacs@gnu.org; Sat, 04 May 2024 14:09:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3Jph-0006rS-UB for bug-gnu-emacs@gnu.org; Sat, 04 May 2024 14:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2024 18:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70541 X-GNU-PR-Package: emacs Original-Received: via spool by 70541-submit@debbugs.gnu.org id=B70541.171484615526328 (code B ref 70541); Sat, 04 May 2024 18:10:01 +0000 Original-Received: (at 70541) by debbugs.gnu.org; 4 May 2024 18:09:15 +0000 Original-Received: from localhost ([127.0.0.1]:55004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Jow-0006qa-E9 for submit@debbugs.gnu.org; Sat, 04 May 2024 14:09:15 -0400 Original-Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]:53621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Joq-0006qP-T9 for 70541@debbugs.gnu.org; Sat, 04 May 2024 14:09:12 -0400 Original-Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-22ed075a629so384789fac.3 for <70541@debbugs.gnu.org>; Sat, 04 May 2024 11:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714846120; x=1715450920; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=F5jffGqHk4WRFjzeoaKdex/CDiQB5dNukUP2dIaRE9o=; b=Wx2zM8znFjHwpRQuDFMc37xWyEv7IobdlN7/wYE8g7bAOFs38YBZBLxHasseLc9mxa aJygATmeR5o8DvyoACz102RB659NBS1aJc+ccYFMICqOz2y9Mb+LDX5m7+Gg7s6h6bpF WYTPC7+na89c8sStsCBa2KuJWToLxe2Rqrxr501Ish5Do6Q71BCkLbT5ea3Aq7WdMqv8 GolnE9f/YXqYIj/b+tMh6q1dvoibmbHF7pv7FkupuP9F6t1Kx86bt82HqqjmYmuPwEdo 4R3QUcPos/cPvwpbRTo3dJ2LEwNf4tB9IX3EXMxofMOUoG5rBhtkjqpQTE0M4Djyie4r USTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714846120; x=1715450920; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F5jffGqHk4WRFjzeoaKdex/CDiQB5dNukUP2dIaRE9o=; b=OeYx2lEUWtpCagKj+WVMNF1LYfbzH7ICv7Mj/1Lb0tgQliiv3O2GMirTJNNe1/Pswl fZY2sHUx8Fxm14+pu+ws/InoPxeZqzIwUoMoUu9naLrYWVasvurtUx3ud1OUyb+Pf3dJ GCiC18b7vNSxMRcVxVbqRhIrc++KcuxPVnxDsWk2ge3hoWQD3Wvus3leEq3LqpaDq/F0 75/7JfSkdtu7/iI4m04kGDf8CDmYQrvdpmfrclwUIRc6r2GJkvYfeVFt8RPT8xFBktEt w6hVchPVTLasApUbwvqRS3hclwc6vQn4kLRBryUdO72nMHK3w6ElYwU4v+UYI6gvwo65 NaWQ== X-Forwarded-Encrypted: i=1; AJvYcCV3ABFFZvVY4Ki0Xv52WdFqB8L6ndZep7Nf3SPEsNR+nZRm+CPTxyD6rCZXJpboqD3og/64QoSr72txaOo6/TSaRKLkUOQ= X-Gm-Message-State: AOJu0YxIhP/sqtwqSJS7SeA8lcjF0hA14sYYpGlcsWlvvIK4S2R2vo1o y4Jw5pzHurYsxnJZzSTwWl+e4B3Pw1zBVnVSyzOA0pr62r9EMvaadHeTQ5Mtu+YFOsVBoysDkyh dWLb64dZ7Iizgh/n54nacsQsX03zSmnpl X-Google-Smtp-Source: AGHT+IFlXY5kLY+HaffnSNvdk9fM2aRuqktspp8wBGmCHIMfOmdbOLWW0AjgPRXgYFKwvHDxNh+c0zMJJzNTX9bgokc= X-Received: by 2002:a05:6870:d212:b0:239:792d:c6b8 with SMTP id g18-20020a056870d21200b00239792dc6b8mr7317679oac.0.1714846119826; Sat, 04 May 2024 11:08:39 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284455 Archived-At: On Fri, 3 May 2024 at 18:27, Stefan Monnier wrote: > I just pushed a patch to `master` which does that. > Richard, can you confirm it fixes the problem on your end? On Fri, 3 May 2024 at 21:56, Stefan Monnier wrote: > It seems to work OK for me now, but I'd like to hear other people's > experience with it. Thanks Stefan. One can trigger the track-changes signal in such a way as to defeat the new check, as follows. * Ensure clangd is on the path. * Visit a C++ file with these contents: void f () { int x = 0; int a = b; } * Start Eglot. (The "b" is highlighted to indicate an error.) * Enable the TeX input method. * Put point after the zero. * (Enter the bad state.) Quickly, type [ ^]. Pause. * Type [ y]. (No error highlight on "y".) * Move point to before the "x". (No "variable x" echo from Eldoc.) * Move point back to after the "y". * Type [ z] again. (Still no error highlight on "z".) * Type [SPC]. (Highlight on "b" is now rendered incorrectly.) * (Exit the bad state.) Type [C-n SPC ]. Expected behaviour: After typing "y", Eglot sends "textDocument/didChange", clangd sends "textDocument/publishDiagnostics" and Flymake highlights the "y" to indicate an error. Actual behaviour: After typing "y", no "textDocument/didChange" is sent and the "y" is not highlighted. Further edits at the same buffer position (even after moving point away and back again) do not recover the expected highlighting, and point motion doesn't trigger LSP hover messages, until one returns to a normal state by making changes elsewhere in the buffer. If this happens when an edit was made with the intention of getting feedback from the language server, it will be inconvenient.