From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#41934: reverse-region no longer works Date: Thu, 18 Jun 2020 18:52:48 +0100 Message-ID: References: <83lfkkz2wr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="1706"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41934@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 18 19:54:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlyjp-0000LG-Vp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Jun 2020 19:54:09 +0200 Original-Received: from localhost ([::1]:33446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlyjo-00067t-PI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Jun 2020 13:54:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlyji-00067E-N0 for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 13:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlyji-0001tF-E0 for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 13:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jlyji-0006TD-Da for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2020 13:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jun 2020 17:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41934 X-GNU-PR-Package: emacs Original-Received: via spool by 41934-submit@debbugs.gnu.org id=B41934.159250280224819 (code B ref 41934); Thu, 18 Jun 2020 17:54:02 +0000 Original-Received: (at 41934) by debbugs.gnu.org; 18 Jun 2020 17:53:22 +0000 Original-Received: from localhost ([127.0.0.1]:54345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlyj4-0006SE-45 for submit@debbugs.gnu.org; Thu, 18 Jun 2020 13:53:22 -0400 Original-Received: from mail-ot1-f50.google.com ([209.85.210.50]:41984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlyj2-0006S1-Dp for 41934@debbugs.gnu.org; Thu, 18 Jun 2020 13:53:20 -0400 Original-Received: by mail-ot1-f50.google.com with SMTP id t6so5211724otk.9 for <41934@debbugs.gnu.org>; Thu, 18 Jun 2020 10:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Wa6/0FOt1HqB6BfxDjh5xYfvrqQrhIbI9yOMgemacUM=; b=J2l31dLTsW003GAAa0x15IbcbsZwL9vx4xRRAj2+u+cI96DX/7Rtgl+1ONy6qxk/2L fbjKWLsXlpeJsJmGOz7YKeGjggzczGO8U72+r7ZhVr69KWhqJpkvFy4GAgC2oYcVwm1T IzzMl7maxFjKPNZR2E8BFXAbRCjHobX/T/814KYRcE7sazYq/Kj8ee+ZkesDoUYrllv8 AOZzPdL/dfFMRw3a0BVtdiGHWWw+beCZCB0RuZJqU/f05p0KNxHRyCvfqdGfQ2NV6HpK vUnp7v5wcKNhAsHdxzJHCAyqim6CYw/p1NQL/rytC2Oi9FnTvS+Lop2wvktLEnBpUZOU 5GQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wa6/0FOt1HqB6BfxDjh5xYfvrqQrhIbI9yOMgemacUM=; b=Y6sDXUzqaZXeEoY1tUiCPtI67o6aY6+/Q8MD0B2AN4P31xxTFfyNRVW3lQD9QNbLwH LETh1EZTfgR/ZlRJLvcJakEx/Fr9PeXSi2biJ7uM5qUkiNyV/is0cJ115hmCbb66eXHB tjJG3+g7sr+WnPtyP+IIiU1tKix2fL0NRecb3kdIaBju5QbPm7xbBzrWOV/qYW2GI920 tyPwQztbRFzxalB3oxkHdNjv2gDK2njYkqY216nhZoSynnOEY0tcYxOZR8qQdlx5sPRA OB4kTGVvU9FCfceiUSPCDFv83pTKVwTtm50QgO4V0H2cZmKfFLBJ4S9tiFR6Pt0zV75r t9Kw== X-Gm-Message-State: AOAM531dPIwV5+lrLnTqLVEaqbdJVo2n5+slGX9YYbSFO5o6OJzXzHzp CFhKcgs1P1uImskDo0wV4dMPBa9A4PaUVEHJBcY= X-Google-Smtp-Source: ABdhPJzEVZi7Jox85Km8/Zw5CfLXYB/tVi4YC2EZOyu2hste9jXiHltQPvcuQfydEwy4B4wCryWDuHcKCYfoOSlALBc= X-Received: by 2002:a05:6830:3104:: with SMTP id b4mr4696051ots.192.1592502794690; Thu, 18 Jun 2020 10:53:14 -0700 (PDT) In-Reply-To: <83lfkkz2wr.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182129 Archived-At: On Thu, 18 Jun 2020 at 18:42, Eli Zaretskii wrote: > diff --git a/lisp/sort.el b/lisp/sort.el > index de0e1b9..6640c8f 100644 > --- a/lisp/sort.el > +++ b/lisp/sort.el > @@ -554,8 +554,8 @@ reverse-region > (if (> beg end) > (let (mid) (setq mid end end beg beg mid))) > (save-excursion > - (when (or (< (line-beginning-position) beg) > - (< end (line-end-position))) > + (when (< (- end beg) > + (- (line-end-position) (line-beginning-position))) > (user-error "There are no full lines in the region")) > ;; Put beg at the start of a line and end and the end of one -- > ;; the largest possible region which fits this criteria. Thanks, No, that fails on this example: [mark]abc def [point]abcdefghi