From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#37852: Build failure on MSYS2 (undefined reference to _chk functions) Date: Wed, 23 Oct 2019 22:29:09 +0100 Message-ID: References: <83h8411p4u.fsf@gnu.org> <83o8y8zka3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000063d4705959a9dd4" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="160587"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Paul Eggert , 37852@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 23:31:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNODz-000fcv-0d for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 23:31:23 +0200 Original-Received: from localhost ([::1]:48612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNODv-0005kd-UU for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 17:31:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46771) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNOCj-0005a3-SY for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 17:30:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNOCh-0006kI-RD for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 17:30:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54502) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNOCg-0006hD-Bb for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 17:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNOCg-0007KE-53 for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37852 X-GNU-PR-Package: emacs Original-Received: via spool by 37852-submit@debbugs.gnu.org id=B37852.157186618728117 (code B ref 37852); Wed, 23 Oct 2019 21:30:02 +0000 Original-Received: (at 37852) by debbugs.gnu.org; 23 Oct 2019 21:29:47 +0000 Original-Received: from localhost ([127.0.0.1]:35090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNOCO-0007JO-Ip for submit@debbugs.gnu.org; Wed, 23 Oct 2019 17:29:47 -0400 Original-Received: from mail-oi1-f169.google.com ([209.85.167.169]:44253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNOCL-0007J7-8K for 37852@debbugs.gnu.org; Wed, 23 Oct 2019 17:29:42 -0400 Original-Received: by mail-oi1-f169.google.com with SMTP id s71so5866865oih.11 for <37852@debbugs.gnu.org>; Wed, 23 Oct 2019 14:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aJZSXPkPBrerU9YvHH5eLB6iBr2nTZAdAqdm4omIRbU=; b=WrqMb9EIMs6skDKKViwxd+jLWMDcgcfhGdmkf2RyQJcdXqc4+poiOqYHMOMbrMZ6sF ca33jBxm9fHX8Ibzaa1xr9aAzhVKs5j1p6+2AD3SNSVoDrPk2Yu911ZrnA/c/MlFjpPu ZIE9HZtr8zWE88IKVZUkBEjmYytpI0wD7TQa+/6an04CgXOdMgKCjjE1x512e6zQswq5 Noy4iSojs/AtaBl8kwPuWGE9UFQMuSol1wVt3H2XmW5CxHNHOk4HHqp/Li8H5YFblpQl y0nQX1Ns6USBkPljJizYfqKxICJ2qWG8t6irkYlGzOiU3Jjxq+x5D6mZsuScM5WNnkW6 uIVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aJZSXPkPBrerU9YvHH5eLB6iBr2nTZAdAqdm4omIRbU=; b=pCUcoR1sW9cF9VjauCg7yRSA6uOtv4/wILoU/oihqc410uVPFf6Zh16imfGUTPmoRB /L3TDYdS2NBfZFfFofKL5D8pDAVrpRcrG1RlpH/5SbIGKMkkP8PJtbzZM/w10hEdW7yY v1iVhQyuRiG8anWaSS/9MJDz9iQGCbCfiGCjO7E2+wGAksqkZV3tOH6pey84cKyHLHTe Ogj6r/vS0fU2+HzsL19inRd05vP922AqtuWIgdGQRAMPuIYk56mHCtUvXVpAGTKseQGu UAfJGJPGRr4zX23zjBWV3VUXITogC5q6ZmmcfQp0neY3HFOI8YMS99JbiM3DBlPsvWj/ sk2w== X-Gm-Message-State: APjAAAXOJM7SEXtCcEzVGUJedd2zBZNAdUY8K0s5mu13akv6JmH7Fcrt kBoIHMjcYNb7kF6lBYTdz8Dw9fMmMGe/gNRfmbA= X-Google-Smtp-Source: APXvYqw25zDla8XdMi0O3CyeiJ5jBmJi+94lHkZ2UTXMPXqCsrkAbIQPHi1UJxPYvSyXLPX1cO6cXVDlFOVDPx58yr8= X-Received: by 2002:aca:df84:: with SMTP id w126mr1771222oig.79.1571866175485; Wed, 23 Oct 2019 14:29:35 -0700 (PDT) In-Reply-To: <83o8y8zka3.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170097 Archived-At: --000000000000063d4705959a9dd4 Content-Type: text/plain; charset="UTF-8" On Tue, 22 Oct 2019 at 19:51, Eli Zaretskii wrote: > > Cc: 37852@debbugs.gnu.org, rcopley@gmail.com > > From: Paul Eggert > > Date: Tue, 22 Oct 2019 11:27:48 -0700 > > > > > Should we perhaps test for -lssp, and if it is found, add it to the > > > link command when we define _FORTIFY_SOURCE? > > > > If this is done only on MSYS2 platforms, and if -lssp is used only when > > it causes otherwise-failing programs to work, then it should be OK. I > > wouldn't do it elsewhere because on Fedora at any rate, -lssp used to be > > trouble and was best avoided. > > Right. > > > It vaguely sounds like MSYS2 is trailing Fedora and so is experiencing > > problems Fedora had a few years ago (see, e.g., > > ). > > I actually think it's a bug in MSYS2, and hope they will fix it soon. > So perhaps we should just wait and see if the current situation, after > your patch, is good enough. > > Thanks. > Just to confirm, this fix works for me. Thank you. --000000000000063d4705959a9dd4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, 22 Oct 2019 at 19:51, Eli Zaretskii <eliz@gnu.org> wrote:
> Cc: 37852@debbugs.gnu.org, rcopley@gmail.com
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Tue, 22 Oct 2019 11:27:48 -0700
>
> > Should we perhaps test for -lssp, and if it is found, add it to t= he
> > link command when we define _FORTIFY_SOURCE?
>
> If this is done only on MSYS2 platforms, and if -lssp is used only whe= n
> it causes otherwise-failing programs to work, then it should be OK. I =
> wouldn't do it elsewhere because on Fedora at any rate, -lssp used= to be
> trouble and was best avoided.

Right.

> It vaguely sounds like MSYS2 is trailing Fedora and so is experiencing=
> problems Fedora had a few years ago (see, e.g.,
> <https://cve.mitre.org/cgi-bin= /cvename.cgi?name=3DCVE-2016-4973>).

I actually think it's a bug in MSYS2, and hope they will fix it soon. So perhaps we should just wait and see if the current situation, after
your patch, is good enough.

Thanks.

Just to confirm, this fix works= for me. Thank you.

--000000000000063d4705959a9dd4--