From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 Date: Thu, 19 Sep 2013 15:16:49 +0100 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0160bc9471ba8804e6bd3414 X-Trace: ger.gmane.org 1379600295 10242 80.91.229.3 (19 Sep 2013 14:18:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Sep 2013 14:18:15 +0000 (UTC) To: 15418@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 19 16:18:16 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VMf3c-0005wc-Ks for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Sep 2013 16:18:12 +0200 Original-Received: from localhost ([::1]:51423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMf3c-0001DY-2x for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Sep 2013 10:18:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMf3X-0001CT-VT for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:18:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMf3T-0003qK-19 for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:18:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMf3S-0003qB-U4 for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VMf3S-0001fQ-9Q for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Sep 2013 14:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.13796002366336 (code B ref -1); Thu, 19 Sep 2013 14:18:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Sep 2013 14:17:16 +0000 Original-Received: from localhost ([127.0.0.1]:49232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMf2f-0001e6-Dc for submit@debbugs.gnu.org; Thu, 19 Sep 2013 10:17:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41286) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMf2c-0001do-Ap for submit@debbugs.gnu.org; Thu, 19 Sep 2013 10:17:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMf2V-0003XE-4E for submit@debbugs.gnu.org; Thu, 19 Sep 2013 10:17:04 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMf2V-0003X4-0g for submit@debbugs.gnu.org; Thu, 19 Sep 2013 10:17:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMf2P-00019e-KO for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:17:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMf2J-0003Ng-OQ for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:16:57 -0400 Original-Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:58643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMf2J-0003NR-D2 for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:16:51 -0400 Original-Received: by mail-ea0-f180.google.com with SMTP id h10so4152435eaj.25 for ; Thu, 19 Sep 2013 07:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=0uEQdoBy2xxOXHz23FQIGyt17K3F3M1sP6uATg0tb9k=; b=diRnpy8O6SQTlODkoUxHg2LFHzhNxzC8SS64gY19hL4+wWthwIzEO8qoPCEvetWgdG OfmXH8iFGyUPsgjeYBXTbwAGuwfRvVKdvkmswRAKJrp44zLMpCPyGrRqK0xyGLdok/jq MIdBZ3f71EGur5GVrAsyK1+P3rpzHUamwxbh6/BbjgvFQZgmPyrEsyIN3xHlQPgy1/Hv EC+3bFG4A7+P8/sSFvXtZTSnja9UJSKeOq5zhofuxmnAwMV/CWvaY7qaXf8SAabtmnYD nBbNJMhRx6q9sqWK/uEGvoFyp2TimBQHit1SO19jUmzODvbsc9JkX7FKM0MxJsBpIkkE imYA== X-Received: by 10.15.45.135 with SMTP id b7mr67450eew.135.1379600209908; Thu, 19 Sep 2013 07:16:49 -0700 (PDT) Original-Received: by 10.14.152.132 with HTTP; Thu, 19 Sep 2013 07:16:49 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78578 Archived-At: --089e0160bc9471ba8804e6bd3414 Content-Type: text/plain; charset=ISO-8859-1 For some files under RCS version control, `vc-annotate' now fails with error `(wrong-type-argument integer-or-marker-p nil)'. I think the problem is with the variable `b' whose dynamic binding was used by `gather' and set by `incg' (local functions in `vc-rcs-parse'), prior to r114131. Sorry, I haven't been able to craft an example RCS master file that reproduces the problem. The top of the stack trace looks like this. Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil) buffer-substring-no-properties(nil 6747) (let ((x (buffer-substring-no-properties (cadr pairs) (car pairs)))) (message "%d %d %s" (cadr pairs) (car pairs) x) (setq acc (cons x acc))) (while pairs (let ((x (buffer-substring-no-properties (cadr pairs) (car pairs)))) (message "%d %d %s" (cadr pairs) (car pairs) x) (setq acc (cons x acc))) (setq pairs (cddr pairs))) (let ((pairs (cons e (append @-holes (list b)))) acc) (while pairs (let ((x (buffer-substring-no-properties (cadr pairs) (car pairs)))) (message "%d %d %s" (cadr pairs) (car pairs) x) (setq acc (cons x acc))) (setq pairs (cddr pairs))) (apply (quote concat) acc)) In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-09-19 on 57172UHB Bzr revision: 114395 michael.albinus@gmx.de-20130919110801-tl6ne4cxp0bmx0kf Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix c:/emacs/emacs-114395 --enable-locallisppath=%emacs_dir%/../site-lisp 'CPPFLAGS=-I G:/usr/include -I C:/GnuWin32/include' 'LDFLAGS=-L G:/usr/lib -L C:/GnuWin32/lib'' Important settings: value of $LANG: ENG locale-coding-system: cp1252 default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x r - e - b Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32notify w32 multi-tty emacs) --089e0160bc9471ba8804e6bd3414 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
For some files under RCS version control, `vc-annotate'= ; now fails with
error `(wrong-type-argument integer-or-marker-p nil)= 9;.

I think the problem is with the variable `b' whose dynamic b= inding
was used by `gather' and set by `incg' (local functions in
`vc-= rcs-parse'), prior to r114131.

Sorry, I haven't been able to= craft an example RCS master file that
reproduces the problem. The top o= f the stack trace looks like this.

Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p = nil)
=A0 buffer-substring-no-properties(nil 6747)
=A0 (let ((x (buffe= r-substring-no-properties (cadr pairs) (car pairs)))) (message "%d %d = %s" (cadr pairs) (car pairs) x) (setq acc (cons x acc)))
=A0 (while pairs (let ((x (buffer-substring-no-properties (cadr pairs) (car= pairs)))) (message "%d %d %s" (cadr pairs) (car pairs) x) (setq = acc (cons x acc))) (setq pairs (cddr pairs)))
=A0 (let ((pairs (cons e (= append @-holes (list b)))) acc) (while pairs (let ((x (buffer-substring-no-= properties (cadr pairs) (car pairs)))) (message "%d %d %s" (cadr = pairs) (car pairs) x) (setq acc (cons x acc))) (setq pairs (cddr pairs))) (= apply (quote concat) acc))


In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
=A0of 2013-09-19 on 571= 72UHB
Bzr revision: 114395 michael.albinus@gmx.de-20130919110801-tl6ne4c= xp0bmx0kf
Windowing system distributor `Microsoft Corp.', version 6.= 1.7601
Configured using:
=A0`configure --prefix c:/emacs/emacs-114395
=A0--e= nable-locallisppath=3D%emacs_dir%/../site-lisp 'CPPFLAGS=3D-I
=A0G:/= usr/include -I C:/GnuWin32/include' 'LDFLAGS=3D-L G:/usr/lib -L
= =A0C:/GnuWin32/lib''

Important settings:
=A0 value of $LANG: ENG
=A0 locale-coding-sys= tem: cp1252
=A0 default enable-multibyte-characters: t

Major mode= : Lisp Interaction

Minor modes in effect:
=A0 tooltip-mode: t
= =A0 mouse-wheel-mode: t
=A0 tool-bar-mode: t
=A0 menu-bar-mode: t
=A0 file-name-shadow-mode: = t
=A0 global-font-lock-mode: t
=A0 font-lock-mode: t
=A0 blink-cur= sor-mode: t
=A0 auto-composition-mode: t
=A0 auto-encryption-mode: t<= br>=A0 auto-compression-mode: t
=A0 line-number-mode: t
=A0 transient-mark-mode: t

Recent input:<= br>M-x r - e - b <return>

Recent messages:
For information = about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:=
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug m= essage format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-en= code mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047= rfc2045 ietf-drums
mm-util mail-prsvr mail-utils time-date tooltip ediff-hook vc-hooks
lisp= -float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win
w32= -vars tool-bar dnd fontset image regexp-opt fringe tabulated-list
newcom= ment lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
fra= me cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet l= ao korean japanese hebrew greek romanian slovak czech european
ethiopic = indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexpfiles text-properties overlay sha1 md5 base64 format env code-pages mulecustom widget hashtable-print-readable backquote make-network-process
w32notify w32 multi-tty emacs)

--089e0160bc9471ba8804e6bd3414--