From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#22202: 24.5; SECURITY ISSUE -- Emacs Server vulnerable to random number generator attack on Windows systems Date: Thu, 31 Dec 2015 17:47:18 +0000 Message-ID: References: <83lh8ddy45.fsf@gnu.org> <8760zh81oo.fsf@isaac.fritz.box> <83mvssc4ix.fsf@gnu.org> <1451581478.15612.5.camel@gmail.com> <83bn96bkez.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1451700260 24772 80.91.229.3 (2 Jan 2016 02:04:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Jan 2016 02:04:20 +0000 (UTC) Cc: 22202@debbugs.gnu.org, Demetrios Obenour , David Engster To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 02 03:04:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aFBYA-0005hc-O9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jan 2016 03:04:10 +0100 Original-Received: from localhost ([::1]:37265 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFBY9-0000n0-TC for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Jan 2016 21:04:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFBY6-0000lY-2f for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2016 21:04:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aFBY2-0005nF-T7 for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2016 21:04:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFBY2-0005nA-Pj for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2016 21:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aFBY2-0001k4-Dh for bug-gnu-emacs@gnu.org; Fri, 01 Jan 2016 21:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jan 2016 02:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22202 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 22202-submit@debbugs.gnu.org id=B22202.14517002306665 (code B ref 22202); Sat, 02 Jan 2016 02:04:02 +0000 Original-Received: (at 22202) by debbugs.gnu.org; 2 Jan 2016 02:03:50 +0000 Original-Received: from localhost ([127.0.0.1]:34177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFBXq-0001jR-Cw for submit@debbugs.gnu.org; Fri, 01 Jan 2016 21:03:50 -0500 Original-Received: from mail-yk0-f178.google.com ([209.85.160.178]:33104) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aFBXo-0001jC-Sz for 22202@debbugs.gnu.org; Fri, 01 Jan 2016 21:03:49 -0500 Original-Received: by mail-yk0-f178.google.com with SMTP id k129so183323099yke.0 for <22202@debbugs.gnu.org>; Fri, 01 Jan 2016 18:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wNhev/k/HacLaiy1rrLseZ/Z78gBteiabJ+3QqSP810=; b=jewrBTDYCTF40yLNyqnZnT7G45bHlf4SSksKx0dJ1yfzqCILs6EybnJyQnFf29Nhg+ LVQCjYUufyqv7giO0lkivsK73mGn/n+eQcyx4EbHgtxlT4BZwPQ8NObCJ5vWCQGV6cEJ x+7Os9PSIoXfdKAwj9imgS6YUrcUW3GIesMdW+nHzUtP0rD2hTy5k4Kc52vAU1JL2Dur FB3kfvAOwLnNFcfONZX5AtGN7MufCCHPVPs5IAGvIVryKKjwqRQK4vXEKVX3X4x03D2c 6gZglTxRqNdhjj0eKwkr2mLB3qf81YLsdtefsuhNI1XXSlu2qtlwE5dzdgZ/hPxcIJlV l4lQ== X-Received: by 10.129.33.65 with SMTP id h62mr52227762ywh.139.1451584068223; Thu, 31 Dec 2015 09:47:48 -0800 (PST) Original-Received: by 10.37.207.214 with HTTP; Thu, 31 Dec 2015 09:47:18 -0800 (PST) In-Reply-To: <83bn96bkez.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111084 Archived-At: That last patch would still improve matters. The user would have to be publishing the output of their PRNG to begin with in order for the attacker to analyse it and guess the seed. (I don't know how one could do that but that's no proof that it's impossible.) What Demetri has just described is what I would do. (Sorry again that I can't assist with a patch.) + if (w32_crypto_hprov) + w32_init_crypt_random (); should be + if (! w32_crypto_hprov) + w32_init_crypt_random ();