* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list @ 2016-11-04 10:54 Richard Copley 2016-11-04 11:02 ` Eli Zaretskii 0 siblings, 1 reply; 14+ messages in thread From: Richard Copley @ 2016-11-04 10:54 UTC (permalink / raw) To: 24873 Recipe from emacs -Q: M-< ;; beginning-of-buffer C-M-s text ;; isearch-forward-regexp M-% xxx RET ! ;; isearch-query-replace C-M-% ;; query-replace-regexp M-p ;; previous-history-element Expected result: selects the previous replace operation "text -> xxx" from the history list. Actual result: signals "user-error: Beginning of history; no preceding item". The bug affects isearch-query replace when invoked during isearch-forward-regexp but not when invoked during isearch-forward. The bug was introduced in the master branch between these two revisions (not tight bounds, just builds I have lying around): GOOD: commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 Author: Paul Eggert <eggert@cs.ucla.edu> Date: Sat Sep 17 15:06:24 2016 -0700 BAD: commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 Author: Tino Calancha <tino.calancha@gmail.com> Date: Tue Oct 11 11:47:32 2016 +0900 In GNU Emacs 26.0.50.1 (x86_64-w64-mingw32) of 2016-10-11 built on 60678UHB Repository revision: 9640e9f4e95cd95c04875e90a4ff638e1e51f977 Windowing system distributor 'Microsoft Corp.', version 6.1.7601 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Mark set [2 times] Replaced 2 occurrences user-error: Beginning of history; no preceding item Quit Configured using: 'configure --prefix /C/emacs/emacs-20161011-024732 --with-modules --without-imagemagick --disable-dependency-tracking --enable-locallisppath=%emacs_dir%/../site-lisp CFLAGS=-O3 CPPFLAGS=-D_WIN32_WINNT=_WIN32_WINNT_WIN7' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES Important settings: value of $LANG: ENG locale-coding-system: cp1252 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils thingatpt misearch multi-isearch time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify dbusbind w32 multi-tty make-network-process emacs) Memory information: ((conses 16 99599 14680) (symbols 56 20290 0) (miscs 48 45 149) (strings 32 19347 4182) (string-bytes 1 591428) (vectors 16 13522) (vector-slots 8 442624 4747) (floats 8 181 146) (intervals 56 247 16) (buffers 976 11)) ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 10:54 bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list Richard Copley @ 2016-11-04 11:02 ` Eli Zaretskii 2016-11-04 11:16 ` Richard Copley 0 siblings, 1 reply; 14+ messages in thread From: Eli Zaretskii @ 2016-11-04 11:02 UTC (permalink / raw) To: Richard Copley; +Cc: 24873 > From: Richard Copley <rcopley@gmail.com> > Date: Fri, 4 Nov 2016 10:54:00 +0000 > > The bug was introduced in the master branch between these two revisions > (not tight bounds, just builds I have lying around): > > GOOD: > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 > Author: Paul Eggert <eggert@cs.ucla.edu> > Date: Sat Sep 17 15:06:24 2016 -0700 > > BAD: > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > Author: Tino Calancha <tino.calancha@gmail.com> > Date: Tue Oct 11 11:47:32 2016 +0900 Is this the result of turning on lexical-binding in iserach.el? ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 11:02 ` Eli Zaretskii @ 2016-11-04 11:16 ` Richard Copley 2016-11-04 19:03 ` Richard Copley 0 siblings, 1 reply; 14+ messages in thread From: Richard Copley @ 2016-11-04 11:16 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 24873 [-- Attachment #1: Type: text/plain, Size: 759 bytes --] Thanks, I'll check, but I can't do it now. In about 8 hours unless someone beats me to it. On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz@gnu.org> wrote: > > From: Richard Copley <rcopley@gmail.com> > > Date: Fri, 4 Nov 2016 10:54:00 +0000 > > > > The bug was introduced in the master branch between these two revisions > > (not tight bounds, just builds I have lying around): > > > > GOOD: > > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 > > Author: Paul Eggert <eggert@cs.ucla.edu> > > Date: Sat Sep 17 15:06:24 2016 -0700 > > > > BAD: > > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > > Author: Tino Calancha <tino.calancha@gmail.com> > > Date: Tue Oct 11 11:47:32 2016 +0900 > > Is this the result of turning on lexical-binding in iserach.el? > [-- Attachment #2: Type: text/html, Size: 1289 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 11:16 ` Richard Copley @ 2016-11-04 19:03 ` Richard Copley 2016-11-04 19:35 ` Mark Oteiza 0 siblings, 1 reply; 14+ messages in thread From: Richard Copley @ 2016-11-04 19:03 UTC (permalink / raw) To: Eli Zaretskii, Mark Oteiza; +Cc: 24873 On 4 November 2016 at 11:16, Richard Copley <rcopley@gmail.com> wrote: > On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz@gnu.org> wrote: >> >> > From: Richard Copley <rcopley@gmail.com> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 >> > >> > The bug was introduced in the master branch between these two revisions >> > (not tight bounds, just builds I have lying around): >> > >> > GOOD: >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 >> > Author: Paul Eggert <eggert@cs.ucla.edu> >> > Date: Sat Sep 17 15:06:24 2016 -0700 >> > >> > BAD: >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> > Author: Tino Calancha <tino.calancha@gmail.com> >> > Date: Tue Oct 11 11:47:32 2016 +0900 >> >> Is this the result of turning on lexical-binding in iserach.el? > > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone > beats me to it. Yep, you nailed it. ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 19:03 ` Richard Copley @ 2016-11-04 19:35 ` Mark Oteiza 2016-11-04 19:59 ` Stephen Berman 0 siblings, 1 reply; 14+ messages in thread From: Mark Oteiza @ 2016-11-04 19:35 UTC (permalink / raw) To: Richard Copley; +Cc: 24873-done On 04/11/16 at 07:03pm, Richard Copley wrote: > On 4 November 2016 at 11:16, Richard Copley <rcopley@gmail.com> wrote: > > On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz@gnu.org> wrote: > >> > >> > From: Richard Copley <rcopley@gmail.com> > >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 > >> > > >> > The bug was introduced in the master branch between these two revisions > >> > (not tight bounds, just builds I have lying around): > >> > > >> > GOOD: > >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 > >> > Author: Paul Eggert <eggert@cs.ucla.edu> > >> > Date: Sat Sep 17 15:06:24 2016 -0700 > >> > > >> > BAD: > >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > >> > Author: Tino Calancha <tino.calancha@gmail.com> > >> > Date: Tue Oct 11 11:47:32 2016 +0900 > >> > >> Is this the result of turning on lexical-binding in iserach.el? > > > > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone > > beats me to it. > > Yep, you nailed it. This was fixed already--your recipe works as expected for me. See bug#24580 ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 19:35 ` Mark Oteiza @ 2016-11-04 19:59 ` Stephen Berman 2016-11-04 20:53 ` Mark Oteiza 0 siblings, 1 reply; 14+ messages in thread From: Stephen Berman @ 2016-11-04 19:59 UTC (permalink / raw) To: 24873; +Cc: mvoteiza, rcopley On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza <mvoteiza@udel.edu> wrote: > On 04/11/16 at 07:03pm, Richard Copley wrote: >> On 4 November 2016 at 11:16, Richard Copley <rcopley@gmail.com> wrote: >> > On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz@gnu.org> wrote: >> >> >> >> > From: Richard Copley <rcopley@gmail.com> >> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 >> >> > >> >> > The bug was introduced in the master branch between these two revisions >> >> > (not tight bounds, just builds I have lying around): >> >> > >> >> > GOOD: >> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 >> >> > Author: Paul Eggert <eggert@cs.ucla.edu> >> >> > Date: Sat Sep 17 15:06:24 2016 -0700 >> >> > >> >> > BAD: >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> >> > Author: Tino Calancha <tino.calancha@gmail.com> >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 >> >> >> >> Is this the result of turning on lexical-binding in iserach.el? >> > >> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone >> > beats me to it. >> >> Yep, you nailed it. > > This was fixed already--your recipe works as expected for me. See bug#24580 My build contains the commit referenced in bug#24580 as fixing it, but I can still reproduce the problem with the OP's recipe (i.e. with -Q). Steve Berman ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 19:59 ` Stephen Berman @ 2016-11-04 20:53 ` Mark Oteiza 2016-11-04 21:16 ` Richard Copley 0 siblings, 1 reply; 14+ messages in thread From: Mark Oteiza @ 2016-11-04 20:53 UTC (permalink / raw) To: Stephen Berman; +Cc: rcopley, 24873 On 04/11/16 at 08:59pm, Stephen Berman wrote: > On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza <mvoteiza@udel.edu> wrote: > > > On 04/11/16 at 07:03pm, Richard Copley wrote: > >> On 4 November 2016 at 11:16, Richard Copley <rcopley@gmail.com> wrote: > >> > On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz@gnu.org> wrote: > >> >> > >> >> > From: Richard Copley <rcopley@gmail.com> > >> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 > >> >> > > >> >> > The bug was introduced in the master branch between these two revisions > >> >> > (not tight bounds, just builds I have lying around): > >> >> > > >> >> > GOOD: > >> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 > >> >> > Author: Paul Eggert <eggert@cs.ucla.edu> > >> >> > Date: Sat Sep 17 15:06:24 2016 -0700 > >> >> > > >> >> > BAD: > >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > >> >> > Author: Tino Calancha <tino.calancha@gmail.com> > >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 > >> >> > >> >> Is this the result of turning on lexical-binding in iserach.el? > >> > > >> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone > >> > beats me to it. > >> > >> Yep, you nailed it. > > > > This was fixed already--your recipe works as expected for me. See bug#24580 > > My build contains the commit referenced in bug#24580 as fixing it, but I > can still reproduce the problem with the OP's recipe (i.e. with -Q). Sorry if I jumped the gun closing. I'm on 2955936 (master HEAD at the moment) and can't reproduce. ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 20:53 ` Mark Oteiza @ 2016-11-04 21:16 ` Richard Copley 2016-11-04 22:03 ` Stephen Berman 2016-11-04 23:35 ` Mark Oteiza 0 siblings, 2 replies; 14+ messages in thread From: Richard Copley @ 2016-11-04 21:16 UTC (permalink / raw) To: Mark Oteiza; +Cc: Stephen Berman, 24873 On 4 November 2016 at 20:53, Mark Oteiza <mvoteiza@udel.edu> wrote: > On 04/11/16 at 08:59pm, Stephen Berman wrote: >> On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza <mvoteiza@udel.edu> wrote: >> >> > On 04/11/16 at 07:03pm, Richard Copley wrote: >> >> On 4 November 2016 at 11:16, Richard Copley <rcopley@gmail.com> wrote: >> >> > On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz@gnu.org> wrote: >> >> >> >> >> >> > From: Richard Copley <rcopley@gmail.com> >> >> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 >> >> >> > >> >> >> > The bug was introduced in the master branch between these two revisions >> >> >> > (not tight bounds, just builds I have lying around): >> >> >> > >> >> >> > GOOD: >> >> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 >> >> >> > Author: Paul Eggert <eggert@cs.ucla.edu> >> >> >> > Date: Sat Sep 17 15:06:24 2016 -0700 >> >> >> > >> >> >> > BAD: >> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> >> >> > Author: Tino Calancha <tino.calancha@gmail.com> >> >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 >> >> >> >> >> >> Is this the result of turning on lexical-binding in iserach.el? >> >> > >> >> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone >> >> > beats me to it. >> >> >> >> Yep, you nailed it. >> > >> > This was fixed already--your recipe works as expected for me. See bug#24580 >> >> My build contains the commit referenced in bug#24580 as fixing it, but I >> can still reproduce the problem with the OP's recipe (i.e. with -Q). > > Sorry if I jumped the gun closing. > > I'm on 2955936 (master HEAD at the moment) and can't reproduce. I can reproduce the issue with the given recipe in that revision. To summarize, here are the test results stated so far in this thread, plus a few more that I'm stating now, in chronological order: Good [RC] (before lexical binding in isearch.el): commit 329e0274ec6a4ae82f86905b8cf844971b943085 Author: Mark Oteiza <mvoteiza@udel.edu> Date: Tue Sep 27 13:34:29 2016 -0400 Bad [RC] (turn on lexical binding in isearch.el) commit cbb2e845187bfbcc62e2accc9df7891a2326608a Author: Mark Oteiza <mvoteiza@udel.edu> Date: Wed Sep 28 13:08:12 2016 -0400 Good?? [MO] (this is the revision mentioned in #24580) commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14 Author: Mark Oteiza <mvoteiza@udel.edu> Date: Tue Oct 4 10:17:53 2016 -0400 Bad [SB] (unspecified, but containing the above). >> >> >> > BAD [RC]: >> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> >> >> > Author: Tino Calancha <tino.calancha@gmail.com> >> >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 Good [MO], Bad [RC]: commit 29559361f56c9398dcb69db7396dcfc0887843a2 Author: Mark Oteiza <mvoteiza@udel.edu> Date: Fri Nov 4 14:22:05 2016 -0400 Mark, it seems rude to ask, sorry, but are you sure you weren't testing a slightly different recipe? Otherwise it must be some difference in our environment which seems less likely. ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 21:16 ` Richard Copley @ 2016-11-04 22:03 ` Stephen Berman 2016-11-04 23:35 ` Mark Oteiza 1 sibling, 0 replies; 14+ messages in thread From: Stephen Berman @ 2016-11-04 22:03 UTC (permalink / raw) To: Richard Copley; +Cc: Mark Oteiza, 24873 On Fri, 4 Nov 2016 21:16:57 +0000 Richard Copley <rcopley@gmail.com> wrote: > On 4 November 2016 at 20:53, Mark Oteiza <mvoteiza@udel.edu> wrote: >> >> I'm on 2955936 (master HEAD at the moment) and can't reproduce. > > I can reproduce the issue with the given recipe in that revision. > > To summarize, here are the test results stated so far in this thread, > plus a few more that I'm stating now, in chronological order: > > Good [RC] (before lexical binding in isearch.el): > commit 329e0274ec6a4ae82f86905b8cf844971b943085 > Author: Mark Oteiza <mvoteiza@udel.edu> > Date: Tue Sep 27 13:34:29 2016 -0400 > > Bad [RC] (turn on lexical binding in isearch.el) > commit cbb2e845187bfbcc62e2accc9df7891a2326608a > Author: Mark Oteiza <mvoteiza@udel.edu> > Date: Wed Sep 28 13:08:12 2016 -0400 > > Good?? [MO] (this is the revision mentioned in #24580) > commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14 > Author: Mark Oteiza <mvoteiza@udel.edu> > Date: Tue Oct 4 10:17:53 2016 -0400 > > Bad [SB] (unspecified, but containing the above). For the recond, my current [BAD] build is from: commit 51558effdc453d359b4a174bf72db787dc0114d1 Author: Noah Friedman <friedman@splode.com> Date: Thu Oct 6 18:32:59 2016 -0700 Steve Berman ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 21:16 ` Richard Copley 2016-11-04 22:03 ` Stephen Berman @ 2016-11-04 23:35 ` Mark Oteiza 2016-11-05 0:34 ` Mark Oteiza 1 sibling, 1 reply; 14+ messages in thread From: Mark Oteiza @ 2016-11-04 23:35 UTC (permalink / raw) To: Richard Copley; +Cc: Stephen Berman, 24873 On 04/11/16 at 09:16pm, Richard Copley wrote: > On 4 November 2016 at 20:53, Mark Oteiza <mvoteiza@udel.edu> wrote: > > Sorry if I jumped the gun closing. > > > > I'm on 2955936 (master HEAD at the moment) and can't reproduce. > > I can reproduce the issue with the given recipe in that revision. > > To summarize, here are the test results stated so far in this thread, > plus a few more that I'm stating now, in chronological order: > > Good [RC] (before lexical binding in isearch.el): > commit 329e0274ec6a4ae82f86905b8cf844971b943085 > Author: Mark Oteiza <mvoteiza@udel.edu> > Date: Tue Sep 27 13:34:29 2016 -0400 > > Bad [RC] (turn on lexical binding in isearch.el) > commit cbb2e845187bfbcc62e2accc9df7891a2326608a > Author: Mark Oteiza <mvoteiza@udel.edu> > Date: Wed Sep 28 13:08:12 2016 -0400 > > Good?? [MO] (this is the revision mentioned in #24580) > commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14 > Author: Mark Oteiza <mvoteiza@udel.edu> > Date: Tue Oct 4 10:17:53 2016 -0400 > > Bad [SB] (unspecified, but containing the above). > > >> >> >> > BAD [RC]: > >> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > >> >> >> > Author: Tino Calancha <tino.calancha@gmail.com> > >> >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 > > Good [MO], Bad [RC]: > commit 29559361f56c9398dcb69db7396dcfc0887843a2 > Author: Mark Oteiza <mvoteiza@udel.edu> > Date: Fri Nov 4 14:22:05 2016 -0400 > > Mark, it seems rude to ask, sorry, but are you sure you weren't testing > a slightly different recipe? Otherwise it must be some difference in our > environment which seems less likely. No worries, I think I erred here (M-% instead of C-M-% I think is what I was doing). Sorry for the confusion! :( ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-04 23:35 ` Mark Oteiza @ 2016-11-05 0:34 ` Mark Oteiza 2016-11-05 0:58 ` Noam Postavsky 2016-11-05 12:18 ` Richard Copley 0 siblings, 2 replies; 14+ messages in thread From: Mark Oteiza @ 2016-11-05 0:34 UTC (permalink / raw) To: Richard Copley; +Cc: Stephen Berman, 24873 Does the following fix it for you? diff --git a/lisp/replace.el b/lisp/replace.el index 4fc48d4..60948ef 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -198,7 +198,7 @@ query-replace-read-from (setq-local text-property-default-nonsticky (cons '(separator . t) text-property-default-nonsticky))) (if regexp-flag - (read-regexp prompt) + (read-regexp prompt nil 'minibuffer-history) (read-from-minibuffer prompt nil nil nil nil (car (if regexp-flag regexp-search-ring search-ring)) t))))) ^ permalink raw reply related [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-05 0:34 ` Mark Oteiza @ 2016-11-05 0:58 ` Noam Postavsky 2016-11-13 2:42 ` npostavs 2016-11-05 12:18 ` Richard Copley 1 sibling, 1 reply; 14+ messages in thread From: Noam Postavsky @ 2016-11-05 0:58 UTC (permalink / raw) To: Mark Oteiza; +Cc: Richard Copley, Stephen Berman, 24873 On Fri, Nov 4, 2016 at 8:34 PM, Mark Oteiza <mvoteiza@udel.edu> wrote: > Does the following fix it for you? > > diff --git a/lisp/replace.el b/lisp/replace.el > index 4fc48d4..60948ef 100644 > --- a/lisp/replace.el > +++ b/lisp/replace.el > @@ -198,7 +198,7 @@ query-replace-read-from > (setq-local text-property-default-nonsticky > (cons '(separator . t) text-property-default-nonsticky))) > (if regexp-flag > - (read-regexp prompt) > + (read-regexp prompt nil 'minibuffer-history) I think you need make minibuffer-history into a dynamic variable for this to work. ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-05 0:58 ` Noam Postavsky @ 2016-11-13 2:42 ` npostavs 0 siblings, 0 replies; 14+ messages in thread From: npostavs @ 2016-11-13 2:42 UTC (permalink / raw) To: Mark Oteiza; +Cc: Richard Copley, 24873, Stephen Berman tags 24873 fixed close 24873 quit Noam Postavsky <npostavs@users.sourceforge.net> writes: > On Fri, Nov 4, 2016 at 8:34 PM, Mark Oteiza <mvoteiza@udel.edu> wrote: >> Does the following fix it for you? >> >> diff --git a/lisp/replace.el b/lisp/replace.el >> index 4fc48d4..60948ef 100644 >> --- a/lisp/replace.el >> +++ b/lisp/replace.el >> @@ -198,7 +198,7 @@ query-replace-read-from >> (setq-local text-property-default-nonsticky >> (cons '(separator . t) text-property-default-nonsticky))) >> (if regexp-flag >> - (read-regexp prompt) >> + (read-regexp prompt nil 'minibuffer-history) > > I think you need make minibuffer-history into a dynamic variable for > this to work. Ah, minibuffer-history is defined in simple.el, so it's fine. ^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list 2016-11-05 0:34 ` Mark Oteiza 2016-11-05 0:58 ` Noam Postavsky @ 2016-11-05 12:18 ` Richard Copley 1 sibling, 0 replies; 14+ messages in thread From: Richard Copley @ 2016-11-05 12:18 UTC (permalink / raw) To: Mark Oteiza; +Cc: Stephen Berman, 24873 On 5 November 2016 at 00:34, Mark Oteiza <mvoteiza@udel.edu> wrote: > Does the following fix it for you? > > diff --git a/lisp/replace.el b/lisp/replace.el > index 4fc48d4..60948ef 100644 > --- a/lisp/replace.el > +++ b/lisp/replace.el > @@ -198,7 +198,7 @@ query-replace-read-from > (setq-local text-property-default-nonsticky > (cons '(separator . t) text-property-default-nonsticky))) > (if regexp-flag > - (read-regexp prompt) > + (read-regexp prompt nil 'minibuffer-history) > (read-from-minibuffer > prompt nil nil nil nil > (car (if regexp-flag regexp-search-ring search-ring)) t))))) Yes. ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-11-13 2:42 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-04 10:54 bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list Richard Copley 2016-11-04 11:02 ` Eli Zaretskii 2016-11-04 11:16 ` Richard Copley 2016-11-04 19:03 ` Richard Copley 2016-11-04 19:35 ` Mark Oteiza 2016-11-04 19:59 ` Stephen Berman 2016-11-04 20:53 ` Mark Oteiza 2016-11-04 21:16 ` Richard Copley 2016-11-04 22:03 ` Stephen Berman 2016-11-04 23:35 ` Mark Oteiza 2016-11-05 0:34 ` Mark Oteiza 2016-11-05 0:58 ` Noam Postavsky 2016-11-13 2:42 ` npostavs 2016-11-05 12:18 ` Richard Copley
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).