From: Richard Copley <rcopley@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 35739@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>
Subject: bug#35739: Bad signature from GNU ELPA
Date: Wed, 15 May 2019 07:46:12 +0100 [thread overview]
Message-ID: <CAPM58oh+mU9N55k-eF+fihrmmKT0Wb-eTBJSx9j3y8Soqvga5A@mail.gmail.com> (raw)
In-Reply-To: <837easa178.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]
On Wed, 15 May 2019 at 03:42, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Richard Copley <rcopley@gmail.com>
> > Date: Tue, 14 May 2019 23:26:27 +0100
> > Cc: 35739@debbugs.gnu.org
> >
> > Thanks, that seems to be it: the attached patch gets rid of the bug (but
> obviously isn't TRT).
> >
> > diff --git a/lisp/url/url-handlers.el b/lisp/url/url-handlers.el
> > index e35d999e0f..f8af2ce88c 100644
> > --- a/lisp/url/url-handlers.el
> > +++ b/lisp/url/url-handlers.el
> > @@ -334,11 +334,11 @@ url-insert-buffer-contents
> > (when replace
> > (delete-region (point-min) start)
> > (delete-region (point) (point-max)))
> > - (unless (cadr size-and-charset)
> > - ;; If the headers don't specify any particular charset, use the
> > - ;; usual heuristic/rules that we apply to files.
> > - (decode-coding-inserted-region (point-min) (point) url
> > - visit beg end replace))
> > + ;; (unless (cadr size-and-charset)
> > + ;; ;; If the headers don't specify any particular charset, use
> the
> > + ;; ;; usual heuristic/rules that we apply to files.
> > + ;; (decode-coding-inserted-region (point-min) (point) url
> > + ;; visit beg end replace))
> > (let ((inserted (car size-and-charset)))
> > (when (fboundp 'after-insert-file-set-coding)
> > (let ((insval (after-insert-file-set-coding inserted visit)))
>
> I don't see how disabling decoding could make sense, can you explain?
>
Not in detail, it's not an area of expertise of mine. We call
(decode-coding-region (point-min) (point-max) 'undecided) on the
payload of "https://elpa.gnu.org/packages/archive-contents",
which is raw text. The resulting buffer's buffer-file-coding-
system is iso-latin-1-dos.
>
> What does this code do on GNU/Linux?
>
The same. The resulting coding system is iso-latin-1-unix.
[-- Attachment #2: Type: text/html, Size: 2973 bytes --]
next prev parent reply other threads:[~2019-05-15 6:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 21:25 bug#35739: Bad signature from GNU ELPA Richard Copley
2019-05-14 21:37 ` bug#35739: Acknowledgement (Bad signature from GNU ELPA) Richard Copley
2019-05-14 22:04 ` bug#35739: Bad signature from GNU ELPA Noam Postavsky
2019-05-14 22:26 ` Richard Copley
2019-05-14 22:42 ` Richard Copley
2019-05-15 2:42 ` Eli Zaretskii
2019-05-15 7:13 ` Richard Copley
2019-05-15 14:03 ` Stefan Monnier
2019-05-15 15:03 ` Eli Zaretskii
2019-05-18 22:36 ` Stefan Monnier
2019-05-22 5:19 ` Eli Zaretskii
2019-05-22 16:20 ` Stefan Monnier
2019-05-22 17:09 ` Eli Zaretskii
2019-05-22 19:40 ` Stefan Monnier
2019-05-23 3:50 ` Eli Zaretskii
2019-05-23 4:06 ` Stefan Monnier
2019-05-23 4:52 ` Eli Zaretskii
2019-05-23 12:10 ` Stefan Monnier
2019-05-23 14:15 ` Eli Zaretskii
2019-05-24 14:22 ` Stefan Monnier
2019-05-24 15:00 ` Eli Zaretskii
2019-05-24 19:31 ` Stefan Monnier
2019-05-24 19:43 ` Eli Zaretskii
2019-05-24 19:51 ` Stefan Monnier
2019-05-25 7:36 ` Eli Zaretskii
2019-05-25 18:38 ` Stefan Monnier
2019-05-25 19:13 ` Eli Zaretskii
2019-05-15 2:41 ` Eli Zaretskii
2019-05-15 6:46 ` Richard Copley [this message]
2019-05-15 14:40 ` Eli Zaretskii
2019-05-15 15:12 ` Richard Copley
2019-05-29 18:45 ` Stefan Monnier
2019-05-29 19:11 ` Richard Copley
2019-05-29 20:07 ` Stefan Monnier
2019-05-29 20:50 ` Noam Postavsky
2019-05-30 2:35 ` Eli Zaretskii
2019-05-31 4:54 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPM58oh+mU9N55k-eF+fihrmmKT0Wb-eTBJSx9j3y8Soqvga5A@mail.gmail.com \
--to=rcopley@gmail.com \
--cc=35739@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).