unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Copley <rcopley@gmail.com>
To: Roland Winkler <winkler@gnu.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 37957@debbugs.gnu.org
Subject: bug#37957: BibTeX dialect not set if local variables disabled
Date: Wed, 30 Oct 2019 16:32:30 +0000	[thread overview]
Message-ID: <CAPM58ognRDo0HZH8OPjKdW0Y3+hPYGprpuF84BAUMoNp5kqDHg@mail.gmail.com> (raw)
In-Reply-To: <39771.36515.154463.23991@gargle.gargle.HOWL>

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

On Tue, 29 Oct 2019 at 01:52, Roland Winkler <winkler@gnu.org> wrote:
> On Mon Oct 28 2019 Lars Ingebrigtsen wrote:
> > Do you have an example .bib file that can be used to reproduce this bug?
>
> I can, indeed, reproduce this with `emacs -Q', setting
> enable-local-variables to nil and then loading any BibTeX file.
>
> Yet it is not clear to me what is the proper solution for this.
>
> Currently, bibtex-mode makes bibtex-set-dialect an element of
> hack-local-variables-hook.  This hook is called only if
> enable-local-variables is non-nil.  Of course, bibtex-mode could
> call bibtex-set-dialect directly if enable-local-variables is nil.
> Yet I guess that enable-local-variables being nil may break more
> things if hack-local-variables-hook is not called.

Did you have something in mind? I don't see how it might break anything for
BibTeX mode. If it breaks something elsewhere, that is a separate bug.

> If nothing else, we could mention in the docstring of
> hack-local-variables-hook that this hook is not called if
> enable-local-variables is nil.

Perhaps, but it is clear from the existing docstring ("[...] run after
processing a file’s local variables specs"), in my opinion.

[-- Attachment #2: Type: text/html, Size: 1429 bytes --]

  reply	other threads:[~2019-10-30 16:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28  9:44 bug#37957: BibTeX dialect not set if local variables disabled Richard Copley
2019-10-28 15:16 ` Lars Ingebrigtsen
     [not found]   ` <CAPM58og0EX6F9vpVfq4fnVK-QWevXYUccf5_W_QbTLZ=iGxDuQ@mail.gmail.com>
2019-10-28 16:21     ` Lars Ingebrigtsen
2019-10-28 16:33       ` Richard Copley
2019-10-28 16:42         ` Lars Ingebrigtsen
2019-10-28 17:55           ` Richard Copley
2019-10-29 11:24             ` Lars Ingebrigtsen
2019-10-28 18:54           ` Eli Zaretskii
2019-10-29  1:52   ` Roland Winkler
2019-10-30 16:32     ` Richard Copley [this message]
2019-10-30 18:21       ` Roland Winkler
2020-12-02 19:54         ` Roland Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPM58ognRDo0HZH8OPjKdW0Y3+hPYGprpuF84BAUMoNp5kqDHg@mail.gmail.com \
    --to=rcopley@gmail.com \
    --cc=37957@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).