unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Copley <rcopley@gmail.com>
To: David Engster <deng@randomsample.de>
Cc: 22202@debbugs.gnu.org, Demetri Obenour <demetriobenour@gmail.com>
Subject: bug#22202: 24.5; SECURITY ISSUE -- Emacs Server vulnerable to random number generator attack on Windows systems
Date: Tue, 29 Dec 2015 21:22:55 +0000	[thread overview]
Message-ID: <CAPM58ogeYY3aggKi=7tPDfxoFdmh58fN_tAcPDjHsQW0WdY9ow@mail.gmail.com> (raw)
In-Reply-To: <8760zh81oo.fsf@isaac.fritz.box>

>> [...]
>
> That's correct (it requires a Windows Server with enabled terminal
> services), but each user session has of course its own process space, so
> I don't see how the described attack could work there.

Not sure what you mean by process space. As an unprivileged user
you can find other users' Emacs processes without any effort (using
tasklist.exe, for example). If you know on what port an Emacs server
is listening (which is admittedly a difficulty), you can send bytes to it.
I've just done so as an experiment. (I was driving both sessions so I
knew the server port.)

I haven't reproduced the whole attack scenario and I don't pretend
know whether it could work. I don't claim any expertise in software
security. I just wanted to help out by answering Eli's questions.

To get back to the OP's main point, given that we already go to the
trouble of creating this secret, it wouldn't hurt to do it better (on all
systems, for preference). On Windows it really doesn't seem hard.
Sorry, no patch, for legal reasons, but there's a simple example on
the MSDN page for CryptGenRandom.





  reply	other threads:[~2015-12-29 21:22 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 10:05 bug#22202: 24.5; SECURITY ISSUE -- Emacs Server vulnerable to random number generator attack on Windows systems Demetri Obenour
2015-12-18 10:46 ` Eli Zaretskii
2015-12-29 15:36 ` Richard Copley
2015-12-29 16:21   ` Eli Zaretskii
2015-12-29 17:44     ` Richard Copley
2015-12-29 20:00       ` David Engster
2015-12-29 21:22         ` Richard Copley [this message]
2015-12-29 22:02           ` David Engster
2015-12-29 23:13             ` Richard Copley
2015-12-30 15:58           ` Eli Zaretskii
2015-12-30 20:47             ` Richard Copley
2015-12-30 20:56               ` Richard Copley
2015-12-30 20:56               ` Eli Zaretskii
2015-12-30 21:15                 ` Richard Copley
2015-12-31 14:14                   ` Eli Zaretskii
2015-12-31 17:04               ` Demetrios Obenour
2015-12-31 17:24                 ` Eli Zaretskii
2015-12-31 17:47                   ` Richard Copley
2015-12-31 18:22                     ` Eli Zaretskii
2015-12-31 19:20                 ` Eli Zaretskii
2015-12-31 19:49                   ` Richard Copley
2015-12-31 20:13                     ` Eli Zaretskii
2015-12-31 20:44                       ` Richard Copley
2016-01-15  9:55                     ` Eli Zaretskii
2016-01-17 20:26 ` Paul Eggert
2016-01-18  1:42   ` Paul Eggert
2016-01-18 14:40     ` Richard Copley
2016-01-18 16:05       ` Eli Zaretskii
2016-01-18 16:20         ` Richard Copley
2016-01-18 15:45   ` Eli Zaretskii
2016-01-18 20:50     ` Paul Eggert
2016-01-18 21:09       ` Eli Zaretskii
2016-01-19  5:34         ` Paul Eggert
2016-01-19 16:24           ` Eli Zaretskii
2016-01-19 17:03             ` John Wiegley
2016-01-19 17:38               ` Paul Eggert
2016-01-19 18:44                 ` Eli Zaretskii
2016-01-19 17:07             ` Paul Eggert
2016-01-19 18:16               ` Eli Zaretskii
2016-01-20  0:39                 ` Paul Eggert
2016-01-18 12:04 ` Andy Moreton
2016-01-18 15:57   ` Eli Zaretskii
2016-01-18 23:03   ` John Wiegley
2016-01-19 21:48 ` Andy Moreton
2016-01-20  3:31   ` Glenn Morris
2016-01-20 14:06 ` Andy Moreton
2016-01-20 14:12   ` Eli Zaretskii
2016-01-20 15:15 ` Andy Moreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPM58ogeYY3aggKi=7tPDfxoFdmh58fN_tAcPDjHsQW0WdY9ow@mail.gmail.com' \
    --to=rcopley@gmail.com \
    --cc=22202@debbugs.gnu.org \
    --cc=demetriobenour@gmail.com \
    --cc=deng@randomsample.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).