From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#13730: 24.3.50; Diff from Bzr-Log-View not highlighted Date: Sun, 17 Feb 2013 03:38:24 +0000 Message-ID: References: <511f773d.8665b40a.2af7.ffffa5d8@mx.google.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1361072358 14125 80.91.229.3 (17 Feb 2013 03:39:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Feb 2013 03:39:18 +0000 (UTC) To: 13730@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 17 04:39:40 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U6v6H-0005Db-J0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Feb 2013 04:39:37 +0100 Original-Received: from localhost ([::1]:34319 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6v5x-0005cs-Lc for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Feb 2013 22:39:17 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6v5t-0005ck-Tk for bug-gnu-emacs@gnu.org; Sat, 16 Feb 2013 22:39:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U6v5s-0006tx-4R for bug-gnu-emacs@gnu.org; Sat, 16 Feb 2013 22:39:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U6v5s-0006tt-1C for bug-gnu-emacs@gnu.org; Sat, 16 Feb 2013 22:39:12 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U6v6g-00080v-UY for bug-gnu-emacs@gnu.org; Sat, 16 Feb 2013 22:40:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Feb 2013 03:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13730 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo unreproducible Original-Received: via spool by 13730-submit@debbugs.gnu.org id=B13730.136107236030752 (code B ref 13730); Sun, 17 Feb 2013 03:40:02 +0000 Original-Received: (at 13730) by debbugs.gnu.org; 17 Feb 2013 03:39:20 +0000 Original-Received: from localhost ([127.0.0.1]:59857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6v5z-0007zx-HT for submit@debbugs.gnu.org; Sat, 16 Feb 2013 22:39:20 -0500 Original-Received: from mail-ee0-f50.google.com ([74.125.83.50]:48434) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U6v5x-0007zp-O7 for 13730@debbugs.gnu.org; Sat, 16 Feb 2013 22:39:18 -0500 Original-Received: by mail-ee0-f50.google.com with SMTP id e51so2342214eek.9 for <13730@debbugs.gnu.org>; Sat, 16 Feb 2013 19:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=lr7GCt9pyKBHXYqVWmXhPfR34WC/RwJRmDpchwgjmKE=; b=l188+02rJJ4V3FG58xv9ET1bglHLGOk0L+7EeIsI7ORMdkOpJkTMzmqXYO5mRCr1Js Mqx0p8430IzioQAm9e4kBafEbxFtZhAlcvpX/zEniJsIjnonPki4+p/LSWpT5lX2xVg9 R+47/EllksW5Z1FEzbcTkggrB2yDqyW9hqL2LQcIA158PbzfIdWS5wz3/CdtYVLta6QD TfNAn6ze+domjweI7dz3eJUBSy/8uX9sgYAKmN6Jr/BHi+dtN0OLAJ9Rck3MBjoPOaRR RPyBxPFIUDqXtKvbvZiWzKtglf+VsUHdGUFKku7FpeaVL9Kt6S2Pd/ibmJI5q64bwNYp RL+g== X-Received: by 10.14.179.194 with SMTP id h42mr27298132eem.46.1361072304937; Sat, 16 Feb 2013 19:38:24 -0800 (PST) Original-Received: by 10.14.96.11 with HTTP; Sat, 16 Feb 2013 19:38:24 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71420 Archived-At: On 17 February 2013 01:16, Glenn Morris wrote: > >> Visit a bzr branch, view the root log with "C-x v L", choose a revision >> and invoke log-view-diff by typing "d". The diff that is shown should be >> highlighted, but it isn't. > > Do you mean that font-locking should be enabled in the *vc-diff* buffer? > If so, it is for me. (Try bootstrapping?) That is what I mean, yes. Curious. Did you follow the recipe from "emacs -Q"? Not all *vc-diff* buffers are affected. >> The trunk revision in which this stopped working is in (111784,11794]. Make that (111793,111794]. Revision 111794 introduces a new feature in "easy-mmode.el" that allows major mode functions to disable global minor modes by explicitly turning off the corresponding minor mode. Unfortunately font-lock gets turned off in a change-major-mode-hook function (font-lock-change-mode in "font-core.el"), which doesn't seem to have been anticipated. I can't say I understand why this doesn't cause global-font-lock-mode to be disabled in all major modes in all circumstances. It could be a question of whether font-lock-change-mode or global-font-lock-mode-enable-in-buffers is earlier in change-major-mode-hook.