From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso Newsgroups: gmane.emacs.bugs Subject: bug#10626: Should configure fail if pkg-config fails? Date: Wed, 21 Mar 2012 15:54:44 -0400 Message-ID: References: <4F1F3019.8060808@cs.ucla.edu> <4F1F356F.9040501@cs.ucla.edu> <4F23BAE6.5080906@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1332359772 23432 80.91.229.3 (21 Mar 2012 19:56:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 21 Mar 2012 19:56:12 +0000 (UTC) Cc: 10626@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 21 20:56:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SARdg-00077G-Qn for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Mar 2012 20:56:09 +0100 Original-Received: from localhost ([::1]:36135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SARdg-0007KF-9L for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Mar 2012 15:56:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SARcw-000750-2r for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 15:55:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SARcu-0005tG-8W for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 15:55:21 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SARcu-0005tA-2i for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 15:55:20 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SAS6c-0001gE-IO for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 16:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Mar 2012 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10626 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13323615426427 (code B ref -1); Wed, 21 Mar 2012 20:26:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Mar 2012 20:25:42 +0000 Original-Received: from localhost ([127.0.0.1]:60137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAS6H-0001fb-9r for submit@debbugs.gnu.org; Wed, 21 Mar 2012 16:25:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33121) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SAS6D-0001fR-CA for submit@debbugs.gnu.org; Wed, 21 Mar 2012 16:25:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SARcS-0005kb-Ci for submit@debbugs.gnu.org; Wed, 21 Mar 2012 15:54:53 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:59858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SARcS-0005kS-65 for submit@debbugs.gnu.org; Wed, 21 Mar 2012 15:54:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SARcQ-0006wt-5M for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 15:54:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SARcN-0005k1-SZ for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 15:54:49 -0400 Original-Received: from mail-iy0-f169.google.com ([209.85.210.169]:45948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SARcN-0005jp-LH for bug-gnu-emacs@gnu.org; Wed, 21 Mar 2012 15:54:47 -0400 Original-Received: by iajr24 with SMTP id r24so2460006iaj.0 for ; Wed, 21 Mar 2012 12:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/ETZzFa/uloWI5MUBLOT0rv/3BOKRut9fypu6Uvc3Ns=; b=H2jK+xAecdPR7ySbZoqVk9S+ve+UhBFu+0KAhA6oiBxkK3i7ulekfQOTHVhWV3t23h T2pYZTsKO3DBsIBMcAFrGTXyxfJ5XJRmZmeUN0ekoPUjZTNS7TaSW7SPC3RUhOujxHlE XIg/r2s/ShMn9sRqqU7f37E412euQ6659rqjtJOSG+KIb/L06k+FTjE3hb9j+UusqVpE hFI1Fb+F0BQ4YH/Ms3iZyK6IF2v4X8kB43hdOrDmATztO88Y2AibY6mm9s2hrKyYgEZv Q0fDOv+Bxa/jyWjMS46jgwu3NSTy+45PdUKXe+m017zLvf6p3E/43kq5bu25hQA8P1RP RG9A== Original-Received: by 10.50.160.196 with SMTP id xm4mr3792635igb.24.1332359684240; Wed, 21 Mar 2012 12:54:44 -0700 (PDT) Original-Received: by 10.231.104.65 with HTTP; Wed, 21 Mar 2012 12:54:44 -0700 (PDT) In-Reply-To: <4F23BAE6.5080906@cs.ucla.edu> X-Google-Sender-Auth: nrWGJNGMEqOjSD__RMa9FpkTzmE X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Wed, 21 Mar 2012 15:56:06 -0400 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57941 Archived-At: Hi, sorry for the late reply. 2012/1/28 Paul Eggert : > On 01/24/2012 06:15 PM, Jordi Guti=C3=A9rrez Hermoso wrote: >> it shouldn't assume that GTK+ is working correctly if >> pkg-config returns nonzero exit status. > > True enough. =C2=A0Here's a proposed patch, which I'd like to > install into the trunk. =C2=A0I'm CC'ing this to bug-gnu-emacs > instead of to emacs-devel, so that it has a proper bug number. > > > =3D=3D=3D modified file 'ChangeLog' > --- ChangeLog =C2=A0 2012-01-19 07:21:25 +0000 > +++ ChangeLog =C2=A0 2012-01-28 09:04:13 +0000 > @@ -1,3 +1,11 @@ > +2012-01-28 =C2=A0Paul Eggert =C2=A0 > + > + =C2=A0 =C2=A0 =C2=A0 Check pkg-config exit status when configuring. > + =C2=A0 =C2=A0 =C2=A0 * configure.in (PKG_CHECK_MODULES): Do not assume = that pkg-config > + =C2=A0 =C2=A0 =C2=A0 works; check its exit status. =C2=A0Problem report= ed by Jordi Guti=C3=A9rrez > + =C2=A0 =C2=A0 =C2=A0 Hermoso in > + =C2=A0 =C2=A0 =C2=A0 . > + > =C2=A02012-01-16 =C2=A0Juanma Barranquero =C2=A0 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* .bzrignore: Ignore etc/__pycache__. > > =3D=3D=3D modified file 'configure.in' > --- configure.in =C2=A0 =C2=A0 =C2=A0 =C2=A02012-01-19 07:21:25 +0000 > +++ configure.in =C2=A0 =C2=A0 =C2=A0 =C2=A02012-01-28 09:04:13 +0000 > @@ -1124,17 +1124,14 @@ > =C2=A0 =C2=A0 =C2=A0if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFI= G_MIN_VERSION; then > =C2=A0 =C2=A0 =C2=A0 =C2=A0 AC_MSG_CHECKING(for $2) > > - =C2=A0 =C2=A0 =C2=A0 =C2=A0if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_L= OG_FD; then > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_RESULT(yes) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_L= OG_FD && > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$1_CFLAGS=3D`$PKG_CONFIG --cflags "$2= " 2>&AS_MESSAGE_LOG_FD` && > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$1_LIBS=3D`$PKG_CONFIG --libs "$2" 2>= &AS_MESSAGE_LOG_FD`; then > + > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $1_CFLAGS=3D`AS_ECHO(["$$1_CFLAGS"])= | sed -e 's,///*,/,g'` > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $1_LIBS=3D`AS_ECHO(["$$1_LIBS"]) | s= ed -e 's,///*,/,g'` > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_RESULT([yes CFLAGS=3D'$= $1_CFLAGS' LIBS=3D'$$1_LIBS']) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 succeeded=3Dyes > - > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_CHECKING($1_CFLAGS) > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$1_CFLAGS=3D`$PKG_CONFIG --cfl= ags "$2"|sed -e 's,///*,/,g'` > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_RESULT($$1_CFLAGS) > - > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_CHECKING($1_LIBS) > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$1_LIBS=3D`$PKG_CONFIG --libs = "$2"|sed -e 's,///*,/,g'` > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0AC_MSG_RESULT($$1_LIBS) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 else > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 AC_MSG_RESULT(no) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $1_CFLAGS=3D"" > This patch no longer applies today (sigh, Changelog conflicts), and I'm a bit lazy about figuring out how to rebase this. I trust your good judgement, so I say you just push this. Thanks, - Jordi G. H.