bug#21008: 24.5; css-mode is derived from prog-mode

bug#21008: 24.5; css-mode is derived from prog-mode

[Vasilij Schneidermann]

[-- Attachment #1: Type: text/plain, Size: 2836 bytes --]

css-mode used to be derived from fundamental-mode.  I've checked the
master branch and found out that despite it being located in the
textmodes directory where modes are usually derived from text-mode,
css-mode is now derived from prog-mode.  Please change it to derive from
text-mode or move it into the progmodes directory for consistency's sake.



In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.2)
 of 2015-04-20 on bitzer.hoetzel.info
Windowing system distributor `The X.Org Foundation', version 11.0.11701000
System Description: Arch Linux

Configured using:
 `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --with-x-toolkit=gtk3 --with-xft
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
 --param=ssp-buffer-size=4' CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils time-date tooltip electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

Memory information:
((conses 16 71117 7789)
 (symbols 48 17616 0)
 (miscs 40 35 138)
 (strings 32 9078 4624)
 (string-bytes 1 249160)
 (vectors 16 8936)
 (vector-slots 8 384774 16671)
 (floats 8 63 68)
 (intervals 56 177 6)
 (buffers 960 11)
 (heap 1024 21676 897))

[-- Attachment #2: Type: text/html, Size: 3196 bytes --]

bug#21008: 24.5; css-mode is derived from prog-mode

[Stefan Monnier]

> Please change it to derive from text-mode

Why?  I think that would be wrong.

> or move it into the progmodes directory for consistency's sake.

The inheritance has semantic impacts, so that's the part that
it important.  The directory in which it's kept is largely irrelevant in
that it does not affect the behavior.

If someone wants to move it to progmodes, I won't veto it, but to the
extent that CSS currently isn't "Turing complete" (AFAIK), there are
arguments both for and against, so it's probably just not worth the
trouble (since moving files has consequences w.r.t revision history,
merging, etc...).

IOW, better just leave it alone and concentrate on things which matter more.


        Stefan

bug#21008: 24.5; css-mode is derived from prog-mode

[Jostein Kjønigsen]

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

As a response to: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21008

It should be noted that if CSS3 isn't already touring complete, there
are lots of CSS superset languages (LESS [1], SASS [2], etc) which
definitely are touring-complete and whose Emacs-modes do derive from css-
mode. As an emacs-user I would expect those modes to invoke my prog-mode
hooks without me manually having to wire them up.

So I don't think there is any doubt that erring on the side of prog-mode
is the right thing to do (tm).

While this isn't really a big deal to me, I agree with Vasilij that
consistency would be nice.

As for file revision history, last time I checked git manages to track
moved files just fine without messing up the history, so I don't see a
technical reason to avoid fixing this up.

[1] https://github.com/myfreeweb/less-mode/blob/master/less-mode.el#L75

[2] https://github.com/antonj/scss-mode/blob/master/scss-mode.el#L87

--
Jostein Kjønigsen
jostein@kjonigsen.net / jostein@secure.kjonigsen.net
 

[-- Attachment #2: Type: text/html, Size: 1774 bytes --]

bug#21008: 24.5; css-mode is derived from prog-mode

[Stefan Monnier]

> As for file revision history, last time I checked git manages to track
> moved files just fine without messing up the history, so I don't see a

Yes, it does when it tries to.  But there are several important cases
where it doesn't try to.


        Stefan

bug#21008: 24.5; css-mode is derived from prog-mode

[Alan Mackenzie]

In article <mailman.6556.1436365813.904.bug-gnu-emacs@gnu.org> you wrote:

> It should be noted that if CSS3 isn't already touring complete, ....

"Turing complete", please.  After Dr. Alan Turing, one of the greatest
Englishmen of all time.  He formulated the theoretical basis of
computation (hence "turing complete"), played a leading role in the second
world war in the decoding of German crypto, and after that was involved
in the development of early practical computers.  Sadly, he committed
suicide after being persecuted by the authorities over his homosexuality.

> --
> Jostein Kj?nigsen
> jostein@kjonigsen.net / jostein@secure.kjonigsen.net
> 

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#21008: close

[Tom Tromey]

I'm closing this bug.  It's been open for more than a year and nobody
has tried, AFAIK, to move css-mode.el to progmodes/.  And, Stefan argued
against bothering to do so, on the basis that there's no visible
benefit.

Tom