From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vincent =?UTF-8?Q?Bela=C3=AFche?= Newsgroups: gmane.emacs.bugs Subject: bug#5852: 23.1; Incorrect references in ses-mode Date: Sun, 25 Jul 2021 08:17:37 +0200 Message-ID: References: <845zfpi242.fsf@gmail.com> <871r7vrbez.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8866"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , Vincent =?UTF-8?Q?Bela=C3=AFche?= , 5852@debbugs.gnu.org, =?UTF-8?Q?G=C3=B6ran?= Uddeborg To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 08:18:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7XSm-00025z-Vj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 08:18:13 +0200 Original-Received: from localhost ([::1]:39620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7XSl-0006Z6-CJ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 02:18:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7XSb-0006XQ-Uj for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 02:18:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7XSb-0000CW-Mp for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 02:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7XSb-0007fl-JZ for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 02:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vincent =?UTF-8?Q?Bela=C3=AFche?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 06:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5852 X-GNU-PR-Package: emacs Original-Received: via spool by 5852-submit@debbugs.gnu.org id=B5852.162719388029485 (code B ref 5852); Sun, 25 Jul 2021 06:18:01 +0000 Original-Received: (at 5852) by debbugs.gnu.org; 25 Jul 2021 06:18:00 +0000 Original-Received: from localhost ([127.0.0.1]:47370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7XSZ-0007fU-GU for submit@debbugs.gnu.org; Sun, 25 Jul 2021 02:17:59 -0400 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:37391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7XSU-0007fE-Un for 5852@debbugs.gnu.org; Sun, 25 Jul 2021 02:17:58 -0400 Original-Received: by mail-pj1-f52.google.com with SMTP id a4-20020a17090aa504b0290176a0d2b67aso6591206pjq.2 for <5852@debbugs.gnu.org>; Sat, 24 Jul 2021 23:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ta8lLRl3/Q4O0JwjsmVIQudiqgwKLUJ1vS5cvpwtOd0=; b=aQW796CFTMNcGm6G4gXq3OPW2hUbWRByj82tmQJPTfTMTn1qiSmizwJIdfJhWJJILs EI648+unOF+LNzmVYuxGWJP7vpN6GhZmSvCSto32mv7xmMuJlZQIoUxe9fl6XajPunhg F/yWPsjWbOmMGyhSptpa7LtNiEioy9TYb8x5YQ4Yg+Ft7EXqsWEkI6SrprH4LmCIUKJ1 +UfjS1zDvuWc7EeRYYPXBwVHTL4w20NKQ2kaV9SnNxIWUrrUIO/WCC8059IQViNkL+C3 PrZXaOz5uD9gbh5eqMDGM/C3gZ9h2JwL+TaaUqFfur4y2PKvPHeXANMJUAwwrKm7kAb0 LPUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ta8lLRl3/Q4O0JwjsmVIQudiqgwKLUJ1vS5cvpwtOd0=; b=hg09cELP5w4esJ1LigoAJDkdm52JGb3Ockw3lof5WMdZenyojzSqhM/F+In2kMgzhZ cWhv1X7oNq/1u1BLfVzY9j/IqpDn/vGhyb36SB3FUk1ND+mWI9f3sxS0JkUrbZAxN1Kc YRh1lawxkfM/Iv/ITGHOUt6pCNhtLCfHww1HmjPx/jw1tK/XiwxB4CY0b8vCZjT/+X7J 4PJHHz+ryTuQvEGK1iyxXopXMWt/yx3aJh80VRH5cBQprbYcwDUgYVMRdOKgvvYLyDbg nDAIevhadQskqjr72ci+Ca4XUW0nlEu5+xLIGdirE/xgPaEFtrnDMKD3q7kWitNabd12 vKuQ== X-Gm-Message-State: AOAM531ZIZlM8y4YBdqKeVFscYFaqI5Vzn19GF1SOXrFWDagT1xQMVF3 1rR9oPRu69dFe4huvg7oLmukA1wZP3HiuBmgMHI= X-Google-Smtp-Source: ABdhPJxBzegjR8Gm2KIOhRkQOPxoe6GlPUScpvpiZP7jAEb7naYbH4goPzt1GKe3Ycd7G6gMKFWFDwm1XC/EYlsp/Lo= X-Received: by 2002:a17:90a:8410:: with SMTP id j16mr11710653pjn.111.1627193869131; Sat, 24 Jul 2021 23:17:49 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210678 Archived-At: The same test function, but with comments : (defun bug-5852 ();;--- "Check no irrelevant reference is created when a row is inserted and a formula is yanked" (interactive);;--- (let ((ses-initial-size '(3 . 3))); size before last row insertion, due to all preceding TAB & C-o (with-temp-buffer (ses-mode) (dolist (val '( (ses-edit-cell 0 1 1) ; 1 RET (ses-edit-cell 1 0 2) ; 2 RET (ses-edit-cell 1 1 (+ B1 A2)) ; ( + SPC B1 SPC A2 RET (ses-edit-cell 2 0 3) ; 3 RET (ses-edit-cell 2 1 (+ B2 A3)) ; ( + SPC B2 SPC A3 RET (ses-jump A3) ; C-n (ses-insert-row 1) ; C-o (ses-edit-cell 2 0 4) ; 4 RET (ses-jump B2) ; C-p )) (apply 'funcall-interactively val) (ses-command-hook)) (let ((beg (point-marker))); C-SPC (ses-jump 'C2) ; C-f (copy-region-as-kill beg (point) nil); M-w (set-marker beg nil)) (dolist (val '( (ses-jump B3); C-n C-b (yank) ; C-y (ses-jump B4); C-n (yank); C-y )) (apply 'funcall-interactively val) (ses-command-hook)) (ses-repair-cell-reference-all) ))) Le dim. 25 juil. 2021 =C3=A0 07:56, Vincent Bela=C3=AFche a =C3=A9crit : > > On more significant difference between the function bug-5852 and the > example is the the initial size is (3 . 3) instead of (1. 1). This is > because I speculated that only the last row insertion (C-o) plays a > role. > > V. > > Le dim. 25 juil. 2021 =C3=A0 07:48, Vincent Bela=C3=AFche > a =C3=A9crit : > > > > Just to add something : reading again SES code, and (info "(elisp) > > Command Overview") I am a bit skeptical about the explanation in my > > previous email. > > It seems that only key strokes are queue, but command execution and > > post command hook are in sequence, so not done concurrently. > > I wrote this function to try to reproduce the bug, and on my office PC > > it does not reproduce it: > > > > (defun bug-5852 ();;--- > > "Check no irrelevant reference is created when a row is inserted and > > a formula is yanked" > > (interactive);;--- > > (let ((ses-initial-size '(3 . 3))) > > (with-temp-buffer > > (ses-mode) > > (dolist (val '( > > (ses-edit-cell 0 1 1) > > (ses-edit-cell 1 0 2) > > (ses-edit-cell 1 1 (+ B1 A2)) > > (ses-edit-cell 2 0 3) > > (ses-edit-cell 2 1 (+ B2 A3)) > > (ses-jump A3) > > (ses-insert-row 1) > > (ses-edit-cell 2 0 4) > > (ses-jump B2) > > )) > > (apply 'funcall-interactively val) > > (ses-command-hook)) > > (let ((beg (point-marker))) > > (ses-jump 'C2) ; C-n > > (copy-region-as-kill beg (point) nil) > > (set-marker beg nil)) > > (dolist (val '( > > (ses-jump B3) > > (yank) > > (ses-jump B4) > > (yank) > > )) > > (apply 'funcall-interactively val) > > (ses-command-hook)) > > (ses-repair-cell-reference-all) > > ))) > > > > Please note that the main difference with the provided example is that > > motion is done with ses-jump, and not with motion commands. Also the > > save to keyring is not done interatively. > > V. > > > > Le sam. 24 juil. 2021 =C3=A0 23:46, Vincent Bela=C3=AFche > > a =C3=A9crit : > > > > > > Hello Lars, > > > > > > Sorry for not making any feedback for so long, actually I was just > > > distracted by some other business, and I somewhat had forgotten about > > > it. > > > > > > I suspect a race condition between the post command hook and the next > > > command. That is to say when one yanks the fomula (the first yank), > > > one relocates the reference but for this one uses current references > > > that have not yet been relocated because the previous post-command > > > hook execution is not yet over. > > > > > > The bug does not show every time I do the experiment. I tried this > > > morning with my office PC which is a fast machine, and it proved out > > > quite hard to reproduce, even when I launched some big C program > > > compilation in parallel to eat the mips. > > > > > > Next week I will do some experiment with my home PC which is quite > > > quite slower, and I make some feedback. Unfortunateless both machine > > > do not have the same emacs version, but anyway all changes in SES > > > since the version on my home PC are not related to this bug, so > > > nevertheless that will be a good indication whether my guess is > > > correct. > > > > > > V. > > > > > > Le dim. 18 juil. 2021 =C3=A0 15:37, Lars Ingebrigtsen a =C3=A9crit : > > > > > > > > Vincent Bela=C3=AFche writes: > > > > > > > > > I will investigate why and feed back once I have a better idea of= what > > > > > is happening. > > > > > > > > Hi, > > > > > > > > this was a year ago. Did you make any progress on this issue? > > > > > > > > -- > > > > (domestic pets only, the antidote for overdose, milk.) > > > > bloggy blog: http://lars.ingebrigtsen.no