From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vincent =?UTF-8?Q?Bela=C3=AFche?= Newsgroups: gmane.emacs.bugs Subject: bug#5852: 23.1; Incorrect references in ses-mode Date: Sun, 25 Jul 2021 08:18:59 +0200 Message-ID: References: <845zfpi242.fsf@gmail.com> <871r7vrbez.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19326"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , Vincent =?UTF-8?Q?Bela=C3=AFche?= , 5852@debbugs.gnu.org, =?UTF-8?Q?G=C3=B6ran?= Uddeborg To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 08:20:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7XUg-0004n0-69 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 08:20:10 +0200 Original-Received: from localhost ([::1]:41202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7XUf-0007el-86 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 02:20:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7XUY-0007eY-CI for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 02:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7XUY-0001si-5G for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 02:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7XUY-0007jN-1q for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 02:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vincent =?UTF-8?Q?Bela=C3=AFche?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5852 X-GNU-PR-Package: emacs Original-Received: via spool by 5852-submit@debbugs.gnu.org id=B5852.162719395829662 (code B ref 5852); Sun, 25 Jul 2021 06:20:02 +0000 Original-Received: (at 5852) by debbugs.gnu.org; 25 Jul 2021 06:19:18 +0000 Original-Received: from localhost ([127.0.0.1]:47382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7XTq-0007iM-7l for submit@debbugs.gnu.org; Sun, 25 Jul 2021 02:19:18 -0400 Original-Received: from mail-pl1-f177.google.com ([209.85.214.177]:46837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7XTo-0007i8-8G for 5852@debbugs.gnu.org; Sun, 25 Jul 2021 02:19:17 -0400 Original-Received: by mail-pl1-f177.google.com with SMTP id t21so7794844plr.13 for <5852@debbugs.gnu.org>; Sat, 24 Jul 2021 23:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PmPidB5ZQsHk9vi9cRazHsAK7jjj4CUV+Nu06ZvIgSQ=; b=qHxj/+c88LcY1AvkAEhuBK1ZxEf9SfIb5ZFPgSM1+Dfbz5GKJkeeZ5RV55lmWQNhrv e/JSxW42s9hk/WMFU4KmCdchdV53ThopRGziXBlrg9vlK/MwvETMMwS1fsfaIoRHqzNw hpRW0iHtvioGbgnrMP9fmI9C+H6nIfk2nRWK4lsCObpcew/9j8oLaFuiQqnqioG9Q7wo 9ni8VVRsYxS8lpwX92UOKbW7+Cp16ZJX6FCR5zPiEtZ/3P6kwhPsYKNgltbhP7pL/zhI vBD29fV5RCQF1yLTeoh7ASAS31yFobcBRRI3HK3KP2qd8ZfoVcGWgRTAvYftfP8AkqI9 GPWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PmPidB5ZQsHk9vi9cRazHsAK7jjj4CUV+Nu06ZvIgSQ=; b=Im3JHiCgqhCWWjxFc5I/xTiPjdPgeG6A2OvWLusBwPcF8jOkwsh4TynfYixXRQ2xXc ANHjQzvwZ+mgZgY3tSWJgHnAhTveGmOlYLSmrLsjPRGDgMA5ZGeEXy6ht1Wh4IheeOgK lw1U2pw9FI5+V2qVNHIA00cwfT7VYnSeIDN0DOJkkbpclx58UqEH6z1NEvfts15PFA5U uMtug1NACSRN3fCeOEfGHeFHjF09Y904487GoLNVn5XM78QOUTmn5vq+DkSeChme3ifx LNb++pJ0K+UaGxKUgPKa6gNk1zbv5/FYVeNPZk8c49a3aEIXqCZAIKssR9a3vYr+ydvU z3uw== X-Gm-Message-State: AOAM533AWrM9l0wAFmYJEZxg3U6LAbvD067wAQNCJGHVEFxBrQMKwRsO fkpFOOcS0ZK0UJjua0o0KxjK3UbP2mHXRuC8dF8= X-Google-Smtp-Source: ABdhPJzRCEH65GCxvXd4oK+LojGdf42DFfqi1zFIjtS3lJFSKqk8xRLh9UHFrNMhdde8B7LFDEapbPzXzi1rRXFhV70= X-Received: by 2002:a17:903:300b:b029:12b:db40:2cfb with SMTP id o11-20020a170903300bb029012bdb402cfbmr6662000pla.59.1627193950539; Sat, 24 Jul 2021 23:19:10 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210679 Archived-At: The bug-5852 test function does not reproduce the bug on my home PC either = =E2=80=A6 V. Le dim. 25 juil. 2021 =C3=A0 08:17, Vincent Bela=C3=AFche a =C3=A9crit : > > The same test function, but with comments : > > > (defun bug-5852 ();;--- > "Check no irrelevant reference is created when a row is inserted and > a formula is yanked" > (interactive);;--- > (let ((ses-initial-size '(3 . 3))); size before last row insertion, > due to all preceding TAB & C-o > (with-temp-buffer > (ses-mode) > (dolist (val '( > (ses-edit-cell 0 1 1) ; 1 RET > (ses-edit-cell 1 0 2) ; 2 RET > (ses-edit-cell 1 1 (+ B1 A2)) ; ( + SPC B1 SPC A2 RET > (ses-edit-cell 2 0 3) ; 3 RET > (ses-edit-cell 2 1 (+ B2 A3)) ; ( + SPC B2 SPC A3 RET > (ses-jump A3) ; C-n > (ses-insert-row 1) ; C-o > (ses-edit-cell 2 0 4) ; 4 RET > (ses-jump B2) ; C-p > )) > (apply 'funcall-interactively val) > (ses-command-hook)) > (let ((beg (point-marker))); C-SPC > (ses-jump 'C2) ; C-f > (copy-region-as-kill beg (point) nil); M-w > (set-marker beg nil)) > (dolist (val '( > (ses-jump B3); C-n C-b > (yank) ; C-y > (ses-jump B4); C-n > (yank); C-y > )) > (apply 'funcall-interactively val) > (ses-command-hook)) > (ses-repair-cell-reference-all) > ))) > > Le dim. 25 juil. 2021 =C3=A0 07:56, Vincent Bela=C3=AFche > a =C3=A9crit : > > > > On more significant difference between the function bug-5852 and the > > example is the the initial size is (3 . 3) instead of (1. 1). This is > > because I speculated that only the last row insertion (C-o) plays a > > role. > > > > V. > > > > Le dim. 25 juil. 2021 =C3=A0 07:48, Vincent Bela=C3=AFche > > a =C3=A9crit : > > > > > > Just to add something : reading again SES code, and (info "(elisp) > > > Command Overview") I am a bit skeptical about the explanation in my > > > previous email. > > > It seems that only key strokes are queue, but command execution and > > > post command hook are in sequence, so not done concurrently. > > > I wrote this function to try to reproduce the bug, and on my office P= C > > > it does not reproduce it: > > > > > > (defun bug-5852 ();;--- > > > "Check no irrelevant reference is created when a row is inserted an= d > > > a formula is yanked" > > > (interactive);;--- > > > (let ((ses-initial-size '(3 . 3))) > > > (with-temp-buffer > > > (ses-mode) > > > (dolist (val '( > > > (ses-edit-cell 0 1 1) > > > (ses-edit-cell 1 0 2) > > > (ses-edit-cell 1 1 (+ B1 A2)) > > > (ses-edit-cell 2 0 3) > > > (ses-edit-cell 2 1 (+ B2 A3)) > > > (ses-jump A3) > > > (ses-insert-row 1) > > > (ses-edit-cell 2 0 4) > > > (ses-jump B2) > > > )) > > > (apply 'funcall-interactively val) > > > (ses-command-hook)) > > > (let ((beg (point-marker))) > > > (ses-jump 'C2) ; C-n > > > (copy-region-as-kill beg (point) nil) > > > (set-marker beg nil)) > > > (dolist (val '( > > > (ses-jump B3) > > > (yank) > > > (ses-jump B4) > > > (yank) > > > )) > > > (apply 'funcall-interactively val) > > > (ses-command-hook)) > > > (ses-repair-cell-reference-all) > > > ))) > > > > > > Please note that the main difference with the provided example is tha= t > > > motion is done with ses-jump, and not with motion commands. Also the > > > save to keyring is not done interatively. > > > V. > > > > > > Le sam. 24 juil. 2021 =C3=A0 23:46, Vincent Bela=C3=AFche > > > a =C3=A9crit : > > > > > > > > Hello Lars, > > > > > > > > Sorry for not making any feedback for so long, actually I was just > > > > distracted by some other business, and I somewhat had forgotten abo= ut > > > > it. > > > > > > > > I suspect a race condition between the post command hook and the ne= xt > > > > command. That is to say when one yanks the fomula (the first yank), > > > > one relocates the reference but for this one uses current reference= s > > > > that have not yet been relocated because the previous post-command > > > > hook execution is not yet over. > > > > > > > > The bug does not show every time I do the experiment. I tried this > > > > morning with my office PC which is a fast machine, and it proved ou= t > > > > quite hard to reproduce, even when I launched some big C program > > > > compilation in parallel to eat the mips. > > > > > > > > Next week I will do some experiment with my home PC which is quite > > > > quite slower, and I make some feedback. Unfortunateless both machin= e > > > > do not have the same emacs version, but anyway all changes in SES > > > > since the version on my home PC are not related to this bug, so > > > > nevertheless that will be a good indication whether my guess is > > > > correct. > > > > > > > > V. > > > > > > > > Le dim. 18 juil. 2021 =C3=A0 15:37, Lars Ingebrigtsen a =C3=A9crit : > > > > > > > > > > Vincent Bela=C3=AFche writes: > > > > > > > > > > > I will investigate why and feed back once I have a better idea = of what > > > > > > is happening. > > > > > > > > > > Hi, > > > > > > > > > > this was a year ago. Did you make any progress on this issue? > > > > > > > > > > -- > > > > > (domestic pets only, the antidote for overdose, milk.) > > > > > bloggy blog: http://lars.ingebrigtsen.no