From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vincent =?UTF-8?Q?Bela=C3=AFche?= Newsgroups: gmane.emacs.bugs Subject: bug#5852: 23.1; Incorrect references in ses-mode Date: Sun, 25 Jul 2021 07:56:35 +0200 Message-ID: References: <845zfpi242.fsf@gmail.com> <871r7vrbez.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37160"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , Vincent =?UTF-8?Q?Bela=C3=AFche?= , 5852@debbugs.gnu.org, =?UTF-8?Q?G=C3=B6ran?= Uddeborg To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 07:57:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7X8R-0009PA-He for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 07:57:11 +0200 Original-Received: from localhost ([::1]:37204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7X8P-0003kt-TP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 01:57:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7X8I-0003jx-M4 for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 01:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7X8I-0007mA-EM for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 01:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7X8I-0007AR-A5 for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 01:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vincent =?UTF-8?Q?Bela=C3=AFche?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 05:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5852 X-GNU-PR-Package: emacs Original-Received: via spool by 5852-submit@debbugs.gnu.org id=B5852.162719261527536 (code B ref 5852); Sun, 25 Jul 2021 05:57:02 +0000 Original-Received: (at 5852) by debbugs.gnu.org; 25 Jul 2021 05:56:55 +0000 Original-Received: from localhost ([127.0.0.1]:47360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7X8B-0007A4-9P for submit@debbugs.gnu.org; Sun, 25 Jul 2021 01:56:55 -0400 Original-Received: from mail-pj1-f43.google.com ([209.85.216.43]:35652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7X88-00079q-JI for 5852@debbugs.gnu.org; Sun, 25 Jul 2021 01:56:53 -0400 Original-Received: by mail-pj1-f43.google.com with SMTP id pf12-20020a17090b1d8cb0290175c085e7a5so15042104pjb.0 for <5852@debbugs.gnu.org>; Sat, 24 Jul 2021 22:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NLir9JcsbQ/n37SD+4IOa5DHQ05GLlgQkCszzpdxEr4=; b=C3ROuXNdiu3BbqffFjD2Ux6j1TKU8OF3X0ctOYiJrrRj8toIRYuhOqXAlOM1dAudWe 1g0QqOUNfpQe5A4xnCMPou+v9sznrmHOoAExOE4nAQplHMnacmAZ7syHcbUkDo5CQo5K 050YVJEwYLHMxUNpy2Ek5wCc4hMLiTe6LrBWvqeKtgg7hvnlCEMUaVYPnRnEQA0nje5Q 7As7S2otGgHKQzzI5kIpSYwfoCPEc10itpTIuGaDlHq1NnzfgGbTWB1NOqa8Q43P2drt MKbAk2bsxPFwG0Kew2ZzbkW4VevIQkvLCwt9xCHls4MbcZ5oV4M4VRprKY+jBU6TKbt+ ujDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NLir9JcsbQ/n37SD+4IOa5DHQ05GLlgQkCszzpdxEr4=; b=TZjXlggo2P829yU+KOx8znSEw4USD41vWC8a9kct7kVE2Mm1M+h8OhWh1d2Thkyszl GJKrqF1+RpU3zXZHzNUeH7WC9J8Vh0CqK0HpKJ4KZ4z11P34H7oyFoCSbLzE5k/+nXuV rZM974akYOxvHyg6lSuXHHsBT4SnNiLMS6hdgky91CcDfg8nJjYFGwY/T5kzQOqDLDDv uO8s3iBgHJvEQQv1CvOwggBBnmXiJDowEOwm+E/5LzlbrZDHYuxcKtOEHfPhX65a3JPS SzGcKyF8QHlEttSXa7/c4nyzCQ14RI6CPV+G9bS7VTrgU0QeJVT+tHYX9rBiAvA1N3Rc VUYA== X-Gm-Message-State: AOAM533D25WQeOLMSNoNJn2fLIHcS5wNr1Q+VjqO3gSG0Xu/12C4PIw7 sB+MermaEiIbX28G9XWzRKWSf5ZG0Le0YyBc9qw= X-Google-Smtp-Source: ABdhPJwKUa5PnRIS4ZR+CTIR1LTK7n8ejE+Ovl50NV4xp3Hu6msIny5KtpNGd16vyAshIYH9n0vWaoXo0wEpN4JGXEc= X-Received: by 2002:aa7:87cd:0:b029:32e:7954:2872 with SMTP id i13-20020aa787cd0000b029032e79542872mr12187239pfo.0.1627192606635; Sat, 24 Jul 2021 22:56:46 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210677 Archived-At: On more significant difference between the function bug-5852 and the example is the the initial size is (3 . 3) instead of (1. 1). This is because I speculated that only the last row insertion (C-o) plays a role. V. Le dim. 25 juil. 2021 =C3=A0 07:48, Vincent Bela=C3=AFche a =C3=A9crit : > > Just to add something : reading again SES code, and (info "(elisp) > Command Overview") I am a bit skeptical about the explanation in my > previous email. > It seems that only key strokes are queue, but command execution and > post command hook are in sequence, so not done concurrently. > I wrote this function to try to reproduce the bug, and on my office PC > it does not reproduce it: > > (defun bug-5852 ();;--- > "Check no irrelevant reference is created when a row is inserted and > a formula is yanked" > (interactive);;--- > (let ((ses-initial-size '(3 . 3))) > (with-temp-buffer > (ses-mode) > (dolist (val '( > (ses-edit-cell 0 1 1) > (ses-edit-cell 1 0 2) > (ses-edit-cell 1 1 (+ B1 A2)) > (ses-edit-cell 2 0 3) > (ses-edit-cell 2 1 (+ B2 A3)) > (ses-jump A3) > (ses-insert-row 1) > (ses-edit-cell 2 0 4) > (ses-jump B2) > )) > (apply 'funcall-interactively val) > (ses-command-hook)) > (let ((beg (point-marker))) > (ses-jump 'C2) ; C-n > (copy-region-as-kill beg (point) nil) > (set-marker beg nil)) > (dolist (val '( > (ses-jump B3) > (yank) > (ses-jump B4) > (yank) > )) > (apply 'funcall-interactively val) > (ses-command-hook)) > (ses-repair-cell-reference-all) > ))) > > Please note that the main difference with the provided example is that > motion is done with ses-jump, and not with motion commands. Also the > save to keyring is not done interatively. > V. > > Le sam. 24 juil. 2021 =C3=A0 23:46, Vincent Bela=C3=AFche > a =C3=A9crit : > > > > Hello Lars, > > > > Sorry for not making any feedback for so long, actually I was just > > distracted by some other business, and I somewhat had forgotten about > > it. > > > > I suspect a race condition between the post command hook and the next > > command. That is to say when one yanks the fomula (the first yank), > > one relocates the reference but for this one uses current references > > that have not yet been relocated because the previous post-command > > hook execution is not yet over. > > > > The bug does not show every time I do the experiment. I tried this > > morning with my office PC which is a fast machine, and it proved out > > quite hard to reproduce, even when I launched some big C program > > compilation in parallel to eat the mips. > > > > Next week I will do some experiment with my home PC which is quite > > quite slower, and I make some feedback. Unfortunateless both machine > > do not have the same emacs version, but anyway all changes in SES > > since the version on my home PC are not related to this bug, so > > nevertheless that will be a good indication whether my guess is > > correct. > > > > V. > > > > Le dim. 18 juil. 2021 =C3=A0 15:37, Lars Ingebrigtsen = a =C3=A9crit : > > > > > > Vincent Bela=C3=AFche writes: > > > > > > > I will investigate why and feed back once I have a better idea of w= hat > > > > is happening. > > > > > > Hi, > > > > > > this was a year ago. Did you make any progress on this issue? > > > > > > -- > > > (domestic pets only, the antidote for overdose, milk.) > > > bloggy blog: http://lars.ingebrigtsen.no