From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Duncan Findlay via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55883: [PATCH] Update X Primary Selection with active regions Date: Tue, 21 Jun 2022 18:58:16 -0700 Message-ID: References: <834k0t104u.fsf@gnu.org> <8335gbzled.fsf@gnu.org> <837d5jtp9x.fsf@gnu.org> <83v8t1rhtt.fsf@gnu.org> <83czf6ns0e.fsf@gnu.org> <878rpuknov.fsf@tcd.ie> <838rpuneb1.fsf@gnu.org> Reply-To: Duncan Findlay Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000e3472a05e1ffad96" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27516"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Basil L. Contovounesios" , 55883@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 22 04:00:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3pfD-0006x2-Fa for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Jun 2022 04:00:15 +0200 Original-Received: from localhost ([::1]:43214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3pfC-0007z3-3A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jun 2022 22:00:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3pf0-0007yr-VO for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 22:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3pf0-00029u-LJ for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 22:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3pf0-0004rB-IQ for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 22:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Duncan Findlay Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jun 2022 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55883-submit@debbugs.gnu.org id=B55883.165586314318555 (code B ref 55883); Wed, 22 Jun 2022 02:00:02 +0000 Original-Received: (at 55883) by debbugs.gnu.org; 22 Jun 2022 01:59:03 +0000 Original-Received: from localhost ([127.0.0.1]:33608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3pe3-0004pD-CV for submit@debbugs.gnu.org; Tue, 21 Jun 2022 21:59:03 -0400 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:41889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3pe0-0004og-5Z for 55883@debbugs.gnu.org; Tue, 21 Jun 2022 21:59:01 -0400 Original-Received: by mail-wr1-f50.google.com with SMTP id q9so21298139wrd.8 for <55883@debbugs.gnu.org>; Tue, 21 Jun 2022 18:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u7/jflI1TYM8Ou+17mVZBjDMc25wfmw9I47AC2cwgh0=; b=UGGyhH7wOolv6/sXvb3oDJy1gigxEOzOKUMbSsfIhg4iCe/x8AU8r8qQqfIdcmGWX6 dfZiC1kAaWbGaiB9E0+ehA7q15/w2auOHcycOAfOIeSJRZoE1Yk5OpQAYb22atQBhi8P vfOq/dOuLq2j5HaI4OrxJ23+7zFGrhnpcd+OpfHOH9GbHbVX1VAi3tPJLa2+eYHhTQ/D sJUOKUpNZiW7V07jGN2+JqvHb5y2i7pUquSiujAaiKp8XTWWAdVuxSI1qqV6gDl6z6IG 0cUp1AFEjcKHx+z691G+DXOQSJnVTPtsNOP0XN/e7sUjoI2MV5HGCCWnpogiKYHxrFu8 XqyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u7/jflI1TYM8Ou+17mVZBjDMc25wfmw9I47AC2cwgh0=; b=PBs6cXuh/WxoDZSoD7WLs7XbdEJswmxQbgVAylW5/Xqvky7fG/h8UBfebq9ezHfyKA /bKB1scXJxGSnmPNHDtrM7WotbnDvAlkWZnNWEJir5Yf+s6mbZb2xh3rFNvN9SteKgB1 97UbxFM1BsqZrmFabekIEUnueqBTs5O/FxCP7BrFUGP5VSzVPRlAsZ1i4CNxgMBAnjTj RbjO8QQIaqybD6gu4VZy9KN5aoAp9Yv7tluEoUhWWQ5MepVdrHEEwzkOqpq64Zfw8DqY AR7q1hDZkmSQutpkpoSIxn5g+DklztWvklp3MmsrzRO7I+XcfJggYt0zxs3RKVQSFngf Y+ag== X-Gm-Message-State: AJIora/8WQOMmihqsXw6kCw1HBoai1nGdHmhHwMAXslIWH2Zm8pIVn0m cxT8pzpFkoQbCgnTSQAva8nG4z1sb8LD+ugF6vI3Ug== X-Google-Smtp-Source: AGRyM1v8kh5F3+Szcgbhy9Jhl9BSFuvKWFsPHI9Z6fXt6ioFYIyvy2CtgvJViYVhAtawnmUWkdmTFRHneuSOjAl2gJw= X-Received: by 2002:a5d:5581:0:b0:20f:fc51:7754 with SMTP id i1-20020a5d5581000000b0020ffc517754mr746937wrv.413.1655863133779; Tue, 21 Jun 2022 18:58:53 -0700 (PDT) In-Reply-To: <838rpuneb1.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234991 Archived-At: --000000000000e3472a05e1ffad96 Content-Type: text/plain; charset="UTF-8" Oops. I'm sorry I missed that, and thank you for the quick fixes! It looks like you renamed the variable, and put it in frame.el with 7e1f84fa3bc7dfd84415813889c91070c0759da2 and 4e68166d77cdd0f3b84c9bf5681f6a95e51ad238. I assume that means that frame.el is always loaded in tests, and that xterm.el is sometimes not loaded? I don't have a problem with the current fix, though I'm wondering if the attached patch would have worked too? Thanks Duncan On Sat, Jun 18, 2022 at 9:10 AM Eli Zaretskii wrote: > > > From: "Basil L. Contovounesios" > > Cc: eliz@gnu.org, duncf@google.com > > Date: Sat, 18 Jun 2022 18:15:28 +0300 > > > > > No further comments, so I installed this on the master branch now. > > > > Thanks, but please see the resulting 'make check' errors attached. > > > > Perhaps dereferencing xterm-select-active-regions should be guarded by > > bound-and-true-p or the like? > > No, that's ugly. I fixed it in a different way, thanks. --000000000000e3472a05e1ffad96 Content-Type: application/x-patch; name="0001-Set-default-value-for-xterm-select-active-regions.patch" Content-Disposition: attachment; filename="0001-Set-default-value-for-xterm-select-active-regions.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4oy24580 RnJvbSA3YmQyY2QxYWI3MWIyMmE1ZGRlMTI5MTQ1ZTg0MTQyYzRkMjhjNDFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEdW5jYW4gRmluZGxheSA8ZHVuY2ZAZ29vZ2xlLmNvbT4KRGF0 ZTogVHVlLCAyMSBKdW4gMjAyMiAxODozMzoyOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFNldCBk ZWZhdWx0IHZhbHVlIGZvciB4dGVybS1zZWxlY3QtYWN0aXZlLXJlZ2lvbnMKCiogbGlzcC9mcmFt ZS5lbCAoeHRlcm0tc2VsZWN0LWFjdGl2ZS1yZWdpb25zKTogU2V0IGRlZmF1bHQgdmFsdWUKb2Yg bmlsIGlmIG5vdCBkZWZpbmVkLiAoYnVnIzU1ODgzKQotLS0KIGxpc3AvZnJhbWUuZWwgfCAyICst CiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9saXNwL2ZyYW1lLmVsIGIvbGlzcC9mcmFtZS5lbAppbmRleCAzNTg2M2MwMTM1Li40MjNi MWM0N2EyIDEwMDY0NAotLS0gYS9saXNwL2ZyYW1lLmVsCisrKyBiL2xpc3AvZnJhbWUuZWwKQEAg LTIxNTAsNyArMjE1MCw3IEBAICdkaXNwbGF5LW11bHRpLWZyYW1lLXAKIChkZWZhbGlhcyAnZGlz cGxheS1tdWx0aS1mb250LXAgIydkaXNwbGF5LWdyYXBoaWMtcCkKIAogOzsgRnJvbSB0ZXJtL3h0 ZXJtLmVsCi0oZGVmdmFyIHh0ZXJtLXNlbGVjdC1hY3RpdmUtcmVnaW9ucykKKyhkZWZ2YXIgeHRl cm0tc2VsZWN0LWFjdGl2ZS1yZWdpb25zIG5pbCkKIAogKGRlZnVuIGRpc3BsYXktc2VsZWN0aW9u cy1wICgmb3B0aW9uYWwgZGlzcGxheSkKICAgIlJldHVybiBub24tbmlsIGlmIERJU1BMQVkgc3Vw cG9ydHMgc2VsZWN0aW9ucy4KLS0gCjIuMzcuMC5yYzAuMTA0LmcwNjExNjExYTk0LWdvb2cKCg== --000000000000e3472a05e1ffad96--