From: Duncan Findlay via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>, 55883@debbugs.gnu.org
Subject: bug#55883: [PATCH] Update X Primary Selection with active regions
Date: Tue, 21 Jun 2022 18:58:16 -0700 [thread overview]
Message-ID: <CAPANw+NQAx+2uerex8XK_XGs=CBjWo4ccQz=-3f4Fk1RKWaJxA@mail.gmail.com> (raw)
In-Reply-To: <838rpuneb1.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
Oops. I'm sorry I missed that, and thank you for the quick fixes! It
looks like you renamed the variable, and put it in frame.el with
7e1f84fa3bc7dfd84415813889c91070c0759da2 and
4e68166d77cdd0f3b84c9bf5681f6a95e51ad238. I assume that means that
frame.el is always loaded in tests, and that xterm.el is sometimes not
loaded?
I don't have a problem with the current fix, though I'm wondering if
the attached patch would have worked too?
Thanks
Duncan
On Sat, Jun 18, 2022 at 9:10 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: "Basil L. Contovounesios" <contovob@tcd.ie>
> > Cc: eliz@gnu.org, duncf@google.com
> > Date: Sat, 18 Jun 2022 18:15:28 +0300
> >
> > > No further comments, so I installed this on the master branch now.
> >
> > Thanks, but please see the resulting 'make check' errors attached.
> >
> > Perhaps dereferencing xterm-select-active-regions should be guarded by
> > bound-and-true-p or the like?
>
> No, that's ugly. I fixed it in a different way, thanks.
[-- Attachment #2: 0001-Set-default-value-for-xterm-select-active-regions.patch --]
[-- Type: application/x-patch, Size: 853 bytes --]
next prev parent reply other threads:[~2022-06-22 1:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 6:18 bug#55883: [PATCH] Update X Primary Selection with active regions Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-10 6:52 ` Eli Zaretskii
2022-06-11 1:59 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-11 7:53 ` Eli Zaretskii
2022-06-14 5:57 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-14 6:36 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-14 12:15 ` Eli Zaretskii
2022-06-15 2:01 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15 16:51 ` Eli Zaretskii
2022-06-18 11:13 ` Eli Zaretskii
2022-06-18 15:15 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-18 16:09 ` Eli Zaretskii
2022-06-22 1:58 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-06-22 13:02 ` Eli Zaretskii
2022-06-22 15:37 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPANw+NQAx+2uerex8XK_XGs=CBjWo4ccQz=-3f4Fk1RKWaJxA@mail.gmail.com' \
--to=bug-gnu-emacs@gnu.org \
--cc=55883@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=duncf@google.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).