From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew De Angelis Newsgroups: gmane.emacs.bugs Subject: bug#60703: Patches to xwidget code Date: Sun, 19 Feb 2023 16:00:44 -0500 Message-ID: References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> <87pmb024d7.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ab0d4705f513d7cd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32846"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60703@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 19 22:02:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTqpE-0008Oc-6U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Feb 2023 22:02:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTqou-0005KY-0C; Sun, 19 Feb 2023 16:02:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTqos-0005KM-0s for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 16:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTqor-0005IQ-Ns for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 16:02:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTqor-0008C2-It for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 16:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrew De Angelis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Feb 2023 21:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60703 X-GNU-PR-Package: emacs Original-Received: via spool by 60703-submit@debbugs.gnu.org id=B60703.167684046331411 (code B ref 60703); Sun, 19 Feb 2023 21:02:01 +0000 Original-Received: (at 60703) by debbugs.gnu.org; 19 Feb 2023 21:01:03 +0000 Original-Received: from localhost ([127.0.0.1]:49791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTqnu-0008AZ-NT for submit@debbugs.gnu.org; Sun, 19 Feb 2023 16:01:03 -0500 Original-Received: from mail-vk1-f169.google.com ([209.85.221.169]:44715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTqns-00089r-Kh for 60703@debbugs.gnu.org; Sun, 19 Feb 2023 16:01:01 -0500 Original-Received: by mail-vk1-f169.google.com with SMTP id e10so260191vkm.11 for <60703@debbugs.gnu.org>; Sun, 19 Feb 2023 13:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oBsMUmQN/N5w/gd3GCgdP6SEKNpYOlKzVQRbrrCf1tI=; b=X5wnLyU+F+bJWcUHZrQ/1fUkB/rRHLlgy3ndAdD6nj+Ap/SVMuNYc0FzFVCd+gADjJ XYUni+XXwFPsi9lRavGPcRlt5YPodTR2HND/Vtk+VPTWjJN+z8Gj1soPSGa+ODybPx23 U9tFLcUxp/D1fWqJ+1dl3wG/w+adr1eanPBa+MJKRVFXJ3REMLzfuFtaUVw96yMdloxZ xmvl6Vr9x+HucWRnxuU2hznVK+72EvJJZb+foXlnz7rGja+dBHLHhkbxthS3ELx1p/ZU rihNi2keJGQYiL+1quuQT18vCj8YDSmf5YBM28NbArRlKG5XjekKLMwMa13hclQMn2er bz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oBsMUmQN/N5w/gd3GCgdP6SEKNpYOlKzVQRbrrCf1tI=; b=ujPvvgOPcvAymuHyPKPtTqgsA6/5v90x4F4t3ReEU0JOGvafIoe/MMp+GgGF30sQcH Y6wmjnQLZ7geJkNauTZhrlWYdFEB3rWVn71BD9TSY21lq55SCWR7IUADjuwdgbBP3yMI APzvFEHA208dTJpZn1phCQohx0OVHmModYXVRv5bSyLBwJ3A5FFEj7ScZqIuid3cTOUY KlVijnXdytWCDFL0C06gI+t+k6bWPbVxKjA6YV4yWq7if+PbIBd2kcagx2+LI4zUr9sI 9oYAQA+FftDEllz4A1Mh8qpB/8lReDE5kNTs5Qd4ZnNKLMHcpPqvPhnp4fgeQtsU//7h HZYg== X-Gm-Message-State: AO0yUKXm2kxbvYtUQTOtQe4B0sTtCYEi/y7FpUKR647Q5GsRRPCpeRQv UvpZUx8a4vc3xXLBOR0eFdIj9C5OZtV4GgA4EVA= X-Google-Smtp-Source: AK7set+kUld3BkqpAApEhABGdXbimueNE7ifaW0CbPtXtX02vlOVcZS7lnf/gB1qqlTU+q6eFeBw7ZJPvyOF6UvM7s8= X-Received: by 2002:a1f:9bd3:0:b0:401:b916:7b08 with SMTP id d202-20020a1f9bd3000000b00401b9167b08mr130267vke.13.1676840455047; Sun, 19 Feb 2023 13:00:55 -0800 (PST) In-Reply-To: <87pmb024d7.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256106 Archived-At: --000000000000ab0d4705f513d7cd Content-Type: text/plain; charset="UTF-8" Hi all, just wanted to check on this: will you be able to include my changes in Emacs-29? Don't mean to put pressure or anything, just wondering if there's any additional things you need from me, and if there's a timeline on when the changes will be in. Thanks! On Thu, Jan 26, 2023 at 7:44 PM Po Lu wrote: > Andrew De Angelis writes: > > > Thanks for the explanation. I sent out the signed copy yesterday. > > I noticed a couple things about the previous patch, so I'm sending this > one with a few updates: > > > > * `xwidget-webkit-current-url` in lisp/xwidget.el: check if the url > variable is non-nil before calling `kill-new' on it. This avoids killing an > empty > > string, which would be pointless. We still alert the user that > something's wrong by messaging "URL: nil" (although getting a nil url seems > > very unlikely). > > * in src/nsxwidget.m: formatting (keep lines below 80 char), and a brief > comment describing the purpose of some of the newly added > > functions > > > > I'm also attaching a draft of the ChangeLog. Let me know if you'd like > me to make any changes there. > > > > I do have a question about the X11/GTK implementations for xwidget. I'm > not sure I understand the relationship between the two: from the > > preprocessor macros it seems at times they are separate and at times > that one is an addendum to the other. > > I'm asking because I want to make sure I'm using the preprocessor macros > correctly: specifically, the function > > `xwidget-webkit-estimated-load-progress` within xwidget.c used to be > inside a "#ifdef USE_GTK" block. I moved it outside of the block, and > > separated the GTK implementation from the NS_IMPL_COCOA implementation. > Is this a problem for the X11 build? Should I instead put the > > whole function within a block along these lines: "#if defined USE_GTK || > defined NS_IMPL_COCOA" ? > > No, that's not a problem. The X11 implementation shares most of the > widget manipulation code with the PGTK one, so both are simply under > ``#ifdef USE_GTK''. > --000000000000ab0d4705f513d7cd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all, just wanted to check on this: will you be abl= e to include my changes in Emacs-29?
Don't mean to put pressu= re or anything, just wondering if there's any additional things you nee= d from me, and if there's a timeline on when the changes will be in.

Thanks!

On Thu, Jan 26, 2023 at 7:44 PM Po = Lu <luangruo@yahoo.com> wro= te:
Andrew De An= gelis <bobo= deangelis@gmail.com> writes:

> Thanks for the explanation. I sent out the signed copy yesterday.
> I noticed a couple things about the previous patch, so I'm sending= this one with a few updates:
>
> * `xwidget-webkit-current-url` in lisp/xwidget.el: check if the url va= riable is non-nil before calling `kill-new' on it. This avoids killing = an empty
>=C2=A0 string, which would be pointless. We still alert the user that s= omething's wrong by messaging "URL: nil" (although getting a = nil url seems
>=C2=A0 very unlikely).
> * in src/nsxwidget.m: formatting (keep lines below 80 char), and a bri= ef comment describing the purpose of some of the newly added
>=C2=A0 functions
>
> I'm also attaching a draft of the ChangeLog. Let me know if you= 9;d like me to make any changes there.
>
> I do have a question about the X11/GTK implementations for xwidget. I&= #39;m not sure I understand the relationship between the two: from the
> preprocessor macros it seems at times they are separate and at times t= hat one is an addendum to the other.
> I'm asking because I want to make sure I'm using the preproces= sor macros correctly: specifically, the function
> `xwidget-webkit-estimated-load-progress` within xwidget.c used to be i= nside a "#ifdef USE_GTK" block. I moved it outside of the block, = and
> separated the GTK implementation from the NS_IMPL_COCOA implementation= . Is this a problem for the X11 build? Should I instead put the
> whole function within a block along these lines: "#if defined USE= _GTK || defined NS_IMPL_COCOA" ?

No, that's not a problem.=C2=A0 The X11 implementation shares most of t= he
widget manipulation code with the PGTK one, so both are simply under
``#ifdef USE_GTK''.
--000000000000ab0d4705f513d7cd--