From: Andrew De Angelis <bobodeangelis@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Po Lu <luangruo@yahoo.com>, 60703@debbugs.gnu.org
Subject: bug#60703: Patches to xwidget code
Date: Tue, 10 Jan 2023 18:33:25 -0500 [thread overview]
Message-ID: <CAP5CrM1Q_R+-njQjzQopcs8wOWnp=5hOkw=Q8jny0Hb_st-ZCA@mail.gmail.com> (raw)
In-Reply-To: <837cxuo6cj.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 3127 bytes --]
Thank you both.
@Po Lu <luangruo@yahoo.com>, I will work on the changes you mentioned.
Can you clarify the C++-style comments vs C style ones? When should we use
"/* */" and when should we use "//"?
I looked around the code and it doesn't seem very consistent, but I can
help clean up the xwidget-related files.
@Eli,
> Are we sure this will not affect any important aspects
> of the build, except where we already have problems? (I don't see any
> description of the problems and their solution in the commit log or
> the comments.)
>
This should only affect builds on Mac machines, and makes it so the xwidget
feature doesn't leak memory anymore. Importantly, I do not have access to
any Linux machine, so I can't be 100% sure they're not affected. But as far
as I can tell, the changes are limited to Mac builds using the
"-with-xwidgets" feature.
I'll add a better explanation in the upcoming Change Log, but essentially,
the problems were simply memory leaks. The leaked memory wasn't a lot, so
it seldom caused noticeable issues (at least in my experience).
I'm sending my answers to the copyright questionnaire to assign@gnu.org.
This is my first contribution, so let me know if I'm missing anything.
Best,
Andrew
On Tue, Jan 10, 2023 at 8:40 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Po Lu <luangruo@yahoo.com>
> > Cc: emacs-devel@gnu.org, 60703@debbugs.gnu.org
> > Date: Tue, 10 Jan 2023 17:59:04 +0800
> >
> > > --- a/lisp/xwidget.el
> > > +++ b/lisp/xwidget.el
> > > @@ -924,8 +924,9 @@ xwidget-webkit-reload
> > > (defun xwidget-webkit-current-url ()
> > > "Display the current xwidget webkit URL and place it on the
> `kill-ring'."
> > > (interactive nil xwidget-webkit-mode)
> > > - (let ((url (xwidget-webkit-uri (xwidget-webkit-current-session))))
> > > - (message "URL: %s" (kill-new (or url "")))))
> > > + (let ((url (or (xwidget-webkit-uri
> (xwidget-webkit-current-session)) "")))
> > > + (kill-new url)
> > > + (message "URL: %s" url)))
> > >
> > > (defun xwidget-webkit-browse-history ()
> > > "Display a buffer containing the history of page loads."
> >
> > This change is fine for Emacs 29.1. Eli, WDYT?
>
> Fine by me.
>
> > These changes are also fine for Emacs 29, but the TODO seems excessive.
> > Eli, any comments here?
>
> I don't have an opinion, so if it's OK in your opinion, I'm fine with
> adding this. Are we sure this will not affect any important aspects
> of the build, except where we already have problems? (I don't see any
> description of the problems and their solution in the commit log or
> the comments.)
>
> > All in all, all your changes are fine for Emacs 29 by me. What they
> > need is a proper commit message. See the node "Style of Change Logs" in
> > the GNU Coding Standards for examples of how to do this:
> >
> > https://www.gnu.org/prep/standards/standards.html#Style-of-Change-Logs
>
> I don't see copyright assignment for Andrew, so this should be settled
> before accepting the contribution of this magnitude.
>
> > Thanks again for working on Emacs.
>
> Seconded.
>
> P.S. Please don't cross-post to emacs-devel.
>
[-- Attachment #2: Type: text/html, Size: 4944 bytes --]
next prev parent reply other threads:[~2023-01-10 23:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 5:14 bug#60703: Patches to xwidget code Andrew De Angelis
2023-01-10 9:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87cz7mhfrr.fsf@yahoo.com>
2023-01-10 13:40 ` Eli Zaretskii
2023-01-10 23:33 ` Andrew De Angelis [this message]
2023-01-11 1:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-21 6:13 ` Andrew De Angelis
2023-01-21 7:16 ` Eli Zaretskii
2023-01-21 15:32 ` Andrew De Angelis
2023-01-21 15:41 ` Eli Zaretskii
2023-01-26 23:45 ` Andrew De Angelis
2023-01-27 0:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 21:00 ` Andrew De Angelis
2023-02-20 2:41 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 11:47 ` Eli Zaretskii
2023-02-21 5:24 ` Andrew De Angelis
2023-02-22 13:27 ` Eli Zaretskii
2023-02-24 3:47 ` Andrew De Angelis
2023-03-02 10:57 ` Eli Zaretskii
2023-03-04 23:00 ` Andrew De Angelis
2023-03-05 0:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP5CrM1Q_R+-njQjzQopcs8wOWnp=5hOkw=Q8jny0Hb_st-ZCA@mail.gmail.com' \
--to=bobodeangelis@gmail.com \
--cc=60703@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).