From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chris Feng Newsgroups: gmane.emacs.bugs Subject: bug#22817: 25.0.91; [PATCH] Include versioned preloaded libraries in `package--builtin-versions' Date: Tue, 12 Jul 2016 23:03:53 +0800 Message-ID: References: <86r3fzy7ea.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1468336307 8668 80.91.229.3 (12 Jul 2016 15:11:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 15:11:47 +0000 (UTC) Cc: 22817@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 12 17:11:32 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMzLI-0005Xm-Mf for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 17:11:24 +0200 Original-Received: from localhost ([::1]:41158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMzLH-0004Rr-UP for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 11:11:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMzFC-0006X8-9m for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 11:05:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMzF8-0008Vu-K7 for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 11:05:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMzF8-0008Vq-H8 for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 11:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bMzF8-0005tg-8Y for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 11:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chris Feng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 15:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22817 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22817-submit@debbugs.gnu.org id=B22817.146833584222577 (code B ref 22817); Tue, 12 Jul 2016 15:05:02 +0000 Original-Received: (at 22817) by debbugs.gnu.org; 12 Jul 2016 15:04:02 +0000 Original-Received: from localhost ([127.0.0.1]:48483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMzE9-0005rz-VW for submit@debbugs.gnu.org; Tue, 12 Jul 2016 11:04:02 -0400 Original-Received: from mail-wm0-f53.google.com ([74.125.82.53]:37532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMzE7-0005re-SR for 22817@debbugs.gnu.org; Tue, 12 Jul 2016 11:04:00 -0400 Original-Received: by mail-wm0-f53.google.com with SMTP id i5so29163774wmg.0 for <22817@debbugs.gnu.org>; Tue, 12 Jul 2016 08:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=45NwiKluXR9kT1uJHbxEn5n44wyjsXqEN3PXir24Hyo=; b=Tn12g8nuicwfbYTgxlwLGNkFzKsRFXD0RsljQyVxTyLGSLvYB0W9u5ccCX9iubzFwf w/TSL5kpCI+5lv0kh34ECwpgLhnxke+fzpAXBaQbWwiney1y41LVNtebUvlpBHdIWddp 8uyrIKD/hbDaRDaY9dpA5cI19i1gHJ04rmKa437EXdTDMYpYpHIII98kWaHEbKncEPY/ NETOVME5wfQRLEOa1Vm503Mx0jyBohpkzIGGxiSRhH7CLE55CSydDKOJhN8uzMPTBURs rOqaZbHsY6tX0cZ9hMR0+eOA8bO7IFXr+GXBEBC0CabAPwJmRA9JtT/B6qwVm/4JFS1+ x2Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=45NwiKluXR9kT1uJHbxEn5n44wyjsXqEN3PXir24Hyo=; b=KizsShaz1bCww3yF3ACg9o/O1v/lri+z3/16v2dhFh2O1Peqk6pq2BVisF3+qB6qpB I4LDCVhDdJCfgf7KnvZQXod6r0Nel4JRSsLUMA2bx7Jg5XF3Y/0UBSec0GbKPft3mVk8 S4D86sTY6ybch/xOseSQXPTNZ/f6rHd1SKqIID4h38dNHzM0t8HHhcIESl1QJsy7Sx2W MVslwhj9Urpa8MMi48MrJ+4gzss0ixRC0gfQ9e3aFdwsPAhBjmoe1guLWKZEgBLmGDQL 2DX+tBWY59IdbWltiiOKO5WhskiycpV7rsXACSuBof57aL367x9wDTbpsjxdXPeoum9f I2Mw== X-Gm-Message-State: ALyK8tK/o3VrOnFVV7pQ7Q0GyMwkpFf42iX29Q0H2m3mi9c1+0FAPq63RSWFUUiAekkCSWIREF3SNk+p0zTMDA== X-Received: by 10.28.125.80 with SMTP id y77mr3996469wmc.25.1468335834075; Tue, 12 Jul 2016 08:03:54 -0700 (PDT) Original-Received: by 10.194.97.20 with HTTP; Tue, 12 Jul 2016 08:03:53 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120917 Archived-At: >>>> Also, since `package--builtin-versions' is now complete, should we >>>> remove the version info in `package--builtins'? >>> Not sure what you mean nor what would be the benefit. >> I just noticed you wrote this in finder.el: >> ;; FIXME: Now that we have package--builtin-versions, package--builtins >> ;; is only needed to get the list of unversioned packages and to get the >> ;; summary description of each package. > > Yes, but that still doesn't tell me what you suggest we do ;-) I think we can simply drop the version info in `package--builtins' / `package--bi-desc' so as to eliminate duplicated info and prevent future confusion. Also the variables are only used in a few places so it'd be easy to make the change. >>> How 'bout you install your patch into master and we install the patch >>> below into emacs-25? >> That'd be okay. > > Eli? John? Chris