From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#23205: 25.0.92; sort-tests is flaky Date: Wed, 06 Apr 2016 11:34:10 +0000 Message-ID: References: <5704C94B.7050900@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113fc420bb8b11052fcf5724 X-Trace: ger.gmane.org 1459942524 12809 80.91.229.3 (6 Apr 2016 11:35:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Apr 2016 11:35:24 +0000 (UTC) Cc: 23205-done@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 06 13:35:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1anljt-0003fE-Fo for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Apr 2016 13:35:13 +0200 Original-Received: from localhost ([::1]:42488 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anljs-0004XV-TE for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Apr 2016 07:35:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anljn-0004Ug-MO for bug-gnu-emacs@gnu.org; Wed, 06 Apr 2016 07:35:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anlji-0006tx-NH for bug-gnu-emacs@gnu.org; Wed, 06 Apr 2016 07:35:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anlji-0006tk-Jc for bug-gnu-emacs@gnu.org; Wed, 06 Apr 2016 07:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1anlji-0005O1-F0 for bug-gnu-emacs@gnu.org; Wed, 06 Apr 2016 07:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Apr 2016 11:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23205-done@debbugs.gnu.org id=D23205.145994246820659 (code D ref 23205); Wed, 06 Apr 2016 11:35:02 +0000 Original-Received: (at 23205-done) by debbugs.gnu.org; 6 Apr 2016 11:34:28 +0000 Original-Received: from localhost ([127.0.0.1]:51063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anljA-0005N9-8Z for submit@debbugs.gnu.org; Wed, 06 Apr 2016 07:34:28 -0400 Original-Received: from mail-lf0-f43.google.com ([209.85.215.43]:36515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anlj8-0005Mv-8A for 23205-done@debbugs.gnu.org; Wed, 06 Apr 2016 07:34:26 -0400 Original-Received: by mail-lf0-f43.google.com with SMTP id g184so31555593lfb.3 for <23205-done@debbugs.gnu.org>; Wed, 06 Apr 2016 04:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QpxWp6dyPSoRi6CozeXQBD1IepOU0urhlkOupPpQ2b4=; b=ZZ4KhICfSTrQFe8sDDTfjeIxYI9cIvfg2SVvhiiDyrckg/o26r0n4IyDMew0K3Wsow LTppuwulr3L2EwFk4/Rdmz40KSSHvVbHtoNVBUifo6yehHrb1zCNR1gILGv5wQVxYpPq JjHy+4u7j9xREovQMSJ5S9dHAR0vBGj7NMuzQlLPDjP2cWYORjDgV3oXqeRjgZ77QWhf AoqZ9cQxKhV0QD0LzbV9zsHPUjfNqUQZSeI0NN6YN22xTj+8JU/xO7AKnE9pulsSjdmc E9KSZhGmutiOFbgkz3mo4Pw9XNQ2mAy8bXahB5jGyQIdUQTNfcqOQQRW+O7UgABxtsQZ A3ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QpxWp6dyPSoRi6CozeXQBD1IepOU0urhlkOupPpQ2b4=; b=i3wdNbVqpeyEnzFaUwolYnMZ4A0AMQEaeqFQrHuFDSMCgbCjtX9g+MsQ+GyGlxj5gH S0Q8NQmNV1nzYvMOpXYmI8TUQ1qkHnScqw3FvQJ/f2JbMgof6jmYhgWlFeeVtnahAGWy rr8Rxbz2cIpHXPCsnmG5TL3OR6fJcPd7wzOQOHdEXSb84IZ6r7w58/R+YNNvwMUyJfeA IEPfMTZQJYIVB1sKrNM74W6Owrb9X3fl3sexmBh7Xr++KfBgXfSRmPkrkskWGdeGNCc4 awrNHIp/yaGDzsp6AAgsMLiQkp60MfTx2EsklGljZXzNTIamJuCxpkW7L/Yw6hmzN0nf EUZg== X-Gm-Message-State: AD7BkJIuM5cQ0L5rFp6rJOb6Q6M+kfk7a7/QE/3jNdgA0SCFgOkGUsqb/susdXY11oQtD2xRtRiFIDqZZ3ikzDB4 X-Received: by 10.25.18.68 with SMTP id h65mr10235853lfi.151.1459942460167; Wed, 06 Apr 2016 04:34:20 -0700 (PDT) In-Reply-To: <5704C94B.7050900@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:116108 Archived-At: --001a113fc420bb8b11052fcf5724 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, Apr 6, 2016 at 10:31 AM Paul Eggert wrote: > > Either the sorting should > > be made stable, or the test shouldn't assume stable sorting. > > GNU Emacs's sorting is stable, but some sorting code in the test case is > wrong, > and the random tests that trigger the test-case bug occur only with a sma= ll > probability. I installed the attached to fix the test-case bug. Thanks fo= r > reporting the details; it would have taken a while for me to track it dow= n > without that useful clue involving Zi and zI. > Thanks for the quick fix; confirmed that the test is no longer flaky. --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und l=C3=B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. --001a113fc420bb8b11052fcf5724 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Wed= , Apr 6, 2016 at 10:31 AM Paul Eggert <eggert@cs.ucla.edu> wrote:
> Either the sorting should
> be made stable, or the test shouldn't assume stable sorting.

GNU Emacs's sorting is stable, but some sorting code in the test case i= s wrong,
and the random tests that trigger the test-case bug occur only with a small=
probability. I installed the attached to fix the test-case bug. Thanks for<= br> reporting the details; it would have taken a while for me to track it down<= br> without that useful clue involving Zi and zI.

Thanks for the quick fix; confirmed that the test is no longer flaky= .=C2=A0
--

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe 33
80636 M=C3=BCnchen

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Gesch=C3=A4ftsf=C3=BChrer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Ad= ressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absen= der und l=C3=B6schen Sie die E-Mail und alle Anh=C3=A4nge. Vielen Dank.

This e-mail is confidential. If you are not the right addres= see please do not forward it, please inform the sender, and please erase th= is e-mail including any attachments. Thanks.

--001a113fc420bb8b11052fcf5724--