From: Philipp Stephani <phst@google.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 23205-done@debbugs.gnu.org
Subject: bug#23205: 25.0.92; sort-tests is flaky
Date: Wed, 06 Apr 2016 11:34:10 +0000 [thread overview]
Message-ID: <CAP-RRPvQv9NakiFsZQnx6dDmEPtRzy9KgfVfbzRbTSTT87KYdQ@mail.gmail.com> (raw)
In-Reply-To: <5704C94B.7050900@cs.ucla.edu>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
On Wed, Apr 6, 2016 at 10:31 AM Paul Eggert <eggert@cs.ucla.edu> wrote:
> > Either the sorting should
> > be made stable, or the test shouldn't assume stable sorting.
>
> GNU Emacs's sorting is stable, but some sorting code in the test case is
> wrong,
> and the random tests that trigger the test-case bug occur only with a small
> probability. I installed the attached to fix the test-case bug. Thanks for
> reporting the details; it would have taken a while for me to track it down
> without that useful clue involving Zi and zI.
>
Thanks for the quick fix; confirmed that the test is no longer flaky.
--
Google Germany GmbH
Erika-Mann-Straße 33
80636 München
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.
[-- Attachment #2: Type: text/html, Size: 1633 bytes --]
prev parent reply other threads:[~2016-04-06 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 10:30 bug#23205: 25.0.92; sort-tests is flaky Philipp Stephani
2016-04-03 14:57 ` Eli Zaretskii
2016-04-03 21:00 ` Philipp Stephani
2016-04-04 2:33 ` Eli Zaretskii
2016-04-04 16:29 ` Philipp Stephani
2016-04-06 8:31 ` Paul Eggert
2016-04-06 11:34 ` Philipp Stephani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP-RRPvQv9NakiFsZQnx6dDmEPtRzy9KgfVfbzRbTSTT87KYdQ@mail.gmail.com \
--to=phst@google.com \
--cc=23205-done@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).