unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <phst@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23101@debbugs.gnu.org
Subject: bug#23101:
Date: Thu, 24 Mar 2016 18:37:34 +0000	[thread overview]
Message-ID: <CAP-RRPtsNh-jovC_01JpUoyUvuHT7XfhQgwKApTw_mG2HOaUUw@mail.gmail.com> (raw)
In-Reply-To: <83wpor21hu.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]

On Thu, Mar 24, 2016 at 7:08 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Philipp Stephani <phst@google.com>
> > Date: Thu, 24 Mar 2016 09:45:33 +0000
> >
> > Minimal reproduction:
> >
> > (with-temp-buffer
> >   (let ((last-nonmenu-event nil)
> > (use-dialog-box t)
> > (oldbuf (current-buffer)))
> >     (yes-or-no-p "")
> >     (cl-assert (equal oldbuf (current-buffer)))))
> >
> > Seems that yes-or-no-p switches buffers when the dialog box is used.
>
> Thanks, I think I fixed this on the emacs-25 branch.
>

Thanks for fixing, but please note that your fix relies on
make_save_ptr_ptr, which is conditionally defined:

#if ! (defined USE_X_TOOLKIT || defined USE_GTK)
Lisp_Object
make_save_ptr_ptr (void *a, void *b)

Most likely that #if should just be removed.
-- 

Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.

This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.

[-- Attachment #2: Type: text/html, Size: 2002 bytes --]

  reply	other threads:[~2016-03-24 18:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 19:50 bug#23101: 25.1; Error when visiting a symlink to a VC-controlled file on the command line Philipp Stephani
2016-03-24  9:45 ` bug#23101: Philipp Stephani
2016-03-24 18:07   ` bug#23101: Eli Zaretskii
2016-03-24 18:37     ` Philipp Stephani [this message]
2016-03-24 18:53       ` bug#23101: Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP-RRPtsNh-jovC_01JpUoyUvuHT7XfhQgwKApTw_mG2HOaUUw@mail.gmail.com \
    --to=phst@google.com \
    --cc=23101@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).