From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christoph Newsgroups: gmane.emacs.bugs Subject: bug#16254: 24.3.50; bzr error on emacs trunk using vc-print-log Date: Wed, 25 Dec 2013 11:35:27 -0700 Message-ID: References: <87d2kk4zcn.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b3441fafa41f104ee601fd7 X-Trace: ger.gmane.org 1387996574 988 80.91.229.3 (25 Dec 2013 18:36:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Dec 2013 18:36:14 +0000 (UTC) To: 16254@debbugs.gnu.org, Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 25 19:36:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VvtJY-0000fe-JQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2013 19:36:16 +0100 Original-Received: from localhost ([::1]:43186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvtJY-0005K5-0P for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2013 13:36:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvtJP-0005Jx-8f for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 13:36:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvtJK-0003XT-73 for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 13:36:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvtJK-0003XP-43 for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 13:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VvtJJ-0007oB-LJ for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 13:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Christoph Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Dec 2013 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16254 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16254-submit@debbugs.gnu.org id=B16254.138799653129951 (code B ref 16254); Wed, 25 Dec 2013 18:36:01 +0000 Original-Received: (at 16254) by debbugs.gnu.org; 25 Dec 2013 18:35:31 +0000 Original-Received: from localhost ([127.0.0.1]:41720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvtIp-0007n1-Ad for submit@debbugs.gnu.org; Wed, 25 Dec 2013 13:35:31 -0500 Original-Received: from mail-lb0-f182.google.com ([209.85.217.182]:49236) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvtIm-0007mi-Rv for 16254@debbugs.gnu.org; Wed, 25 Dec 2013 13:35:29 -0500 Original-Received: by mail-lb0-f182.google.com with SMTP id l4so3443512lbv.27 for <16254@debbugs.gnu.org>; Wed, 25 Dec 2013 10:35:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=8KisYbKJQwh2rwNCpaRdnnwLCeNTB+qhLSu6Wy4NRCU=; b=nWTcNRHCF5iOURU5HGOOwgBvUVWnOvm9XaIRf5HvUC5CGWGX3jRcYnIZNpzKJS9N+u WeAiOwdDvXV8JLtTalVfbbR12dlzXFYGN1vCGb9OveYD1gOQR94uKiKhXjh3sw2BKhWq l6IxpFX5vUb4IXPh+5/ioYysMRQJNlAuSkMeiB+lw5aYnoWL8ohIBN/M8Ja7IIeJHEgc 3nxVaOXCqbP6WzEFk8ofS71XOkUGes2tGCDs6zOzUxrbPoC4sTbFsOqAS+T+O7rmt4K5 Y1htuLGdk2cm1pWU8bVbIN9iBI/GFX7ZW8TSz32ZYXpb+6T0BQfcMDjhUtb3R5GQJwmw DNdg== X-Received: by 10.112.128.194 with SMTP id nq2mr11146lbb.84.1387996527606; Wed, 25 Dec 2013 10:35:27 -0800 (PST) Original-Received: by 10.152.133.66 with HTTP; Wed, 25 Dec 2013 10:35:27 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82597 Archived-At: --047d7b3441fafa41f104ee601fd7 Content-Type: text/plain; charset=ISO-8859-1 I was wrong. The t argument in vc-deduce-fileset does something else. Sorry for the noise. On Wed, Dec 25, 2013 at 11:22 AM, Christoph wrote: > vc-print-log was executed from a dired buffer when this happened. > vc-print-root-log works correctly and prints the Emacs bzr logs. > > vc.el has the following code in vc-print-log: > > (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef > (backend (car vc-fileset)) > (files (cadr vc-fileset)) > ;; (working-revision (or working-revision (vc-working-revision (car > files)))) > ) > (vc-print-log-internal backend files working-revision nil limit))) > > The t in vc-decude-fileset allows unregistered files per the > documentation. To follow Stefan's questions, why would we want unregistered > files to be included in the fileset for the log command? > > I think this should be changed to disallow unregistered files. > > Christoph > > > On Wed, Dec 25, 2013 at 10:54 AM, Christoph wrote: > >> Some more information on this issue: >> >> `vc-print-log` works find in a sub-directory of the tree, e.g. admin. >> It looks like aclocal.m4 is ignored via .bzrignore and it is the first >> file in the root tree (after running configure and such). >> >> I seem to remember we had a similar problem before that was fixed at some >> point. >> >> >> On Wed, Dec 25, 2013 at 10:25 AM, Christoph wrote: >> >>> >>> Running `vc-print-log` on a directory containing the Emacs trunk gives >>> the following error: >>> >>> bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4 >>> >>> >>> >>> In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) >>> of 2013-12-14 on marvin >>> Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i >>> Windowing system distributor `The X.Org Foundation', version >>> 11.0.11103000 >>> System Description: Linux Mint 13 Maya >>> >> >> > --047d7b3441fafa41f104ee601fd7 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I was wrong. The t argument in vc-deduce-fileset does some= thing else.=A0Sorry for the noise.



On Wed, Dec 25, 2013 at 11:22 AM,= Christoph <cschol2112@gmail.com> wrote:
vc-print-log was executed f= rom a dired buffer when this happened. vc-print-root-log works correctly an= d prints the Emacs bzr logs.

vc.el has the following code in vc-print-log:

=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t?= --Stef
(backend (c= ar vc-fileset))
(fi= les (cadr vc-fileset))
;; (working-revision (or = working-revision (vc-working-revision (car files))))
=A0 =A0 =A0 = =A0 =A0)
=A0 =A0 (vc-print-log-internal backend files working-rev= ision nil limit)))

The t in vc-decude-fileset = allows unregistered files per the documentation. To follow Stefan's que= stions, why would we want unregistered files to be included in the fileset = for the log command?

I think thi= s should be changed to disallow unregistered files.

Christoph


On Wed, Dec 25, 2013 at 10:54 AM, Christ= oph <cschol2112@gmail.com> wrote:
Some more information on this issue:=A0

`vc-print-log` works find in a sub-directory of the tree, e.g. admin.
= It looks like aclocal.m4 is ignored via .bzrignore and it is the first file= in the root tree (after running configure and such).

I seem to remember we had a similar problem before that= was fixed at some point.
<= br>
On Wed, Dec 25, 2013 at 10:25 AM, Christo= ph <cschol2112@gmail.com> wrote:

Running `vc-print-log` on a directory containing the Emacs trunk gives
the following error:

bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4



In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
=A0of 2013-12-14 on marvin
Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i
Windowing system distributor `The X.Org Foundation', version 11.0.11103= 000
System Description: =A0 =A0 Linux Mint 13 Maya



--047d7b3441fafa41f104ee601fd7--