From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christoph Newsgroups: gmane.emacs.bugs Subject: bug#16254: 24.3.50; bzr error on emacs trunk using vc-print-log Date: Wed, 25 Dec 2013 11:22:41 -0700 Message-ID: References: <87d2kk4zcn.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e011827f64e475504ee5ff2b0 X-Trace: ger.gmane.org 1387995792 27133 80.91.229.3 (25 Dec 2013 18:23:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Dec 2013 18:23:12 +0000 (UTC) To: 16254@debbugs.gnu.org, Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 25 19:23:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vvt6y-0005b4-Aw for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2013 19:23:16 +0100 Original-Received: from localhost ([::1]:43169 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvt6x-0003Bz-OX for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2013 13:23:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvt6p-0003Br-6j for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 13:23:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vvt6k-0000Yq-4m for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 13:23:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvt6j-0000Yl-Vx for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 13:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vvt6j-0007MR-Ms for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 13:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Christoph Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Dec 2013 18:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16254 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16254-submit@debbugs.gnu.org id=B16254.138799576528268 (code B ref 16254); Wed, 25 Dec 2013 18:23:01 +0000 Original-Received: (at 16254) by debbugs.gnu.org; 25 Dec 2013 18:22:45 +0000 Original-Received: from localhost ([127.0.0.1]:41696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvt6S-0007Lr-Lz for submit@debbugs.gnu.org; Wed, 25 Dec 2013 13:22:45 -0500 Original-Received: from mail-la0-f44.google.com ([209.85.215.44]:51598) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvt6Q-0007Lj-IM for 16254@debbugs.gnu.org; Wed, 25 Dec 2013 13:22:43 -0500 Original-Received: by mail-la0-f44.google.com with SMTP id ep20so3438418lab.31 for <16254@debbugs.gnu.org>; Wed, 25 Dec 2013 10:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=jGuh7ct1u3w0bAvSOWKQ/Vor43+kBl2wLgnA80UCj34=; b=bWphJTMPTP30LcfP8rlM6SpToo3AfejkxM7zjTNf9RH2zReM6SPlzcYbAeuALEponp eWPcLvw3K5hvpdYbs3FqzpZt5u2LZTTqz42gbQFOr76fGZu8sfYor7SVkUAZoiXBdru0 ubaBfnwxCEaF+R3l9s1++pIJ0DZMcoofliqenphnMfqyFBEZwp024jZiYAIR4bL3+wtU Sm+PVUi+lwPA2Tw46dpT9/HzGZTykVPD3HkBfAq6GOGIuwLgQzFy2R3p1xaTigJxyzoc YA3LecyWFyMCpiomLwpBEPMfmTFF2huosn8/vPrbAKS3Z+TxTJho1G7TkYyb+BaImsxC sn3Q== X-Received: by 10.112.135.67 with SMTP id pq3mr600624lbb.65.1387995761361; Wed, 25 Dec 2013 10:22:41 -0800 (PST) Original-Received: by 10.152.133.66 with HTTP; Wed, 25 Dec 2013 10:22:41 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82596 Archived-At: --089e011827f64e475504ee5ff2b0 Content-Type: text/plain; charset=ISO-8859-1 vc-print-log was executed from a dired buffer when this happened. vc-print-root-log works correctly and prints the Emacs bzr logs. vc.el has the following code in vc-print-log: (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef (backend (car vc-fileset)) (files (cadr vc-fileset)) ;; (working-revision (or working-revision (vc-working-revision (car files)))) ) (vc-print-log-internal backend files working-revision nil limit))) The t in vc-decude-fileset allows unregistered files per the documentation. To follow Stefan's questions, why would we want unregistered files to be included in the fileset for the log command? I think this should be changed to disallow unregistered files. Christoph On Wed, Dec 25, 2013 at 10:54 AM, Christoph wrote: > Some more information on this issue: > > `vc-print-log` works find in a sub-directory of the tree, e.g. admin. > It looks like aclocal.m4 is ignored via .bzrignore and it is the first > file in the root tree (after running configure and such). > > I seem to remember we had a similar problem before that was fixed at some > point. > > > On Wed, Dec 25, 2013 at 10:25 AM, Christoph wrote: > >> >> Running `vc-print-log` on a directory containing the Emacs trunk gives >> the following error: >> >> bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4 >> >> >> >> In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) >> of 2013-12-14 on marvin >> Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i >> Windowing system distributor `The X.Org Foundation', version 11.0.11103000 >> System Description: Linux Mint 13 Maya >> > > --089e011827f64e475504ee5ff2b0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
vc-print-log was executed from a dired buffer when this ha= ppened. vc-print-root-log works correctly and prints the Emacs bzr logs.
vc.el has the following code in vc-print-log:

=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t?= --Stef
(back= end (car vc-fileset))
= (files (cadr vc-fileset))
;; (working-revisio= n (or working-revision (vc-working-revision (car files))))
=A0 = =A0 =A0 =A0 =A0)
=A0 =A0 (vc-print-log-internal backend files wor= king-revision nil limit)))

The t in vc-decude-fileset = allows unregistered files per the documentation. To follow Stefan's que= stions, why would we want unregistered files to be included in the fileset = for the log command?

I think thi= s should be changed to disallow unregistered files.

Christoph


On Wed, Dec 25, 2013 at 10:54 AM, Christ= oph <cschol2112@gmail.com> wrote:
Some more information on this issue:=A0

`vc-print-log` works find in a sub-directory of the tree, e.g. admin.
= It looks like aclocal.m4 is ignored via .bzrignore and it is the first file= in the root tree (after running configure and such).

I seem to remember we had a similar problem before that= was fixed at some point.
<= br>
On Wed, Dec 25, 2013 at 10:25 AM, Christo= ph <cschol2112@gmail.com> wrote:

Running `vc-print-log` on a directory containing the Emacs trunk gives
the following error:

bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4



In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
=A0of 2013-12-14 on marvin
Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i
Windowing system distributor `The X.Org Foundation', version 11.0.11103= 000
System Description: =A0 =A0 Linux Mint 13 Maya


--089e011827f64e475504ee5ff2b0--