From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#6074: accept-process-output on listening sockets cause non-interruptible infloop Date: Mon, 22 Jul 2019 17:45:18 +0000 Message-ID: References: <83imruqh62.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000d5745a058e48a5ef" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="40933"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 6074@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 22 19:47:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpcP8-000AVA-Kj for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jul 2019 19:47:18 +0200 Original-Received: from localhost ([::1]:36436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpcP7-0004WF-40 for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Jul 2019 13:47:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56645) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpcP3-0004Vj-Ic for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2019 13:47:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpcOy-0002Sj-Lz for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2019 13:47:13 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53006) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hpcOs-0002RI-NS for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2019 13:47:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hpcOs-0005Du-GH for bug-gnu-emacs@gnu.org; Mon, 22 Jul 2019 13:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Jul 2019 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 6074-submit@debbugs.gnu.org id=B6074.156381756219942 (code B ref 6074); Mon, 22 Jul 2019 17:47:02 +0000 Original-Received: (at 6074) by debbugs.gnu.org; 22 Jul 2019 17:46:02 +0000 Original-Received: from localhost ([127.0.0.1]:33594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpcNu-0005BT-0k for submit@debbugs.gnu.org; Mon, 22 Jul 2019 13:46:02 -0400 Original-Received: from mail-ot1-f41.google.com ([209.85.210.41]:33727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpcNs-0005B6-BQ for 6074@debbugs.gnu.org; Mon, 22 Jul 2019 13:46:00 -0400 Original-Received: by mail-ot1-f41.google.com with SMTP id q20so41078049otl.0 for <6074@debbugs.gnu.org>; Mon, 22 Jul 2019 10:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/HoWjLKHNi1MlRG9o0icAu8bAkMfNL6W1vc0FcCPQy0=; b=GnoRM7U3DCiD5qJ+tFBgTovAfdi8JGERBMpokP19g6qjfnRO5G2I5UqK/2L9egIJr0 tnCTiUv8UgARZmXzQpuW7YaL7WUazxQrFA05lKcWipZouKR6ymmeeZOUNomxGkG/hefF 4oprQcZ6hHXN4xrAIwnLAX8MhZwtwKYE+z2O1wJirvsv/IX68gQjF9S0cy1sUwiBG/iD vI30Y93qnJX4XmCcMCrEsVcEqV3g38Xl1GFbJ4TaZUiXJqdL1WSAmHZ7mIUAuGW+j9kP fxlUJb2Cg9q6ip5SBS60ivychg1adRs+q7NNoi7LU27yTeGji6KJ0nfVi9o3cDl8BYxS LEDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/HoWjLKHNi1MlRG9o0icAu8bAkMfNL6W1vc0FcCPQy0=; b=aLHdllaWWzL2bY6a1qVhQEiR9STPRDInxp6RwQzqR6LXZ/HxOjmCTh2OOwBOHIUke0 R4Goewp9DCVJXsruA9XEORUuAc0nZwTWpC6l+yPx0OSYPOZGQ4oruIZNYWJvAkLwrBRO k9CFLAVbpBsgJ9UgQfSVaWgBjRmL/3fzm9ullHsMU3gxzuMnWWBq5vAZKHatra725HFr 449GpbKiF8qxCsdQFl7yLfsMxi/W1JpnR2YiirOaZ77uLEYrIeCKvUQR1PIY39re46DM qfYkUJZWxo9cMbjoaTdzZCMZxak2aRFNfmw3W9TDvsv59g2p6X+lLVvQn9TjIt4TWxE2 LNZA== X-Gm-Message-State: APjAAAUe6mVxmV1x2dCrYLwsTIoh5XydWnbfpxmwC6FqAzGN6dvbIivC IUTJxuUKQ/HIXa7RDcVU9VjBdLFhWQNlkHjK+I0oNQ== X-Google-Smtp-Source: APXvYqy4ulGeOyYjNAhViM7SNQ4ArzNqw3F0t9U1eBhQVbcLW0rr4KsIRlX2g7TMMp9R10Az9RQVqDKUuXtbnbcHdF0= X-Received: by 2002:a9d:6014:: with SMTP id h20mr19207244otj.210.1563817554564; Mon, 22 Jul 2019 10:45:54 -0700 (PDT) In-Reply-To: <83imruqh62.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163604 Archived-At: --000000000000d5745a058e48a5ef Content-Type: text/plain; charset="UTF-8" On Mon, Jul 22, 2019 at 2:26 PM Eli Zaretskii wrote: > > > From: Pip Cet > > Date: Mon, 22 Jul 2019 03:52:33 +0000 > > > > diff --git a/src/process.c b/src/process.c > > index abadabe77e..1311409274 100644 > > --- a/src/process.c > > +++ b/src/process.c > > @@ -5277,7 +5277,9 @@ wait_reading_process_output (intmax_t time_limit, int nsecs, int read_kbd, > > int nread = read_process_output (proc, wait_proc->infd); > > if (nread < 0) > > { > > - if (errno == EIO || would_block (errno)) > > + if (errno == EINTR) > > + continue; > > + else > > break; > > } > > else > > Isn't it better to simply call rarely_quit inside the loop? Why would we try again after receiving EINVAL? I believe the right behavior is to return immediately in this case, just as we do for EIO. However, we should probably call rarely_quit inside the loop, anyway, to catch the case of a kernel bug keeping us busy with EINTRs. How's this? --000000000000d5745a058e48a5ef Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-retry-reading-after-receiving-EINVAL-bug-6074.patch" Content-Disposition: attachment; filename="0001-Don-t-retry-reading-after-receiving-EINVAL-bug-6074.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jyeojwiy0 RnJvbSBhODk5MWNjYzFlODQ2YWVkOWE4ZjFiYTBlYmNkMjc3MWI2MjNmMjQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBNb24s IDIyIEp1bCAyMDE5IDAzOjQ5OjU0ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRG9uJ3QgcmV0cnkg cmVhZGluZyBhZnRlciByZWNlaXZpbmcgRUlOVkFMIChidWcjNjA3NCkKCiogc3JjL3Byb2Nlc3Mu YyAod2FpdF9yZWFkaW5nX3Byb2Nlc3Nfb3V0cHV0KTogRG9uJ3QgcmV0cnkgcmVhZGluZwpmcm9t IGFuIGZkIGFmdGVyIGFuIHVua25vd24gZXJyb3IuCi0tLQogc3JjL3Byb2Nlc3MuYyB8IDQgKysr LQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAt LWdpdCBhL3NyYy9wcm9jZXNzLmMgYi9zcmMvcHJvY2Vzcy5jCmluZGV4IGFiYWRhYmU3N2UuLjkx MDRhMzkyYzggMTAwNjQ0Ci0tLSBhL3NyYy9wcm9jZXNzLmMKKysrIGIvc3JjL3Byb2Nlc3MuYwpA QCAtNTI3MCwxNCArNTI3MCwxNiBAQCB3YWl0X3JlYWRpbmdfcHJvY2Vzc19vdXRwdXQgKGludG1h eF90IHRpbWVfbGltaXQsIGludCBuc2VjcywgaW50IHJlYWRfa2JkLAogCSAgLyogSWYgZGF0YSBj YW4gYmUgcmVhZCBmcm9tIHRoZSBwcm9jZXNzLCBkbyBzbyB1bnRpbCBleGhhdXN0ZWQuICAqLwog CSAgaWYgKHdhaXRfcHJvYy0+aW5mZCA+PSAwKQogCSAgICB7CisJICAgICAgdW5zaWduZWQgaW50 IGNvdW50ID0gMDsKIAkgICAgICBYU0VUUFJPQ0VTUyAocHJvYywgd2FpdF9wcm9jKTsKIAogCSAg ICAgIHdoaWxlICh0cnVlKQogCQl7CiAJCSAgaW50IG5yZWFkID0gcmVhZF9wcm9jZXNzX291dHB1 dCAocHJvYywgd2FpdF9wcm9jLT5pbmZkKTsKKwkJICByYXJlbHlfcXVpdCAoKytjb3VudCk7CiAJ CSAgaWYgKG5yZWFkIDwgMCkKIAkJICAgIHsKLQkJICAgICAgaWYgKGVycm5vID09IEVJTyB8fCB3 b3VsZF9ibG9jayAoZXJybm8pKQorCQkgICAgICBpZiAoZXJybm8gIT0gRUlOVFIpCiAJCQlicmVh azsKIAkJICAgIH0KIAkJICBlbHNlCi0tIAoyLjIyLjAKCg== --000000000000d5745a058e48a5ef--