From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36337: 26.1; XBM images are sometimes not displayed correctly Date: Sat, 29 Jun 2019 07:20:26 +0000 Message-ID: References: <83tvcgml2s.fsf@gnu.org> <83o92omezr.fsf@gnu.org> <83blyii1kr.fsf@gnu.org> <8336jtj2xo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000cabde9058c713c8e" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="265138"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36337@debbugs.gnu.org, triska@metalevel.at To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 29 09:22:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hh7gZ-0016rQ-46 for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2019 09:22:11 +0200 Original-Received: from localhost ([::1]:38108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hh7gX-00008E-Hb for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jun 2019 03:22:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41851) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hh7gR-000082-Nd for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:22:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hh7gQ-0005xU-8o for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58029) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hh7gQ-0005xK-4x for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hh7gP-0002xd-UC for bug-gnu-emacs@gnu.org; Sat, 29 Jun 2019 03:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2019 07:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36337 X-GNU-PR-Package: emacs Original-Received: via spool by 36337-submit@debbugs.gnu.org id=B36337.156179287111324 (code B ref 36337); Sat, 29 Jun 2019 07:22:01 +0000 Original-Received: (at 36337) by debbugs.gnu.org; 29 Jun 2019 07:21:11 +0000 Original-Received: from localhost ([127.0.0.1]:43340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hh7fa-0002wZ-R4 for submit@debbugs.gnu.org; Sat, 29 Jun 2019 03:21:11 -0400 Original-Received: from mail-oi1-f181.google.com ([209.85.167.181]:38398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hh7fY-0002wL-ES for 36337@debbugs.gnu.org; Sat, 29 Jun 2019 03:21:09 -0400 Original-Received: by mail-oi1-f181.google.com with SMTP id v186so5996118oie.5 for <36337@debbugs.gnu.org>; Sat, 29 Jun 2019 00:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k8sKpMXxm1C24bE8lG4dSlcp2NhbBDCWl+iFL+F8tCA=; b=mmiiIC3UR7Ee0L8zJ4N6whpZCPbo5Bum/sxDRD/mJTo20re+70vnPXhJrNCSdnqlH9 NWvHOEMiO7e4aVC4k/YKzoQCgAW0ZF2N8uhh/Rvg+0ZzQc7MK+vP/zfpjVOWEVWvBdaR Lax39jeppk2v2o+0XHYrLZWIFviJuf5LLLHWgfR34Ot3ApIgLF36b3ZYZaNKS9pYO1qK IIrTtBdt6F1YoPscP1LmyDJ8orvAnhAdwE2PES2IZd2OaaKgx24dGkBuL5GxnOgZrYXo L6BPmV4w3l24d9Ix/8di1Ig7c+XesMtLrqM5BGMJaB2nmakogRZ+xClVyZrLZmux2+L2 b+IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k8sKpMXxm1C24bE8lG4dSlcp2NhbBDCWl+iFL+F8tCA=; b=jqdtnaoNuXO/xbOgZZcOHF4IktbIZjhGLPQ4KXqv9wQk5PeSaj5oo/oxf6X8x+Cx39 CaH0sXvAbqN3PZEPXamfKEzx6HHh/MSV9VHYJ7p+rdtUg0lfR0LIf/jd6TkZqv4jZlUX fYFCur2Kz/h6tw88aMdcGp1uR2L0LKyCrrMtw41uiOcRLQFaStCrdr4mHcLzkcWRgiOD wMx8CXuG+oiGQl+l34Jovu6xbRHurPYbIHLBoIY9PSBGrJYwHMzdlmdDXVqbu21H1ceq gJegDZ7ip2cEGPGvT5rAcmJgHREKPd0HgUtUjeCdwIxnhRvDzDqFd0yKsbYOJZZeOzYw b0qg== X-Gm-Message-State: APjAAAUExOBhszRIRJapTs8bolj0k8A2rq3EtpSeHBtpgNlJR3uj1hkZ 8JJ9nkqVYR+/n0mtOSi0jH3JQ/6ZV0ebdcvKL4g= X-Google-Smtp-Source: APXvYqxW3yE7ayrjdDRO6HXgeFbulKJ2ZCtE8THnK/qGC0+rMImg0AXOBt5lbtY4rQTOx+rdGpzIPa5pM4MPKG7F8FM= X-Received: by 2002:aca:be88:: with SMTP id o130mr924575oif.122.1561792862654; Sat, 29 Jun 2019 00:21:02 -0700 (PDT) In-Reply-To: <8336jtj2xo.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161797 Archived-At: --000000000000cabde9058c713c8e Content-Type: text/plain; charset="UTF-8" On Fri, Jun 28, 2019 at 12:45 PM Eli Zaretskii wrote: > > Having thought about it, I would rather require the bool vector passed > > to XBM to be in the right format: the width can be 100, but the > > stride, specified by a new :stride argument, must be the smallest > > multiple of 8 greater or equal to the width. If you don't want that, > > pass a vector of bool vectors which is copied together, but let's not > > pretend we can take a 10,000-bit bool vector and display it > > efficiently. > > I'm not sure I understand what you mean, exactly. Can you show an > example of the new API? No major changes, just that :stride is passed in along with :height and :width (optional for now, but strongly recommended by the documentation). See attached patch. --000000000000cabde9058c713c8e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Allow-a-stride-argument-so-XBM-boolvecs-are-in-the-r.patch" Content-Disposition: attachment; filename="0001-Allow-a-stride-argument-so-XBM-boolvecs-are-in-the-r.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxh73mqp0 RnJvbSAyYjhhZmJlZjEzM2VkYjk5NDczMzJiMTE0ZjM3NTgyYWU5NmVmMWFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBTYXQs IDI5IEp1biAyMDE5IDA3OjE1OjUyICswMDAwClN1YmplY3Q6IFtQQVRDSF0gQWxsb3cgYSA6c3Ry aWRlIGFyZ3VtZW50IHNvIFhCTSBib29sdmVjcyBhcmUgaW4gdGhlIHJpZ2h0CiBmb3JtYXQuCgpC dWcjMzYzMzcKCiogc3JjL2ltYWdlLmMgKHhibV9pbWFnZV9wKTogRXhwbGljaXRseSBzcGVjaWZ5 IHRoZSByaWdodCBzdHJpZGUgaWYgYQogIGJvb2wgdmVjdG9yIGlzIHVzZWQgYXMgYXJndW1lbnQu CiogZG9jL2xpc3ByZWYvZGlzcGxheS50ZXhpIChYQk0gSW1hZ2VzKTogRGVzY3JpYmUgYm9vbCB2 ZWN0b3JzCiAgYWNjdXJhdGVseS4KLS0tCiBkb2MvbGlzcHJlZi9kaXNwbGF5LnRleGkgfCAxOCAr KysrKysrKysrKystLS0tLS0KIHNyYy9pbWFnZS5jICAgICAgICAgICAgICB8IDE0ICsrKysrKysr KysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvZGlzcGxheS50ZXhpIGIvZG9jL2xpc3ByZWYvZGlz cGxheS50ZXhpCmluZGV4IDIxN2RmM2IyY2MuLjhlN2Q2MjFiNDEgMTAwNjQ0Ci0tLSBhL2RvYy9s aXNwcmVmL2Rpc3BsYXkudGV4aQorKysgYi9kb2MvbGlzcHJlZi9kaXNwbGF5LnRleGkKQEAgLTU0 MDksMTIgKzU0MDksMTQgQEAgWEJNIEltYWdlcwogWEJNIGZpbGUuICBUaGUgZmlsZSBjb250ZW50 cyBzcGVjaWZ5IHRoZSBoZWlnaHQgYW5kIHdpZHRoIG9mIHRoZSBpbWFnZS4KIAogQGl0ZW0KLUEg c3RyaW5nIG9yIGEgYm9vbC12ZWN0b3IgY29udGFpbmluZyB0aGUgYml0cyBvZiB0aGUgaW1hZ2Ug KHBsdXMgcGVyaGFwcwotc29tZSBleHRyYSBiaXRzIGF0IHRoZSBlbmQgdGhhdCB3aWxsIG5vdCBi ZSB1c2VkKS4gIEl0IHNob3VsZCBjb250YWluIGF0Ci1sZWFzdCBAdmFye3dpZHRofSAqIEBjb2Rl e2hlaWdodH0gYml0cy4gIEluIHRoaXMgY2FzZSwgeW91IG11c3Qgc3BlY2lmeQotQGNvZGV7Omhl aWdodH0gYW5kIEBjb2Rlezp3aWR0aH0sIGJvdGggdG8gaW5kaWNhdGUgdGhhdCB0aGUgc3RyaW5n Ci1jb250YWlucyBqdXN0IHRoZSBiaXRzIHJhdGhlciB0aGFuIGEgd2hvbGUgWEJNIGZpbGUsIGFu ZCB0byBzcGVjaWZ5IHRoZQotc2l6ZSBvZiB0aGUgaW1hZ2UuCitBIHN0cmluZyBvciBhIGJvb2wt dmVjdG9yIGNvbnRhaW5pbmcgdGhlIGJpdHMgb2YgdGhlIGltYWdlIChwbHVzCitwZXJoYXBzIHNv bWUgZXh0cmEgYml0cyBhdCB0aGUgZW5kIHRoYXQgd2lsbCBub3QgYmUgdXNlZCkuICBJdCBzaG91 bGQKK2NvbnRhaW4gYXQgbGVhc3QgQHZhcntzdHJpZGV9ICogQGNvZGV7aGVpZ2h0fSBiaXRzLCB3 aGVyZSBAdmFye3N0cmlkZX0KK2lzIHRoZSBzbWFsbGVzdCBtdWx0aXBsZSBvZiA4IGdyZWF0ZXIg dGhhbiBvciBlcXVhbCB0byB0aGUgd2lkdGggb2YKK3RoZSBpbWFnZS4gIEluIHRoaXMgY2FzZSwg eW91IHNob3VsZCBzcGVjaWZ5IEBjb2RlezpoZWlnaHR9LAorQGNvZGV7OndpZHRofSBhbmQgQGNv ZGV7OnN0cmlkZX0sIGJvdGggdG8gaW5kaWNhdGUgdGhhdCB0aGUgc3RyaW5nCitjb250YWlucyBq dXN0IHRoZSBiaXRzIHJhdGhlciB0aGFuIGEgd2hvbGUgWEJNIGZpbGUsIGFuZCB0byBzcGVjaWZ5 Cit0aGUgc2l6ZSBvZiB0aGUgaW1hZ2UuCiBAZW5kIGl0ZW1pemUKIAogQGl0ZW0gOndpZHRoIEB2 YXJ7d2lkdGh9CkBAIC01NDIyLDYgKzU0MjQsMTAgQEAgWEJNIEltYWdlcwogCiBAaXRlbSA6aGVp Z2h0IEB2YXJ7aGVpZ2h0fQogVGhlIHZhbHVlLCBAdmFye2hlaWdodH0sIHNwZWNpZmllcyB0aGUg aGVpZ2h0IG9mIHRoZSBpbWFnZSwgaW4gcGl4ZWxzLgorCitAaXRlbSA6c3RyaWRlIEB2YXJ7c3Ry aWRlfQorVGhlIG51bWJlciBvZiBib29sIHZlY3RvciBlbnRyaWVzIHN0b3JlZCBmb3IgZWFjaCBy b3c7IHRoZSBzbWFsbGVzdAorbXVsdGlwbGUgb2YgOCBncmVhdGVyIHRoYW4gb3IgZXF1YWwgdG8g QHZhcnt3aWR0aH0uCiBAZW5kIHRhYmxlCiAKIEBub2RlIFhQTSBJbWFnZXMKZGlmZiAtLWdpdCBh L3NyYy9pbWFnZS5jIGIvc3JjL2ltYWdlLmMKaW5kZXggZjNkNjUwOGY0Ni4uZjYyOGZlNDZkYiAx MDA2NDQKLS0tIGEvc3JjL2ltYWdlLmMKKysrIGIvc3JjL2ltYWdlLmMKQEAgLTMwOTUsNiArMzA5 NSw3IEBAIHNsdXJwX2ZpbGUgKGludCBmZCwgcHRyZGlmZl90ICpzaXplKQogICBYQk1fRklMRSwK ICAgWEJNX1dJRFRILAogICBYQk1fSEVJR0hULAorICBYQk1fU1RSSURFLAogICBYQk1fREFUQSwK ICAgWEJNX0ZPUkVHUk9VTkQsCiAgIFhCTV9CQUNLR1JPVU5ELApAQCAtMzExNiw2ICszMTE3LDcg QEAgc2x1cnBfZmlsZSAoaW50IGZkLCBwdHJkaWZmX3QgKnNpemUpCiAgIHsiOmZpbGUiLAkJSU1B R0VfU1RSSU5HX1ZBTFVFLAkJCTB9LAogICB7Ijp3aWR0aCIsCQlJTUFHRV9QT1NJVElWRV9JTlRF R0VSX1ZBTFVFLAkJMH0sCiAgIHsiOmhlaWdodCIsCQlJTUFHRV9QT1NJVElWRV9JTlRFR0VSX1ZB TFVFLAkJMH0sCisgIHsiOnN0cmlkZSIsICAgICAgICAgICBJTUFHRV9QT1NJVElWRV9JTlRFR0VS X1ZBTFVFLAkJMH0sCiAgIHsiOmRhdGEiLAkJSU1BR0VfRE9OVF9DSEVDS19WQUxVRV9UWVBFLAkJ MH0sCiAgIHsiOmZvcmVncm91bmQiLAlJTUFHRV9TVFJJTkdfT1JfTklMX1ZBTFVFLAkJMH0sCiAg IHsiOmJhY2tncm91bmQiLAlJTUFHRV9TVFJJTkdfT1JfTklMX1ZBTFVFLAkJMH0sCkBAIC0zMTkx LDcgKzMxOTMsNyBAQCB4Ym1faW1hZ2VfcCAoTGlzcF9PYmplY3Qgb2JqZWN0KQogICBlbHNlCiAg ICAgewogICAgICAgTGlzcF9PYmplY3QgZGF0YTsKLSAgICAgIGludCB3aWR0aCwgaGVpZ2h0Owor ICAgICAgaW50IHdpZHRoLCBoZWlnaHQsIHN0cmlkZTsKIAogICAgICAgLyogRW50cmllcyBmb3Ig YDp3aWR0aCcsIGA6aGVpZ2h0JyBhbmQgYDpkYXRhJyBtdXN0IGJlIHByZXNlbnQuICAqLwogICAg ICAgaWYgKCFrd1tYQk1fV0lEVEhdLmNvdW50CkBAIC0zMjAzLDYgKzMyMDUsMTQgQEAgeGJtX2lt YWdlX3AgKExpc3BfT2JqZWN0IG9iamVjdCkKICAgICAgIHdpZHRoID0gWEZJWE5BVCAoa3dbWEJN X1dJRFRIXS52YWx1ZSk7CiAgICAgICBoZWlnaHQgPSBYRklYTkFUIChrd1tYQk1fSEVJR0hUXS52 YWx1ZSk7CiAKKyAgICAgIGlmICgha3dbWEJNX1NUUklERV0uY291bnQpCisJc3RyaWRlID0gd2lk dGg7CisgICAgICBlbHNlCisJc3RyaWRlID0gWEZJWE5BVCAoa3dbWEJNX1NUUklERV0udmFsdWUp OworCisgICAgICBpZiAoaGVpZ2h0ID4gMSAmJiBzdHJpZGUgIT0gKHdpZHRoICsgQ0hBUl9CSVQg LSAxKSAvIENIQVJfQklUICogQ0hBUl9CSVQpCisJcmV0dXJuIDA7CisKICAgICAgIC8qIENoZWNr IHR5cGUgb2YgZGF0YSwgYW5kIHdpZHRoIGFuZCBoZWlnaHQgYWdhaW5zdCBjb250ZW50cyBvZgog CSBkYXRhLiAgKi8KICAgICAgIGlmIChWRUNUT1JQIChkYXRhKSkKQEAgLTMyNDIsNyArMzI1Miw3 IEBAIHhibV9pbWFnZV9wIChMaXNwX09iamVjdCBvYmplY3QpCiAJfQogICAgICAgZWxzZSBpZiAo Qk9PTF9WRUNUT1JfUCAoZGF0YSkpCiAJewotCSAgaWYgKGJvb2xfdmVjdG9yX3NpemUgKGRhdGEp IC8gaGVpZ2h0IDwgd2lkdGgpCisJICBpZiAoYm9vbF92ZWN0b3Jfc2l6ZSAoZGF0YSkgLyBoZWln aHQgPCBzdHJpZGUpCiAJICAgIHJldHVybiAwOwogCX0KICAgICAgIGVsc2UKLS0gCjIuMjAuMQoK --000000000000cabde9058c713c8e--