From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Fri, 5 Mar 2021 15:54:07 +0000 Message-ID: References: <86wnut8fb9.fsf@gmail.com> <861rd1tbpa.fsf@gmail.com> <83pn0km6y3.fsf@gnu.org> <86ft1f8ara.fsf@gmail.com> <83sg5cjdn8.fsf@gnu.org> <83r1kwjcy2.fsf@gnu.org> <83k0qoj9zv.fsf@gnu.org> <83im68j963.fsf@gnu.org> <83tuprhur0.fsf@gnu.org> <831rcu25o2.fsf@gnu.org> <83v9a6zr22.fsf@gnu.org> <83o8fyzjrz.fsf@gnu.org> <83wnulyfv8.fsf@gnu.org> <83lfb1y7la.fsf@gnu.org> <83eegty6a7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2842"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46256@debbugs.gnu.org, Andrea Corallo To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 05 16:55:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lICnF-000AE0-Ck for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 16:55:09 +0100 Original-Received: from localhost ([::1]:56916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lICnE-0003Ri-Fk for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 10:55:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lICn8-0003RZ-3x for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 10:55:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lICn7-00035n-RJ for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 10:55:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lICn7-0004pz-P7 for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 10:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Mar 2021 15:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.161495969318578 (code B ref 46256); Fri, 05 Mar 2021 15:55:01 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 5 Mar 2021 15:54:53 +0000 Original-Received: from localhost ([127.0.0.1]:35201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lICmy-0004pZ-O5 for submit@debbugs.gnu.org; Fri, 05 Mar 2021 10:54:52 -0500 Original-Received: from mail-ot1-f42.google.com ([209.85.210.42]:43015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lICmv-0004pM-MA for 46256@debbugs.gnu.org; Fri, 05 Mar 2021 10:54:50 -0500 Original-Received: by mail-ot1-f42.google.com with SMTP id v12so2209699ott.10 for <46256@debbugs.gnu.org>; Fri, 05 Mar 2021 07:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zQ0MRHHo9pcXSWGyXjh16fCpwcQ//DMjgEp1lFlezcA=; b=lmBWd6r8V1hbXJ1X3IoPAXmMf/0A4qHxuvArCch49Eq9WHg4i6uCWVVGJBeeG+U+Uf zIcrEe5oMtnsll6PoWL/rUq0EdFsRqHFFhFtzWjCPf0Emhymf+wQM1qDM+FWVQxb96OD KHs1GHl4m0QMWKfxIiBzvnODZ8sju/9/0Z+MquWtTWq90pdMMh66JNaNGb/44PONDkOJ XBs6b54LuqYnV1YAKDyQ3gu0P+lch2cVoQHr+UcjcWMMBKPdyXsMx33bD3ZXzE97YOFi Cv4cHgMEgHw4azJMO6LYhYUhlsQdhk1dFugfHaS5TYLVchPQ0OnsvI/OuDGZ6hmdmsG8 +0Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zQ0MRHHo9pcXSWGyXjh16fCpwcQ//DMjgEp1lFlezcA=; b=Afzqsc4Nf1oELiGU8JP8ihlC5B5Dwc9uuQV2BQmgM5lXiOkY9e2yTr3qf0I00NyEJ5 k4gN1baLIv7dPj3UMmF89sGt9FEjU6RSNf65GVicBu4M5a3jYe/YTs63qHTqqf4q1qOX 5BzCnhi8psPDQ+EcD1zNEDI37jYOzMrIyFLjjEAMzXYgCf+f/NBoQkKDfuv66IDcr2nb ZKM0zqku2d/AqCorC/JBPRYAiyoFfoa4pxWl9Ih7ubxrWtUyK3NuKUD+sNML/ATHBRqq pShXW9Pb2YW9xm/OSFM/kCi4R6sokdeAN0aV85/zJ4IlhIX8tjEd6uE/qvKQqo8/EwbU LEsQ== X-Gm-Message-State: AOAM533P7aCBgnFTmuDJmtTVSqJSkCLD+WZS5Ewwn9DmVwc1mUXvcpmD WCdvHEQ7cLPwZh6ikcuVJPsTCvCu9Ias2aVMXn4= X-Google-Smtp-Source: ABdhPJzDG8+MwKS1/WR4U/2Ab3igULzj++7e1Mbja4wTnq39gITEBo8vs+niZUa6syZHQWgkyzSJgtHiQLcOxhQal60= X-Received: by 2002:a05:6830:1e51:: with SMTP id e17mr8547150otj.292.1614959684010; Fri, 05 Mar 2021 07:54:44 -0800 (PST) In-Reply-To: <83eegty6a7.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201558 Archived-At: On Fri, Mar 5, 2021 at 3:22 PM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Fri, 5 Mar 2021 15:18:12 +0000 > > Cc: Andrea Corallo , 46256@debbugs.gnu.org > > > > > Then perhaps we could invoke Emacs only in order to detect when the > > > ABI has changed. > > > > IIUC, the ABI only changes when DEFUNs do, and then we regenerate most > > of the Emacs binaries anyway, so we could make abi-hash depend on > > gl-stamp/globals.h? > > Why should we have the knowledge about what determines the ABI hash in > more than one place? At least in my case, I end up building several emacs binaries in a tree, and then I have to ls -l native-lisp to find out which one is current, and that's annoying. But Andrea pointed out, entirely correctly, that I missed the discussion and a consensus has apparently been reached to do it this way. I do think it's weird to have to run Emacs to find out which directories the Emacs binary looks at, but maybe that's just me. > > > Because when that happens, we need to regenerate all > > > the preloaded *.eln files anyway, so there's no need to test > > > individual files. Right? > > > > But do we want to keep the old files around in case the ABI changes > > back? I don't think we do. > > That's a separate issue. Indeed. > It depends on whether the build included non-preloaded files. I'm afraid I don't follow. Pip