From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#39962: 27.0.90; Crash in Emacs 27.0.90 Date: Sat, 14 Mar 2020 16:15:57 +0000 Message-ID: References: <24162.58107.725366.668639@cochabamba.vanoostrum.org> <837dzqaieq.fsf@gnu.org> <834kuuadod.fsf@gnu.org> <83blp1siku.fsf@gnu.org> <83o8t08ufp.fsf@gnu.org> <831rpw8bf3.fsf@gnu.org> <17a7a496-d142-55d4-3cc9-f4f86fdaeaa8@cs.ucla.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ecc97105a0d2e891" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="24064"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pieter-l@vanoostrum.org, 39962@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 14 17:17:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jD9TM-00067k-1y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Mar 2020 17:17:12 +0100 Original-Received: from localhost ([::1]:46264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD9TK-0006N2-Ox for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Mar 2020 12:17:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39102) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jD9TD-0006Mj-PY for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 12:17:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jD9TC-00076s-Il for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 12:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56118) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jD9TC-00075b-Ex for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 12:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jD9TC-0003zs-A7 for bug-gnu-emacs@gnu.org; Sat, 14 Mar 2020 12:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Mar 2020 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39962 X-GNU-PR-Package: emacs Original-Received: via spool by 39962-submit@debbugs.gnu.org id=B39962.158420260215336 (code B ref 39962); Sat, 14 Mar 2020 16:17:02 +0000 Original-Received: (at 39962) by debbugs.gnu.org; 14 Mar 2020 16:16:42 +0000 Original-Received: from localhost ([127.0.0.1]:33858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD9Ss-0003zI-5z for submit@debbugs.gnu.org; Sat, 14 Mar 2020 12:16:42 -0400 Original-Received: from mail-oi1-f173.google.com ([209.85.167.173]:34569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jD9Sq-0003z5-Gu for 39962@debbugs.gnu.org; Sat, 14 Mar 2020 12:16:40 -0400 Original-Received: by mail-oi1-f173.google.com with SMTP id g6so12985439oiy.1 for <39962@debbugs.gnu.org>; Sat, 14 Mar 2020 09:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3z6koYT5OM/RALL/mTaV9jo4y7iYQB31ZG5jwG/kn1Y=; b=YWOOlcFfmgAg2uFADyuvYlH11LnQH9j3Fvp94Uh07oDPAH0t+MJeW8xSgyTr9xdTzd uOIDAPsv6H2mOhmUvWs1pX61H0Nc1fbeM9AxKl5Zyao1CJyBWd8v7kPTCyUWaTEYlZki pkAme/f3kNJaXtDF6Myq7jleyQEGLnIyYqqbD4wtSwFWdI6zSmrVQ8ijp1p8mWRDDBq8 +8DDd8FZcN16VbdYu9POalRgGVf4Iz+WwfJBVHI8FmD4Yy3r9hIy2GoAY6c06B51MjDl wmUn8YtCv8XH/ziUQIQHfVp+5XNAsgF9Iw01nJ4S7AAMUR61I6q0miUmLrFqsHMAa+iS AyXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3z6koYT5OM/RALL/mTaV9jo4y7iYQB31ZG5jwG/kn1Y=; b=r2mGv3SfVKbWd0OKpiI6YI+sxMAiGUGdH59dBeRbzNIkxt+XAP2zRS8Ivw9Bku1gl/ +KEIiXqK3tOJwW4uNbU/5X2RsW08BsIiU7CxL2EuAeHWfAdvFPpr+dpE6BShGu35uaZM hncOTUWiOvb06cs3kHH60HyXGcmH2wLBn62QwhUDwA1eBDCiJz3ia6F/nIYtIZ795NUG 2Zcdsryrzelr7dVYDVh7Ly60tRXktrKy9otS1RhKKVgtAdlhX8/BIsInpdrcidnUSQ5o tvQEm7bWvgdhTtbICH17XlrjbZxUoGCntRp5uULX2kUnRd+UfA88i8v6b4Vv88SBDhc9 yvAA== X-Gm-Message-State: ANhLgQ1tyID+TcWfrPLPF1LyU84yq2gowt4lA5k5C3PpoStXl59l+Co8 DW4H652Mzx4BsOlwLtpfBmL2lOSkr0nWMC69XAk= X-Google-Smtp-Source: ADFU+vuQfBcu+IVOQOdSnWYI+/eMDs/9FdX2SIiw0IH6/pwgs3aLT6UZXGKAL9672RWHrCOeRGtiTvoQqSPigGQhdj0= X-Received: by 2002:a05:6808:1cf:: with SMTP id x15mr11664400oic.44.1584202594954; Sat, 14 Mar 2020 09:16:34 -0700 (PDT) In-Reply-To: <17a7a496-d142-55d4-3cc9-f4f86fdaeaa8@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177354 Archived-At: --000000000000ecc97105a0d2e891 Content-Type: text/plain; charset="UTF-8" On Sat, Mar 14, 2020 at 4:00 PM Paul Eggert wrote: > > +/* If P is a pointer into a buffer, killed or live, return the buffer. > > + Otherwise, return nil. M is a pointer to the mem_block for P. */ > > + > > +static Lisp_Object > > +valid_buffer_holding (struct mem_node *m, void *p) > > +{ > > + /* P must point into the block, and the buffer > > + must not have been killed. */ > > The two comments do not seem to agree. Surely second one should say just > something like "P must point into block M." Thanks! Revised patch attached. --000000000000ecc97105a0d2e891 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-collect-reachable-killed-buffers-during-GC.patch" Content-Disposition: attachment; filename="0001-Don-t-collect-reachable-killed-buffers-during-GC.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k7rta1050 RnJvbSAzYTZlYTdkY2U2OWFiNDA3N2QyNjM0OGI3NDM0MDBjZGNiMWI1ZWEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBTYXQs IDE0IE1hciAyMDIwIDE1OjM2OjQxICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRG9uJ3QgY29sbGVj dCByZWFjaGFibGUga2lsbGVkIGJ1ZmZlcnMgZHVyaW5nIEdDCgoqIHNyYy9hbGxvYy5jICh2YWxp ZF9idWZmZXJfaG9sZGluZyk6IE5ldyBmdW5jdGlvbiwgcmV0dXJucyB0cnVlIGZvcgp2YWxpZCBr aWxsZWQgYnVmZmVycy4KKG1hcmtfbWF5YmVfb2JqZWN0LCBtYXJrX21heWJlX3BvaW50ZXIpOiBV c2UKYHZhbGlkX2J1ZmZlcl9ob2xkaW5nJyByYXRoZXIgdGhhbiBgbGl2ZV9idWZmZXJfaG9sZGlu ZycuCi0tLQogc3JjL2FsbG9jLmMgfCAyNyArKysrKysrKysrKysrKysrKysrKysrKysrLS0KIDEg ZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL3NyYy9hbGxvYy5jIGIvc3JjL2FsbG9jLmMKaW5kZXggMWM2YjY2NGIyMi4uYmRhZGZkZDMx OCAxMDA2NDQKLS0tIGEvc3JjL2FsbG9jLmMKKysrIGIvc3JjL2FsbG9jLmMKQEAgLTQ1MTEsNiAr NDUxMSwyOSBAQCBsaXZlX2J1ZmZlcl9wIChzdHJ1Y3QgbWVtX25vZGUgKm0sIHZvaWQgKnApCiAg IHJldHVybiAhTklMUCAobGl2ZV9idWZmZXJfaG9sZGluZyAobSwgcCkpOwogfQogCisvKiBJZiBQ IGlzIGEgcG9pbnRlciBpbnRvIGEgYnVmZmVyLCBraWxsZWQgb3IgbGl2ZSwgcmV0dXJuIHRoZSBi dWZmZXIuCisgICBPdGhlcndpc2UsIHJldHVybiBuaWwuICBNIGlzIGEgcG9pbnRlciB0byB0aGUg bWVtX2Jsb2NrIGZvciBQLiAgKi8KKworc3RhdGljIExpc3BfT2JqZWN0Cit2YWxpZF9idWZmZXJf aG9sZGluZyAoc3RydWN0IG1lbV9ub2RlICptLCB2b2lkICpwKQoreworICAvKiBQIG11c3QgcG9p bnQgaW50byB0aGUgYmxvY2sgTS4gICovCisgIGlmIChtLT50eXBlID09IE1FTV9UWVBFX0JVRkZF UikKKyAgICB7CisgICAgICBzdHJ1Y3QgYnVmZmVyICpiID0gbS0+c3RhcnQ7CisgICAgICBjaGFy ICpjYiA9IG0tPnN0YXJ0OworICAgICAgY2hhciAqY3AgPSBwOworICAgICAgcHRyZGlmZl90IG9m ZnNldCA9IGNwIC0gY2I7CisgICAgICBpZiAoMCA8PSBvZmZzZXQgJiYgb2Zmc2V0IDwgc2l6ZW9m ICpiKQorCXsKKwkgIExpc3BfT2JqZWN0IG9iajsKKwkgIFhTRVRCVUZGRVIgKG9iaiwgYik7CisJ ICByZXR1cm4gb2JqOworCX0KKyAgICB9CisgIHJldHVybiBRbmlsOworfQorCiAvKiBNYXJrIE9C SiBpZiB3ZSBjYW4gcHJvdmUgaXQncyBhIExpc3BfT2JqZWN0LiAgKi8KIAogc3RhdGljIHZvaWQK QEAgLTQ1NjYsNyArNDU4OSw3IEBAIG1hcmtfbWF5YmVfb2JqZWN0IChMaXNwX09iamVjdCBvYmop CiAKIAljYXNlIExpc3BfVmVjdG9ybGlrZToKIAkgIG1hcmtfcCA9IChFUSAob2JqLCBsaXZlX3Zl Y3Rvcl9ob2xkaW5nIChtLCBwbykpCi0JCSAgICB8fCBFUSAob2JqLCBsaXZlX2J1ZmZlcl9ob2xk aW5nIChtLCBwbykpKTsKKwkJICAgIHx8IEVRIChvYmosIHZhbGlkX2J1ZmZlcl9ob2xkaW5nICht LCBwbykpKTsKIAkgIGJyZWFrOwogCiAJZGVmYXVsdDoKQEAgLTQ2MzYsNyArNDY1OSw3IEBAIG1h cmtfbWF5YmVfcG9pbnRlciAodm9pZCAqcCkKIAkgIGJyZWFrOwogCiAJY2FzZSBNRU1fVFlQRV9C VUZGRVI6Ci0JICBvYmogPSBsaXZlX2J1ZmZlcl9ob2xkaW5nIChtLCBwKTsKKwkgIG9iaiA9IHZh bGlkX2J1ZmZlcl9ob2xkaW5nIChtLCBwKTsKIAkgIGJyZWFrOwogCiAJY2FzZSBNRU1fVFlQRV9D T05TOgotLSAKMi4yNS4xCgo= --000000000000ecc97105a0d2e891--