From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36403: 27.0.50; Trivial image.c bugs Date: Fri, 21 Aug 2020 09:26:10 +0000 Message-ID: References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> <87v9hcj4g9.fsf@gnus.org> <87r1s0j4af.fsf@gnus.org> <87imdcj3lg.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40877"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Third , 36403@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 11:27:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k93KH-000APz-KE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 11:27:09 +0200 Original-Received: from localhost ([::1]:49850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k93KF-0001l9-W1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 05:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k93KA-0001kx-Ee for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 05:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k93KA-0002zc-59 for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 05:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k93KA-00044x-0w for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 05:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 09:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159800201515667 (code B ref 36403); Fri, 21 Aug 2020 09:27:01 +0000 Original-Received: (at 36403) by debbugs.gnu.org; 21 Aug 2020 09:26:55 +0000 Original-Received: from localhost ([127.0.0.1]:45037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k93K2-00044d-Pj for submit@debbugs.gnu.org; Fri, 21 Aug 2020 05:26:54 -0400 Original-Received: from mail-ot1-f50.google.com ([209.85.210.50]:34411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k93K0-00044P-Tg for 36403@debbugs.gnu.org; Fri, 21 Aug 2020 05:26:53 -0400 Original-Received: by mail-ot1-f50.google.com with SMTP id k12so1107425otr.1 for <36403@debbugs.gnu.org>; Fri, 21 Aug 2020 02:26:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PlzaRkrwLEF8Q6Hp9nta96d7iMZkCLYmXu4J7s8wa6c=; b=XDQFd0EuRKbZM2tLfPSWry8YP0ztjPS24ZJp6zcSnLWbTVPZvy0zpnNSbpFznporsA V599xN6AbdkwNdBIO/x/1zGDLuxSuVH/2Fdmqr5z5ZvCiFGRlkXm3LWVLMU4ibVQmG6c wejM6T7Bl6SNhztn/IUusQlxLGmXilecAB4BM+A+ep/k4wDNjZUFcvRMDAc4kgNoRsY5 Ewn/ova9aNH7Tg7WfOAuwqhNmkbDlUKslzhby6JvCs01CGPcFQGOJzuTgWEgfA78uY3K f7O3dlJ9WHWmaMU18R9u+lEpZhoihrGbYyFMs9MByIfIaeYckXFrG9n3r5kqWMDAl4XH 2wKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PlzaRkrwLEF8Q6Hp9nta96d7iMZkCLYmXu4J7s8wa6c=; b=kWVPseA4ejKolUcAujUo8XJMkMs9Or0pXDNuz3gJFGy8uPJfbSrrAHZqy4OVCGkvBC Ey5eTv0PDXYqQsAAe07EoIUS9TI4lV82pteGsNC2dPr1YkVGw8rlU/cPa2g7nnDRAf97 BWxFEyHS9SwzUI6eMEhMlgOor928oZj9gRIWQ6hb1szC3W/2enrcBwUAq5TS9yR9W9lX HVDhNMFHnw1FDAS0uT2SlR4riChTqbDy2mYoBLAFyu5P+HwC0OGb7X2tE/GjlIb6CGZP xomFtg5BMriREhleVzm69mc7mmP4k4dWIWNEXnmLMlauY4yzNcgtMJ06fCxgHP8w+xiD u0jw== X-Gm-Message-State: AOAM532JY83LHcrQ6H3Uw+OgneRqG1aGa8dDNoAsSENMPhqwBPSi0Ppe AoehfDVtYDmR3S1xMwTTyWmN+JalJluPSQfO1Ho= X-Google-Smtp-Source: ABdhPJzSXnxqeCY6+3Atcayy93ljbCi1hoYyuDFOEZE3rnpzcpE6IzetosFfs1YtqapWoAFQR2m/tr6XKQ3Jh7XPCTc= X-Received: by 2002:a05:6830:13d1:: with SMTP id e17mr1340474otq.292.1598002006921; Fri, 21 Aug 2020 02:26:46 -0700 (PDT) In-Reply-To: <87imdcj3lg.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185827 Archived-At: On Thu, Aug 20, 2020 at 11:32 PM Lars Ingebrigtsen wrote: > for (img = c->buckets[i]; img; img = img->next) > if (img->hash == hash > - && !NILP (Fequal (img->spec, spec)) > + && !equal_lists (img->spec, spec) > && img->frame_foreground == FRAME_FOREGROUND_PIXEL (f) > && img->frame_background == FRAME_BACKGROUND_PIXEL (f)) > > I guess the !NILP (Fequal...) idiom tainted the rewrite... I can confirm it did. However, my stupidity is not a very good argument for changing Emacs, or all of it would need changing :-) > I've often wondered why we use !NILP instead of, like TRUEP or > something. !NILP doesn't feel very natural. Paul's suggestion was to use equal () instead of !NILP (Fequal (...)). I'm against that, because the F in Fequal kind of hints at the difficulties of using equal, of which there are many: in the current implementation, it can signal, quit, be asymmetric (signalling for (equal a b) whereas (equal b a) works), and is susceptible to equality bombs that take forever to compare. It cannot call Lisp, yet, but I wouldn't be surprised if that changes. It's really not a function you should use from C very often, and using it as a hash table predicate is often the wrong thing to do. Replacing !NILP is a better idea, but I'm struggling to come up with a good name for that. But even a bad name would be an improvement.