From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#41645: 27.0.91; Combining Grapheme Joiner (#x34f) gui artifacts Date: Mon, 1 Jun 2020 18:09:27 +0000 Message-ID: References: <83zh9merd4.fsf@gnu.org> <83wo4qepab.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000426bb405a709b4d8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="12492"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dfussner@googlemail.com, 41645@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 01 20:11:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jfoty-0003CX-Ev for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Jun 2020 20:11:10 +0200 Original-Received: from localhost ([::1]:45658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfotx-0004Zh-Dy for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Jun 2020 14:11:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfotq-0004ZW-C9 for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 14:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfotp-00022h-SC for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 14:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jfotp-0003dl-Mj for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2020 14:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Jun 2020 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41645 X-GNU-PR-Package: emacs Original-Received: via spool by 41645-submit@debbugs.gnu.org id=B41645.159103501213926 (code B ref 41645); Mon, 01 Jun 2020 18:11:01 +0000 Original-Received: (at 41645) by debbugs.gnu.org; 1 Jun 2020 18:10:12 +0000 Original-Received: from localhost ([127.0.0.1]:36980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfot2-0003cY-08 for submit@debbugs.gnu.org; Mon, 01 Jun 2020 14:10:12 -0400 Original-Received: from mail-ot1-f45.google.com ([209.85.210.45]:37737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfot0-0003c6-Iu for 41645@debbugs.gnu.org; Mon, 01 Jun 2020 14:10:10 -0400 Original-Received: by mail-ot1-f45.google.com with SMTP id v13so1930260otp.4 for <41645@debbugs.gnu.org>; Mon, 01 Jun 2020 11:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LuRnbTSQUW3nfslXLnXQoBdxxRFHZoQF+nxEb4Cjzlk=; b=GKyrQ9zMJbMkydf/iJFXTQONjNq3NEtitGCnoBHRlPyqY3yCnypx6+Z8eYggmyS5sz rijWC/GtXalE5UH9JqKO3TyePPvOJJQ96WgDfnAlCkb4B5153+LsQLGFf9Vy/S/QvhZv tuc8hNe+8jgxNEXx9NoboofwvlBDscJsNBceR7dBumSsf6GXnRCZ+NxWUKTyg4Nq38U+ QvlQ2pMj4Mlwwxb2qHqUgEZpPv9gdxNxJ+4ysWeLRbzFmv9RO51lbKe77SA+3sx2YHyh /52KCbkFH8vH1nxG3CJ4OXYFQ9biPKNs95oEaokMN0KDiT5UJpmEmkP5HJqP6EsBG0ln mVlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LuRnbTSQUW3nfslXLnXQoBdxxRFHZoQF+nxEb4Cjzlk=; b=PqW7OBn3qm1PUEaoux7gT9mWZCG5PAETbNmKrGZpgnGy8+3emJG83Zl9VA4Kzu8kNU YrFLW43zshicECvDFWxsoIxmLZ1zP8XFhf2SSZCqiy9mD8e0a8Hdsgh+18TkYugkkepz 9nDJMjUcgPO/hPvDAcTEX2LuALipr1WGHj1rgk5weR1Eyh53pjiMsWdtbJx1ZZuKjyhZ O8L8L7HozfQc9SpgRlg6ibjI+FXJvlcuyP/ahM1lPRH4DOzd97K+W4bTFoXhFnOcT67Q YVJy3qCd5iGpCxngcNSvAw9KqbWdgpeZcD9PO4zSJXSrPpXXLFTUL5w5YMBQHb1xAy3x ZZhw== X-Gm-Message-State: AOAM533n/F1pBbNV4BBM3Vydv0yTgMJJWQsyN3S2KWsXiB6xOmedB1an uLij42g2HaSlONJeCW0bldisE56oRIABqDJ+Pt0= X-Google-Smtp-Source: ABdhPJwMi5LbsNTmxECrTg9o97z9bFoxUruegbAgesvd4QB/vdTyeCh+KA8+ZMyCxIUXP/q7Sk7eEW3a0jyCot1hln0= X-Received: by 2002:a9d:4c97:: with SMTP id m23mr14658685otf.154.1591035004334; Mon, 01 Jun 2020 11:10:04 -0700 (PDT) In-Reply-To: <83wo4qepab.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181361 Archived-At: --000000000000426bb405a709b4d8 Content-Type: text/plain; charset="UTF-8" On Mon, Jun 1, 2020 at 4:14 PM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Mon, 1 Jun 2020 15:50:16 +0000 > > Cc: David Fussner , 41645@debbugs.gnu.org > > > > > I cannot reproduce this on my system, FWIW. Very strange. > > > > I can reproduce this, but it depends on which font it uses. > > I have only 2 fonts that cover that codepoint, and both produce > correct display. When I try a font that doesn't support it, I see a > box with hex code, which, of course, causes no problems. The problem is a zero-width glyph in a gstring. Fixing the artifact is easy (see attached patch), but that still means when the cursor is on the CGJ it's invisible. My impression is most code paths avoid zero-width glyphs for that reason. > When you do reproduce the problem, do the characters around CGJ use > the same font as the CGJ itself, or do they use a different font? The same font. > If > the latter, the composition won't work, and maybe that is when the > problem happens? Indeed, the composition gstring is a single zero-width glyph. > > Is it possible it's bug 41454? I'm attaching that patch in case it > > does anything and people feel like testing it. > > I'm guessing you already tested, and it doesn't fix the problem for > you (when you use the fonts which do reproduce the problem)? I tested, thought it had fixed the problem, had to run off, returned, tested again, and it turned out not to fix the problem. Sorry about that. > I think that bug is unlikely to be the culprit: symptoms such as those > described here usually mean that Emacs becomes confused about the > metrics of the character's glyph on display. So to find the root > cause, one should step through the code which draws the character and > then the code which draws the cursor on that character, and see what's > going on there with the metrics. How about this, as a first stop-gap until we figure out how to properly prevent automatic compositions resulting in zero-width struct glyphs? --000000000000426bb405a709b4d8 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Avoid-cursor-display-artifacts-for-zero-width-glyphs.patch" Content-Disposition: attachment; filename="0001-Avoid-cursor-display-artifacts-for-zero-width-glyphs.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kawt4z3m0 RnJvbSA4ZTIxODMzOWUxNjRkYTU3YzIyYzZjNzIxNzlkMjQ5OTQwM2IzZGRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBNb24s IDEgSnVuIDIwMjAgMTg6MDc6NTEgKzAwMDAKU3ViamVjdDogW1BBVENIXSBBdm9pZCBjdXJzb3Ig ZGlzcGxheSBhcnRpZmFjdHMgZm9yIHplcm8td2lkdGggZ2x5cGhzCiAoQnVnIzQxNjQ1KQoKLS0t CiBzcmMveGRpc3AuYyB8IDUgKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyks IDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL3hkaXNwLmMgYi9zcmMveGRpc3AuYwpp bmRleCAyYTA1OWM3YzYwLi5iMmMyZmYwOWM2IDEwMDY0NAotLS0gYS9zcmMveGRpc3AuYworKysg Yi9zcmMveGRpc3AuYwpAQCAtMzE0NTAsMTMgKzMxNDUwLDEyIEBAIGRpc3BsYXlfYW5kX3NldF9j dXJzb3IgKHN0cnVjdCB3aW5kb3cgKncsIGJvb2wgb24sCiAgICAgICAmJiAoIW9uCiAJICB8fCB3 LT5waHlzX2N1cnNvci54ICE9IHgKIAkgIHx8IHctPnBoeXNfY3Vyc29yLnkgIT0geQorCSAgfHwg dy0+cGh5c19jdXJzb3Jfd2lkdGggIT0gbmV3X2N1cnNvcl93aWR0aAogCSAgLyogSFBPUyBjYW4g YmUgbmVnYXRpdmUgaW4gUjJMIHJvd3Mgd2hvc2UKIAkgICAgIGV4YWN0X3dpbmRvd193aWR0aF9s aW5lX3AgZmxhZyBpcyBzZXQgKGkuZS4gdGhlaXIgbmV3bGluZQogCSAgICAgd291bGQgIm92ZXJm bG93IGludG8gdGhlIGZyaW5nZSIpLiAgKi8KIAkgIHx8IGhwb3MgPCAwCi0JICB8fCBuZXdfY3Vy c29yX3R5cGUgIT0gdy0+cGh5c19jdXJzb3JfdHlwZQotCSAgfHwgKChuZXdfY3Vyc29yX3R5cGUg PT0gQkFSX0NVUlNPUiB8fCBuZXdfY3Vyc29yX3R5cGUgPT0gSEJBUl9DVVJTT1IpCi0JICAgICAg JiYgbmV3X2N1cnNvcl93aWR0aCAhPSB3LT5waHlzX2N1cnNvcl93aWR0aCkpKQorCSAgfHwgbmV3 X2N1cnNvcl90eXBlICE9IHctPnBoeXNfY3Vyc29yX3R5cGUpKQogICAgIGVyYXNlX3BoeXNfY3Vy c29yICh3KTsKIAogICAvKiBEb24ndCBjaGVjayBwaHlzX2N1cnNvcl9vbl9wIGhlcmUgYmVjYXVz ZSB0aGF0IGZsYWcgaXMgb25seSBzZXQKLS0gCjIuMjcuMC5yYzAKCg== --000000000000426bb405a709b4d8--