From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#46824: 28.0.50; nativecomp crash with cl-block/cl-defun Date: Mon, 1 Mar 2021 13:02:03 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000008da23905bc793b8b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46824@debbugs.gnu.org, Aaron Jensen To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 14:03:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGiCb-0002eC-QI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 14:03:09 +0100 Original-Received: from localhost ([::1]:37170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGiCa-0005kY-S0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 08:03:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGiCU-0005kS-7h for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 08:03:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGiCU-0003tV-0X for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 08:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGiCT-0007Ak-UI for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 08:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 13:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46824 X-GNU-PR-Package: emacs Original-Received: via spool by 46824-submit@debbugs.gnu.org id=B46824.161460376827551 (code B ref 46824); Mon, 01 Mar 2021 13:03:01 +0000 Original-Received: (at 46824) by debbugs.gnu.org; 1 Mar 2021 13:02:48 +0000 Original-Received: from localhost ([127.0.0.1]:48425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGiCF-0007AI-Nk for submit@debbugs.gnu.org; Mon, 01 Mar 2021 08:02:48 -0500 Original-Received: from mail-ot1-f49.google.com ([209.85.210.49]:35260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGiCD-0007A5-MV for 46824@debbugs.gnu.org; Mon, 01 Mar 2021 08:02:46 -0500 Original-Received: by mail-ot1-f49.google.com with SMTP id r19so16360609otk.2 for <46824@debbugs.gnu.org>; Mon, 01 Mar 2021 05:02:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S/hBoxT+AapQrunCW4DAJKFAF2V8yaWMH6+TNGyYnEM=; b=rlyHaHYaf5CX5jNqCoXVNvBsqwyyS/wNTGcqKERgv4IWTOIwKi5ZmAyNgDVftDvAtt qM//fK9aRvrbOCTKRWxsBz3DvLZZI+MZvSlRuxAcB/QNB763BBjXK+99vmzLY0HSDx/+ ddluLRYUKeBCLyz6l/IYpEFJdtK5ogPPcH6Hh0oZbmPF8q/FvsBiAzEUO3nJbPNawhmo lxgFd83aPPJmisbjq5yEoJwR/frDIT3ULOkMnUh9QUgajx76PGMexGqHBDaebIk8OS/D YLBFzi+CoVH6eARDoc9dw67RgBMPbTXdYB92tOOgsUidqOB+Q/1Hl/5H3heOhCqUHdnQ HwpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S/hBoxT+AapQrunCW4DAJKFAF2V8yaWMH6+TNGyYnEM=; b=fzugdjE17TzmYleCCBbXU3c23teK/ZpIFGvS6C4Oqr+1E7FtqPyrQLhHAD7FW/shoQ vjpB90AV1DqdreblsGh7h4KrrVZFb0849Li9rSdQxzWvcea4YN/uuKg2HvPM26FLTNDN elxYW1ikTiPrditC7v4Y/DOIi1nEqA9IU3zfk7/BJ1z4+yUb3xz7SaS66Z18n6atHmdK L8muyTFg2Mvznd8uJ1wU8MWg7KSu4MtBpdWW4xesyiibyotiZTAQ4aqxBjBsrdKGBBUC VoufVe+8i+9WCij+OzOW0MUtTsbZS2sx/AuwlaIXbaJMBubwMx2afeG989fEot1NMGzW QuWg== X-Gm-Message-State: AOAM532F8GCMIyieqcuQBqX8aFeGRMQ8lWc/Bixogub/PneRfN3irgy5 9SnG/pUMsHNSE5WSnYF6WkAcfNo0PHotDO0RSao= X-Google-Smtp-Source: ABdhPJyewuWlgVPPPzZhYuofEJu9ImmkGlhSYwBu3yIi6hmMjMnYCl+JuEHOd4zo/EeGTqBmZ6vRXBbtgZ2TSg3RLA4= X-Received: by 2002:a05:6830:1682:: with SMTP id k2mr13470316otr.154.1614603759746; Mon, 01 Mar 2021 05:02:39 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201084 Archived-At: --0000000000008da23905bc793b8b Content-Type: text/plain; charset="UTF-8" On Mon, Mar 1, 2021 at 9:02 AM Andrea Corallo wrote: > Pip Cet writes: > > On Sun, Feb 28, 2021 at 6:13 AM Pip Cet wrote: > >> Andrea, is it possible to modify the code so _setjmp is called > >> directly rather than through a function pointer? > > > > This patch, which I hasten to add is not for inclusion and hasn't been > > tested against the test suite, might fix the problem (on non-Windows > > systems. I'm afraid this problem is something that Windows actually > > got right and Unix got wrong...) It does here, experimentally. > > > > I'd appreciate it if someone could test further. > > I haven't looked into the patch but the approach sounds like a good idea > to me. Can we have the version of the patch you'd like to have included? Here's the version I'd like to include. This should not cause any new test suite failures, just the ones I've been seeing all along. Apart from the ABI bump, it should not change anything on WINDOWSNT, which I can't test. Pip --0000000000008da23905bc793b8b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-call-_setjmp-through-a-function-pointer-Bug-46.patch" Content-Disposition: attachment; filename="0001-Don-t-call-_setjmp-through-a-function-pointer-Bug-46.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_klqlbdvp0 RnJvbSA0YmY0NzQ2MGRjNGRmNjFjNzk3Mzc5NjRmZjExZmE5ZjViZjExMDJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBTdW4s IDI4IEZlYiAyMDIxIDA2OjMxOjAwICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRG9uJ3QgY2FsbCBf c2V0am1wIHRocm91Z2ggYSBmdW5jdGlvbiBwb2ludGVyIChCdWcjNDY4MjQpCgoqIHNyYy9jb21w LmMgKGhlbHBlcl9saW5rX3RhYmxlKTogRG9uJ3QgaW5jbHVkZSBTRVRKTVAgZXhjZXB0IG9uIFdp bmRvd3MuCihlbWl0X3NldGptcCk6IERvbid0IHVzZSBmdW5jdGlvbiBwb2ludGVycyBleGNlcHQg b24gV2luZG93cy4KKGRlY2xhcmVfcnVudGltZV9pbXBvcnRlZF9mdW5jcyk6IERvbid0IGltcG9y dCBTRVRKTVAgYXQgcnVudGltZS4KKEFCSV9WRVJTSU9OKTogQnVtcC4KLS0tCiBzcmMvY29tcC5j IHwgMjUgKysrKysrKysrKysrKysrKysrLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE4IGluc2Vy dGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2NvbXAuYyBiL3NyYy9j b21wLmMKaW5kZXggMjFkMWMxYTIzY2YwZS4uM2IwMDI1MzU3NjhiNCAxMDA2NDQKLS0tIGEvc3Jj L2NvbXAuYworKysgYi9zcmMvY29tcC5jCkBAIC00MTYsNyArNDE2LDcgQEAgbG9hZF9nY2NqaXRf aWZfbmVjZXNzYXJ5IChib29sIG1hbmRhdG9yeSkKIAogDAogLyogSW5jcmVhc2UgdGhpcyBudW1i ZXIgdG8gZm9yY2UgYSBuZXcgVmNvbXBfYWJpX2hhc2ggdG8gYmUgZ2VuZXJhdGVkLiAgKi8KLSNk ZWZpbmUgQUJJX1ZFUlNJT04gIjEiCisjZGVmaW5lIEFCSV9WRVJTSU9OICIyIgogCiAvKiBMZW5n dGggb2YgdGhlIGhhc2hlcyB1c2VkIGZvciBlbG4gZmlsZSBuYW1pbmcuICAqLwogI2RlZmluZSBI QVNIX0xFTkdUSCA4CkBAIC02NDAsNyArNjQwLDkgQEAgI2RlZmluZSBOVU1fQ0FTVF9UWVBFUyAx NQogICAgIGhlbHBlcl9QU0VVRE9WRUNUT1JfVFlQRVBfWFVOVEFHLAogICAgIHB1cmVfd3JpdGVf ZXJyb3IsCiAgICAgcHVzaF9oYW5kbGVyLAorI2lmZGVmIFdJTkRPV1NOVAogICAgIFNFVEpNUF9O QU1FLAorI2VuZGlmCiAgICAgcmVjb3JkX3Vud2luZF9wcm90ZWN0X2V4Y3Vyc2lvbiwKICAgICBo ZWxwZXJfdW5iaW5kX24sCiAgICAgaGVscGVyX3NhdmVfcmVzdHJpY3Rpb24sCkBAIC0xOTI5LDgg KzE5MzEsMjAgQEAgZW1pdF9zZXRqbXAgKGdjY19qaXRfcnZhbHVlICpidWYpCiB7CiAjaWZuZGVm IFdJTkRPV1NOVAogICBnY2Nfaml0X3J2YWx1ZSAqYXJnc1tdID0ge2J1Zn07Ci0gIHJldHVybiBl bWl0X2NhbGwgKGludGVybl9jX3N0cmluZyAoU1RSIChTRVRKTVBfTkFNRSkpLCBjb21wLmludF90 eXBlLCAxLCBhcmdzLAotICAgICAgICAgICAgICAgICAgIGZhbHNlKTsKKyAgZ2NjX2ppdF9wYXJh bSAqcGFyYW1zW10gPQorICAgIHsKKyAgICAgIGdjY19qaXRfY29udGV4dF9uZXdfcGFyYW0gKGNv bXAuY3R4dCwgTlVMTCwgY29tcC52b2lkX3B0cl90eXBlLCAiYnVmIiksCisgICAgfTsKKyAgLyog RG9uJ3QgY2FsbCBzZXRqbXAgdGhyb3VnaCBhIGZ1bmN0aW9uIHBvaW50ZXIgKEJ1ZyM0NjgyNCkg Ki8KKyAgcmV0dXJuIGdjY19qaXRfY29udGV4dF9uZXdfY2FsbCAoY29tcC5jdHh0LAorCQkJCSAg IE5VTEwsCisJCQkJICAgZ2NjX2ppdF9jb250ZXh0X25ld19mdW5jdGlvbgorCQkJCSAgIChjb21w LmN0eHQsIE5VTEwsIEdDQ19KSVRfRlVOQ1RJT05fSU1QT1JURUQsCisJCQkJICAgIGNvbXAuaW50 X3R5cGUsIFNUUiAoU0VUSk1QX05BTUUpLAorCQkJCSAgICBBUlJBWUVMVFMgKHBhcmFtcyksIHBh cmFtcywKKwkJCQkgICAgZmFsc2UpLAorCQkJCSAgIDEsCisJCQkJICAgYXJncyk7CiAjZWxzZQog ICAvKiBfc2V0am1wIChidWYsIF9fYnVpbHRpbl9mcmFtZV9hZGRyZXNzICgwKSkgKi8KICAgZ2Nj X2ppdF9ydmFsdWUgKmFyZ3NbMl07CkBAIC0yNjYyLDEwICsyNjc2LDcgQEAgI2RlZmluZSBBRERf SU1QT1JURUQoZl9uYW1lLCByZXRfdHlwZSwgbmFyZ3MsIGFyZ3MpCQkJICAgICAgIFwKICAgYXJn c1sxXSA9IGNvbXAuaW50X3R5cGU7CiAgIEFERF9JTVBPUlRFRCAocHVzaF9oYW5kbGVyLCBjb21w LmhhbmRsZXJfcHRyX3R5cGUsIDIsIGFyZ3MpOwogCi0jaWZuZGVmIFdJTkRPV1NOVAotICBhcmdz WzBdID0gZ2NjX2ppdF90eXBlX2dldF9wb2ludGVyIChnY2Nfaml0X3N0cnVjdF9hc190eXBlIChj b21wLmptcF9idWZfcykpOwotICBBRERfSU1QT1JURUQgKFNFVEpNUF9OQU1FLCBjb21wLmludF90 eXBlLCAxLCBhcmdzKTsKLSNlbHNlCisjaWZkZWYgV0lORE9XU05UCiAgIGFyZ3NbMF0gPSBnY2Nf aml0X3R5cGVfZ2V0X3BvaW50ZXIgKGdjY19qaXRfc3RydWN0X2FzX3R5cGUgKGNvbXAuam1wX2J1 Zl9zKSk7CiAgIGFyZ3NbMV0gPSBjb21wLnZvaWRfcHRyX3R5cGU7CiAgIEFERF9JTVBPUlRFRCAo U0VUSk1QX05BTUUsIGNvbXAuaW50X3R5cGUsIDIsIGFyZ3MpOwotLSAKMi4zMC4xCgo= --0000000000008da23905bc793b8b--