From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36447: 27.0.50; New "Unknown keyword" errors Date: Tue, 2 Jul 2019 22:50:54 +0000 Message-ID: References: <875zon7x0a.fsf@web.de> <8336jqgbhp.fsf@gnu.org> <87h886eoke.fsf@web.de> <87d0iu54d1.fsf@gmail.com> <87k1d14djr.fsf@web.de> <87h884fo0i.fsf@web.de> <85d0is5ry1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000452e05058cba9622" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="101696"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Michael Heerdegen , 36447@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 03 00:52:41 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiRde-000QHv-LD for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Jul 2019 00:52:38 +0200 Original-Received: from localhost ([::1]:58128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiRdY-0007pR-Tu for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 18:52:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44309) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiRdF-0007o7-S9 for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 18:52:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiRd5-0002E4-KY for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 18:52:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39316) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiRd3-0002BI-Pa for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 18:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiRd3-0007Ku-Mi for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 18:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 22:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36447 X-GNU-PR-Package: emacs Original-Received: via spool by 36447-submit@debbugs.gnu.org id=B36447.156210790528176 (code B ref 36447); Tue, 02 Jul 2019 22:52:01 +0000 Original-Received: (at 36447) by debbugs.gnu.org; 2 Jul 2019 22:51:45 +0000 Original-Received: from localhost ([127.0.0.1]:48137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiRcm-0007KN-HV for submit@debbugs.gnu.org; Tue, 02 Jul 2019 18:51:44 -0400 Original-Received: from mail-ot1-f67.google.com ([209.85.210.67]:38279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiRck-0007K9-Cz for 36447@debbugs.gnu.org; Tue, 02 Jul 2019 18:51:43 -0400 Original-Received: by mail-ot1-f67.google.com with SMTP id d17so255867oth.5 for <36447@debbugs.gnu.org>; Tue, 02 Jul 2019 15:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1LNv6xei6ootckOZp6IeCdQ0hlg/nr4MyByY3oZix98=; b=f+WX7h0C5WsRNFKki/W0eQhuAELnGjJoZo66L6NEyU08NR9OMR4hKDg1J814rbbbZw +kd9m/mjs51iK64hZD2zkt05OEiXs1tme6FkYcKqUrC8UAblEeyaAWdOyCjqUVBw1H6r nNebQ0LrwEiM0e/vn3Fl1IxNtRlf6C3dhtYY0JMk9TgMTXfGYffE684BRS/SWts7sB92 kNWOFETJmZUJ/OKoM10Em6vNcTGbuX2nfHCYkTZoDAAD+DM4EwBp0ZN6gw9zNTPPyjJO G+vlwRxgudbyjvdDTekKl/VxxwxtejofyQDGojqLfGMQzcaHrR2vNimD54lYRDluaVRS tB/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1LNv6xei6ootckOZp6IeCdQ0hlg/nr4MyByY3oZix98=; b=DiTJTT/Pczx9WM9AG0Xq+cDUk0py3kMae78EzdANXaFWzgeeGHAHticbGxS87Lu2N0 9by9aO6BgNp0raTKKOEAjKAonsTtkh4CyKHNuNBgmaKcNOu/3c0um4YJFVQa0xZcS4OH BQtjQMd/jwXoeOxs5nwcL3/e5OQ6fxnVOUqieScFcPxi7eS70WGcMZ8APyNJArj3dqcV cnfoaKA5KgazzQVP/fGm9Ekd9RPB/hAk2SLZHw6bFU0Ys7MUqx3p4C+A4v+KxsotKE2r AYeGrNOkTrw1k2IoKW+Ach/IVXanNy3+mbBFMRFqh0GgwmTAxFV8A4HdajKKgXWWlsvX XTKw== X-Gm-Message-State: APjAAAXUGZZeQdQ6R361jrCGt+NZ45wbGdi2aAQcgi3LYzXCuzfD4yJR FeEvdI8wgjz2rnP15gSNowozelMzLbLj0vPCdxs= X-Google-Smtp-Source: APXvYqyx3eQ6MmY6lEKQNaVOd6zUOTwINZmjCenBqWR0eRzLfwJZUlaEDxgGhTFqH0aEBe42riBwWUNUuDMXigO2Xik= X-Received: by 2002:a9d:7352:: with SMTP id l18mr7528706otk.292.1562107896465; Tue, 02 Jul 2019 15:51:36 -0700 (PDT) In-Reply-To: <85d0is5ry1.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161994 Archived-At: --000000000000452e05058cba9622 Content-Type: text/plain; charset="UTF-8" On Tue, Jul 2, 2019 at 4:20 PM Noam Postavsky wrote: > Michael Heerdegen writes: > > Pip Cet writes: > >> > Hmm - seems so, yes. I just made bootstrap with the commit > >> > included, and the problem is still gone. Strange thing, but seems > >> > there is nothing to fix. > >> > >> I'm not sure I agree. Something went wrong somewhere, or we wouldn't > >> have called byte code with what looks like an invalid hash table. > > > > Did you reply to the wrong thread - or - where is a connection to hash > > tables? > > The compiler translates repeated `eq' in a cond like that into a hash > and jump. See byte-compile-cond-use-jump-table. I think I found the problem. It's a bit tricky. When we purecopy the hash tables emitted by the byte code compiler, Vpurify_flag is a hash table with predicate 'equal. That means the ->next vectors for different hash tables now might refer to the same pure vector. Rehashing such a hash table thus destroys another hash table's ->next vector, so it shouldn't happen. pdumper.c forces rehashing of many hash tables, including pure ones. The attached patch "fixes" things, at a high price. I'll try coming up with a proper fix soon if no one beats me to it. (To reproduce the problem, I added these lines to fn.c: DEFSYM (QCrehash_size, ":rehash-size"); DEFSYM (QCrehash_threshold, ":rehash-threshold"); DEFSYM (QCweakness, ":weakness"); + DEFSYM (QCgroup, ":group"); + DEFSYM (QCversion, ":version"); + DEFSYM (QCpackage_version, ":package-version"); + DEFSYM (QClink, ":link"); + DEFSYM (QCload, ":load"); + DEFSYM (QCtag, ":tag"); + DEFSYM (QCset_after, ":set-after"); DEFSYM (Qkey, "key"); DEFSYM (Qvalue, "value"); ) --000000000000452e05058cba9622 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-bug-36477.patch" Content-Disposition: attachment; filename="0001-Fix-bug-36477.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxmeo6un0 RnJvbSAyMGI2M2RjZTE2OTVjZmMyZGZhOTQ5NjFkMDNkYTg4YTRjY2VhZmZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBUdWUs IDIgSnVsIDIwMTkgMjI6NDg6MjMgKzAwMDAKU3ViamVjdDogW1BBVENIXSBGaXggYnVnIzM2NDc3 CgotLS0KIHNyYy9mbnMuYyB8IDUgKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMo KykKCmRpZmYgLS1naXQgYS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggMmZjMDAwYTdmNC4u Mzc1YjdkMjg0MSAxMDA2NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNDIy Myw2ICs0MjIzLDExIEBAIGhhc2hfdGFibGVfcmVoYXNoIChzdHJ1Y3QgTGlzcF9IYXNoX1RhYmxl ICpoKQogewogICBwdHJkaWZmX3Qgc2l6ZSA9IEhBU0hfVEFCTEVfU0laRSAoaCk7CiAKKyAgaC0+ bmV4dCA9IEZjb3B5X3NlcXVlbmNlIChoLT5uZXh0KTsKKyAgaC0+aW5kZXggPSBGY29weV9zZXF1 ZW5jZSAoaC0+aW5kZXgpOworICBoLT5oYXNoID0gRmNvcHlfc2VxdWVuY2UgKGgtPmhhc2gpOwor ICBoLT5rZXlfYW5kX3ZhbHVlID0gRmNvcHlfc2VxdWVuY2UgKGgtPmtleV9hbmRfdmFsdWUpOwor CiAgIC8qIFJlY29tcHV0ZSB0aGUgYWN0dWFsIGhhc2ggY29kZXMgZm9yIGVhY2ggZW50cnkgaW4g dGhlIHRhYmxlLgogICAgICBPcmRlciBpcyBzdGlsbCBpbnZhbGlkLiAgKi8KICAgZm9yIChwdHJk aWZmX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpCi0tIAoyLjIwLjEKCg== --000000000000452e05058cba9622--