From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373) Date: Fri, 3 Jan 2020 20:49:35 +0000 Message-ID: References: <20191226000417.69183-1-phst@google.com> <83v9psgz1x.fsf@gnu.org> <83sgkwguxm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000b6c087059b427452" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255139"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 30373@debbugs.gnu.org, p.stephani2@gmail.com, sjindel@google.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 03 21:51:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1inTuZ-0014EV-4e for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2020 21:51:11 +0100 Original-Received: from localhost ([::1]:56712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inTuX-0005Ym-Mo for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Jan 2020 15:51:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41570) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inTuS-0005Yg-1B for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 15:51:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inTuQ-0002ES-Qv for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 15:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35768) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inTuQ-0002DX-FP for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 15:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inTuQ-0006Rl-AC for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2020 15:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2020 20:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30373 X-GNU-PR-Package: emacs Original-Received: via spool by 30373-submit@debbugs.gnu.org id=B30373.157808462024714 (code B ref 30373); Fri, 03 Jan 2020 20:51:02 +0000 Original-Received: (at 30373) by debbugs.gnu.org; 3 Jan 2020 20:50:20 +0000 Original-Received: from localhost ([127.0.0.1]:41733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inTtj-0006QY-Qn for submit@debbugs.gnu.org; Fri, 03 Jan 2020 15:50:20 -0500 Original-Received: from mail-ot1-f53.google.com ([209.85.210.53]:40598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1inTth-0006QI-DR for 30373@debbugs.gnu.org; Fri, 03 Jan 2020 15:50:17 -0500 Original-Received: by mail-ot1-f53.google.com with SMTP id w21so54868094otj.7 for <30373@debbugs.gnu.org>; Fri, 03 Jan 2020 12:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tU7AimXqGjLqElyss63cLIMl8kA90AVJ7crr/2f5LzQ=; b=G6xhYKFQIIMsR+uuL419ke6q7IwK0l9rvt36CVSVRDcYjOmKAkyQ+tOkIVDwP2jUm6 +v4ZzVhLkB7LiDjw2I7x2V4uVjAWkUrTknXkQbJ+lh5R40tpn3no33qfjQF6RPdkfCE7 AqPnmwfo5/8Zrzsli+RYy3UVjXH+1FL8EPckgPTWbVMwIR71Bm8xuX3yH/EXYmN+MUz9 LfAYMrt6e+8MRvg9xYc8L7jJgxmUf3z7ymlo/wTuwxG8wTWr3JCJVNZTu/mO9B1rWpTO PLOQb7cNWfCRwTceAhtWz+7bzUI22oaYAqHrGia+oipuEoQK111KFHSOwwycYbKNQ0GK D3og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tU7AimXqGjLqElyss63cLIMl8kA90AVJ7crr/2f5LzQ=; b=N7pk13SL2zaWT3k4Fyq70QxcUj/KM81HNuGDII3dY8ZjyyK3XWJKHez1sxfqr0Tpgn Y1jgAAmKjRX3/gOfgvXFYA4xfVNzG5tGaKV08LfUtDGMPxtbKiGgxmaG7XF47ekZ0k64 geRNIKrG9/wt3/5LySBa1a7RjT2gvMge56fC6fac4/oSAw42tPLYppZC1qjxSXxloggW J6+CCe5i1Bugr9gXOSiAwtoRKjUR7tp5hvKrMRD7lq6C8yvTtIGSttZa3PxHWerQd/l3 ZBHs26J8FDK90Bf9g3v1uHidhGYaEFin7Zh9icGiFjCiUSTikx8SFhg1ycTM7arAfxbP ggpA== X-Gm-Message-State: APjAAAUBOEgkDc+g2Ot0Qe3POjQ6gvWjcurs34TOHu6HjFpNPru9Hy1J P1vzkTWQVwg+gP3muJ1LB/SyI8yKV7Yn45icxmI= X-Google-Smtp-Source: APXvYqx85DwWn0oKexW+O0oVodlRPOBTrlZhWAxsda5HtpGgJFKKxLP7unuRGq3sHAoyYRcpkarlrWnxQ+ukTNu9FbA= X-Received: by 2002:a05:6830:1bd5:: with SMTP id v21mr106477326ota.154.1578084611823; Fri, 03 Jan 2020 12:50:11 -0800 (PST) In-Reply-To: <83sgkwguxm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174134 Archived-At: --000000000000b6c087059b427452 Content-Type: text/plain; charset="UTF-8" On Fri, Jan 3, 2020 at 8:13 PM Eli Zaretskii wrote: > > From: Pip Cet > > Date: Fri, 3 Jan 2020 18:53:46 +0000 > > Cc: Philipp Stephani , 30373@debbugs.gnu.org, sjindel@google.com > > > > If I'm reading the test correctly, it depends on garbage-collect > > actually collecting an unreferenced vector; since our GC's > > conservative, that might not be working for you, if a word that > > happens to look like a reference to the vector is still on the stack. > > (Or it might be something else entirely, but I don't think the test as > > it stands is correct). > > You are probably right, because I see the same failure on GNU/Linux, > in an x86_64 unoptimized build: I see it too. Fprogn keeps the value of the first sub-form alive while evaluating the second one. We can "fix" Fprogn to discard val early in unoptimized builds, and that might make GC behavior slightly less surprising. But it won't properly fix this test. --000000000000b6c087059b427452 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-progn-make-huge-vector-garbage-collect-behave-a.patch" Content-Disposition: attachment; filename="0001-Make-progn-make-huge-vector-garbage-collect-behave-a.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k4ymt5fv0 RnJvbSAyYzE1NTMzY2NjYmNkMTYyMmRiNzMzNjIxOTVlODZmOWMzNDUzMWU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBGcmks IDMgSmFuIDIwMjAgMjA6NDc6NTAgKzAwMDAKU3ViamVjdDogW1BBVENIXSBNYWtlIChwcm9nbiAo bWFrZS1odWdlLXZlY3RvcikgKGdhcmJhZ2UtY29sbGVjdCkpIGJlaGF2ZSBhcwogZXhwZWN0ZWQK Ci0tLQogc3JjL2V2YWwuYyB8IDEgKwogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpk aWZmIC0tZ2l0IGEvc3JjL2V2YWwuYyBiL3NyYy9ldmFsLmMKaW5kZXggNjY3NTJhMzk3Yy4uZWI5 MDE4ZjY2YSAxMDA2NDQKLS0tIGEvc3JjL2V2YWwuYworKysgYi9zcmMvZXZhbC5jCkBAIC00NTcs NiArNDU3LDcgQEAgREVGVU4gKCJwcm9nbiIsIEZwcm9nbiwgU3Byb2duLCAwLCBVTkVWQUxMRUQs IDAsCiAKICAgd2hpbGUgKENPTlNQIChib2R5KSkKICAgICB7CisgICAgICAvKiBEb24ndCBrZWVw IFZBTCBhbGl2ZSB1bm5lY2Vzc2FyaWx5IChidWcjMzAzNzMpLiAgKi8KICAgICAgIHZhbCA9IFFu aWw7CiAgICAgICBMaXNwX09iamVjdCBmb3JtID0gWENBUiAoYm9keSk7CiAgICAgICBib2R5ID0g WENEUiAoYm9keSk7Ci0tIAoyLjI0LjAKCg== --000000000000b6c087059b427452--