From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper Date: Sun, 21 Jul 2019 05:34:50 +0000 Message-ID: References: <6a260307-a463-bd08-8a10-d7664d0606a2@cs.ucla.edu> <74235afc-7043-1da7-7c71-07f0ca23b9fd@cs.ucla.edu> <83r26mv53z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191081"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36597@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 21 07:36:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hp4Vz-000nb7-IB for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2019 07:36:07 +0200 Original-Received: from localhost ([::1]:54562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hp4Vy-0006TL-7f for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2019 01:36:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44766) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hp4Vv-0006T2-IY for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 01:36:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hp4Vu-0007vP-Jn for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 01:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hp4Vu-0007vA-Fv for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 01:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hp4Vu-0002gO-A2 for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2019 01:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jul 2019 05:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36597 X-GNU-PR-Package: emacs Original-Received: via spool by 36597-submit@debbugs.gnu.org id=B36597.156368733310268 (code B ref 36597); Sun, 21 Jul 2019 05:36:02 +0000 Original-Received: (at 36597) by debbugs.gnu.org; 21 Jul 2019 05:35:33 +0000 Original-Received: from localhost ([127.0.0.1]:58069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hp4VR-0002fX-4Q for submit@debbugs.gnu.org; Sun, 21 Jul 2019 01:35:33 -0400 Original-Received: from mail-ot1-f45.google.com ([209.85.210.45]:39186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hp4VP-0002fL-VG for 36597@debbugs.gnu.org; Sun, 21 Jul 2019 01:35:32 -0400 Original-Received: by mail-ot1-f45.google.com with SMTP id r21so30865508otq.6 for <36597@debbugs.gnu.org>; Sat, 20 Jul 2019 22:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rOMNVpzrxMfkbHfE1JGzBumrgE2BxDKkeeKuu4myLbA=; b=EG68A2v1wwQ1mMTHwWdbfGbwQQtHp6cqkpBLQTbEkSZi9LYh/jv/tLT5KqBB2ieHcR TULhMRFU2SKUnQFioLG2ifJIWucHf7otAeeUHhGiRC/aNIO5LjsKC4E69q37Akgf4Z33 lfj0eZjxkGtA82/sx8tz+EeJbno/G6srWmysV0F0nmJnakAbneoNG3WgG0nn4If7kqRU KBnolNgPyV0rNYUXc86Hmazqwtu5Asp5vlzvwvaf+V6BbiXt6LmvUhQ08yWZ1wWAG4ZU /DSAEY0RoR2LWRgW+ZGKzvrrvnAFb6amysEhbH3eqcTm4IrKubZ7je2AmZf9q5tvN8XC Ll6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rOMNVpzrxMfkbHfE1JGzBumrgE2BxDKkeeKuu4myLbA=; b=euyvf78FDDBfs9wfoRMsYzgqs/xNPHBV29fls3mmJPEAuOCXxFwhtdVVQHniyWwJnp luVyLFolPwUR3WZJ34AOxvMDdh/RJvNbVU7rlvx1ubEYHCogxdT6dqdOfx0X0DcUIUmE aSB758k4fLgHLtNi57AR058xxUJyhKKtJsQskk+3uHXwvz+73RrnzvqLWMRRpnk57CsE cVlxt7neJtNc6Ce6j1ctYPNpSoedeNS4w2KKknf73v7lqY3U+MCTZ2L6XjORt65pHdVb w7ikfvVFhoDD5xiIltnUK+JIuIf2HCsv/cYO6TUkznUTlvIAT59LB4EjjeEQ8sgfdBj8 J6hg== X-Gm-Message-State: APjAAAVkab+VxQ9ASfOw2rIWaVJBstq0Emr86jxFWaFKZhipLZIXyyJm UHJjiS9Ve+DIkR93uiZzap5QO0HcA7FtuTZoz9M= X-Google-Smtp-Source: APXvYqzhzNrWdQS8CRpgpfg6eKSXhDMebwPfm7/GOhLL26F5lvfmIbn6EWN2HcD103kV0GO9jUO6+qA/acFSWTolC48= X-Received: by 2002:a9d:664c:: with SMTP id q12mr39455625otm.175.1563687326360; Sat, 20 Jul 2019 22:35:26 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163502 Archived-At: On Sun, Jul 21, 2019 at 3:18 AM Paul Eggert wrote: > Pip Cet wrote: > > I'm currently playing around with redefining hash tables not to have > > internal freelists. That makes the hash table code a lot simpler > > overall, but some of that simplicity would be lost trying to support > > lazy hash table rehashing. > > While looking into this I discovered unlikely bugs in Emacs's hash table code > and GC that can make Emacs dump core, along with some other unlikely hash-table > bugs that can cause Emacs to report memory exhaustion when there should be > plenty of memory. I installed the attached patches to fix these problems and to > refactor to make this code easier to understand (at least for me :-). These > patches will probably affect performance analysis. Well, at least they'll require rebasing, particularly of the no-internal-freelists patch :-) While your changes are extensive, I don't see anything in there that would drastically affect performance or memory footprint. Maybe I'm missing something, though.