From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Fri, 19 Feb 2021 15:00:16 +0000 Message-ID: References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> <83im6o2n67.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12915"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 43725@debbugs.gnu.org, Stefan Monnier To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 19 16:29:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD7ib-0003Fr-TZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 16:29:21 +0100 Original-Received: from localhost ([::1]:51088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD7ia-0002Wk-RO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 10:29:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD7HD-0003hI-70 for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 10:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lD7HC-0000ty-Mr for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 10:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lD7HC-0003qy-Hk for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 10:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2021 15:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161374686014790 (code B ref 43725); Fri, 19 Feb 2021 15:01:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 19 Feb 2021 15:01:00 +0000 Original-Received: from localhost ([127.0.0.1]:50097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD7HA-0003qT-3l for submit@debbugs.gnu.org; Fri, 19 Feb 2021 10:01:00 -0500 Original-Received: from mail-ot1-f42.google.com ([209.85.210.42]:37123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD7H8-0003qE-BT for 43725@debbugs.gnu.org; Fri, 19 Feb 2021 10:00:59 -0500 Original-Received: by mail-ot1-f42.google.com with SMTP id s6so5317942otk.4 for <43725@debbugs.gnu.org>; Fri, 19 Feb 2021 07:00:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=rJqGnGWkmWlbtkQX2yXn9UnFMyJNnywOC2cwtIa5OQY=; b=OfU+xHvgxJFmbU/3MMuoDc57kkR9BBB0yaWwGy1M8IyZaizio0YgKcVaXtHDh1FIlz OxXztP8uVHfSJbwSkXclx8dQxePfEybre9QrzqTRAZPVBWbr8BVLgOT7avSHTrTv2L30 MR7oBAQBz6tOGbGl7aL3Hpd7qdf/7dl+00XPnM7WApDpI0TvpKY1snj/Uj8PLk1SKehe frU89Rg1HgcjzXcKGYjdnKMEz5KXfQc+exhRHCSFj/5KQ9fv95G/oxfXps1k6u7HZnxn 8Fm/KbTVl7uLhl1PVzAGskhiEsvY+EVN3Lm7Z162ROWABxf4qMI1nrJJgfQxCSc4S8B6 XobA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rJqGnGWkmWlbtkQX2yXn9UnFMyJNnywOC2cwtIa5OQY=; b=XvJ5Z20/d414doHrm7y7sFhDSZJkVnBsJ+lflQxK+qU1QlyBG3yUrMChrFd7vIF8qs HVNwZw07RCeYMOi6d5nro9WdRKIGmEZEHONN1twcIZmz/aInyY26LDCcU0Vwk+D+PrZQ 4pbpubSBfZa793nskpX25JSozgQ5spfaUDlV7Gx735Od1jSPbrBBb7z/2gmKkH1rFwaz 1UZlv9ChKo0bilfGXJbDVWh9SBTMXao96Id7uYohEKxnrkDRvD1Z8wjkdkhDlsslH94S UDnHi2l0eAf1kbICZ4oLaKyTJ6N010iS+LOnitIDWUkcMBcU10XC9QCS0ZLEEotyLYY9 FjBg== X-Gm-Message-State: AOAM530eQfEW1rBYO4Sy9ERnHwwGGBDyPw0zq4ZBMiUJW3vQyHA1lktx HrO4ivJIK5joqgC2MWNSWkkA8ReQDSRp69S4seE= X-Google-Smtp-Source: ABdhPJxtY/wmUyd0eTU8QupCjHG/TbzF/mk2ZoUereRKxNz/wLwCOgY5UVyOCjq/FlQtvZbR9yQFbwlOONZVJ7Fb8Fs= X-Received: by 2002:a05:6830:1682:: with SMTP id k2mr7139942otr.154.1613746852576; Fri, 19 Feb 2021 07:00:52 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200345 Archived-At: On Fri, Feb 19, 2021 at 2:35 PM Andrea Corallo wrote: > > On Fri, Feb 19, 2021 at 2:16 PM Andrea Corallo wrote: > >> >> > comp.c:1174:22: warning: logical =E2=80=98or=E2=80=99 of collecti= vely exhaustive tests is always true [-Wlogical-op] > >> >> > 1174 | if (val > LONG_MAX || val < LONG_MIN) > >> >> > | ^~ > >> >> > > >> >> > Not sure what's the best way to silence it or if we want to rever= t to > >> >> > the previous formulation. > >> >> > >> >> Maybe it's me, but I had a hard time parsing that warning. IIUC, th= e > >> >> tests are both trivially false? And oring two trivially false > >> >> conditions shouldn't trigger a warning, should it? > >> > > >> > No, I think it tries to say that val is always either greater than > >> > LONG_MAX or smaller than LONG_MIN. > >> > >> Exactly, the warning is about the fact that all the other conditions > >> will never be evaluated. The phrasing is admittedly quite cryptic tho= . > > > > I thought you said this was a setup where the argument _does_ fit a lon= g? > > There we are dispatching if 'val' can be expressed or not with a long. > > 'val' is an EMACS_INT so depending on the configuration it might fit in > a long by definition, when this happen GCC sees the first condition in > or as always true etc etc... :) So val is greater than LONG_MAX? How can this happen? I've got some initial results here that seem to show a serious bug in my backend in this situation, and I hope it's not a gcc bug...