From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Sun, 7 Mar 2021 21:27:57 +0000 Message-ID: References: <865z3866my.fsf@gmail.com> <865z38a9vo.fsf@gmail.com> <86eehujcip.fsf@gmail.com> <86blch14qt.fsf@gmail.com> <83h7m84h9g.fsf@gnu.org> <86v9ao5czu.fsf@gmail.com> <86wnutogrh.fsf@gmail.com> <86wnut8fb9.fsf@gmail.com> <861rd1tbpa.fsf@gmail.com> <83pn0km6y3.fsf@gnu.org> <86ft1f8ara.fsf@gmail.com> <83sg5cjdn8.fsf@gnu.org> <83r1kwjcy2.fsf@gnu.org> <8335x6u9o4.fsf@gnu.org> <83zgzesrku.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000d78f3c05bcf8ff60" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19615"; mail-complaints-to="usenet@ciao.gmane.io" Cc: andrewjmoreton@gmail.com, 46256@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 07 22:29:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJ0xk-0004zk-QP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 22:29:20 +0100 Original-Received: from localhost ([::1]:43464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJ0xj-0005HD-Sp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 16:29:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJ0xT-00057d-Gq for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 16:29:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJ0xT-0007gb-9F for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 16:29:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJ0xT-00013G-57 for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 16:29:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Mar 2021 21:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.16151525203976 (code B ref 46256); Sun, 07 Mar 2021 21:29:03 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 7 Mar 2021 21:28:40 +0000 Original-Received: from localhost ([127.0.0.1]:41654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJ0x6-000123-Ep for submit@debbugs.gnu.org; Sun, 07 Mar 2021 16:28:40 -0500 Original-Received: from mail-ot1-f52.google.com ([209.85.210.52]:41951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJ0x5-00011p-FU for 46256@debbugs.gnu.org; Sun, 07 Mar 2021 16:28:39 -0500 Original-Received: by mail-ot1-f52.google.com with SMTP id f8so2298199otp.8 for <46256@debbugs.gnu.org>; Sun, 07 Mar 2021 13:28:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2NEeVZ/SqZCObcP5xtO4p/OmWMhixOjwTD8G7X2o8Bw=; b=benJTo5Xa4FtzrI/JC+kEPUzWx31n4dDjhHJv18y4veZEgDbyk6zPY9+dyoiyCKrlF i7kbeO/FZsjJdT5+OjAKpsppevzT61+3WNUoPkAbA+8IXPsl4+CfLPsl2Y2Fvpg6TE7K Lh65q7a8HrKds1rwU68nTDW+YVijpCf6rh4swZ6PNCJTcPSlgLK5c4+/3SviniVkq0yz CSd/9luYpYR32dtbUdnkI9izlTfIZ9nxDWVL7RUPpPQuvELNcuWjVudryL0iGII4fgHj ogG+VR61R5upYFm5B4xsRYtuuSVZEsk3fO/2CoTfH7ZLFY2yPrTFMlTmtzRN+RdR6Eva U93Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2NEeVZ/SqZCObcP5xtO4p/OmWMhixOjwTD8G7X2o8Bw=; b=W14XfcjCa3sL3cyZVWFBovO4wYlxgKqCz+8qjf+TcDETR86pfuTKFpujCG7uvuDKP3 roBpc/ZERRADy1lDPAKAR5sr+UzbHgqOBaOevkqW1fGYCVcqMqfxrKHIhHt8L8hk3cfW wBmkUskxG7YCxuL4JY13TTEZJWKTp50LdbYFGagYg8tod1guRC5U76bjpDrwbBD8A8nh weFT/9KukWgiVj+a72AzCADbuOFGqSggMAhUVJfbnY45aJckIESidrn4GUSecTDF6nz3 aW3aGNVaztNtwf3b+R3rRGDgZP2Uv8S/lZ2BiZj3MZBfy+GOtqsiCq1G7hZwUnalKg4c /5Og== X-Gm-Message-State: AOAM531jK7e8xUtPOXgEN89XrRyLo8XpdBwxnZKclxHYNlmo1eBufc4H thvRr9dZqXKOqfTUS9wK/gpz9vdRwwBSDbdM5Mw= X-Google-Smtp-Source: ABdhPJz6D2SAZ53xthjBZuHoISrE2HnSxmMXKfo11pIuLAN/bGGyxMdf7U+6sLDEDUEvn7EofbTy7pnVjbb0DtqzmJA= X-Received: by 2002:a05:6830:1e51:: with SMTP id e17mr17095788otj.292.1615152513775; Sun, 07 Mar 2021 13:28:33 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201787 Archived-At: --000000000000d78f3c05bcf8ff60 Content-Type: text/plain; charset="UTF-8" On Sun, Mar 7, 2021 at 8:17 PM Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Eli Zaretskii writes: > >> From: Andrea Corallo > >> Cc: 46256@debbugs.gnu.org, andrewjmoreton@gmail.com > >> Date: Sun, 07 Mar 2021 18:53:50 +0000 > What I think is going on here: > > The same .eln file is loaded two times, we detect that and try to reuse > the same compilation unit (the Lisp object) instead of a new one. > > We keep a pointer to the compilation unit representing the .eln file in > each .eln. Here we read it and we have it into 'saved_cu', we try to > dereference it and extract the CU with XNATIVE_COMP_UNIT but something > goes wrong. > > This object might have been GC'ed for some reason and we might be > looking at the same GC issue I've seen on 32bit wide-int (my guess). > *If* this is the case the question is: why is the CU GC'ed? Why wouldn't it be? I'm trying to follow along here :-) What I'm thinking is the CU got GC'ed, which is perfectly okay, but we never set its COMP_UNIT_SYM pointer to Qnil. Then we dlopen() the same file again, get the old handle, read the stale COMP_UNIT_SYM pointer, and dereference it. We should verify that the CU is indeed a different PVEC type now (ideally, PVEC_FREE), and then do something like the attached patch, shouldn't we? Pip --000000000000d78f3c05bcf8ff60 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-a-GC-issue-bug-46256.patch" Content-Disposition: attachment; filename="0001-Fix-a-GC-issue-bug-46256.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_klzo2xaz0 RnJvbSAyMzQ5NmQ4NzkzYzQ3NWI0NTFhMGQ4ZmMzNWIyNzgxZTljNDc0NmE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaXAgQ2V0IDxwaXBjZXRAZ21haWwuY29tPgpEYXRlOiBTdW4s IDcgTWFyIDIwMjEgMjE6MjY6MjkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBGaXggYSBHQyBpc3N1 ZSAoYnVnIzQ2MjU2KQoKKiBzcmMvYWxsb2MuYyAoY2xlYW51cF92ZWN0b3IpOiBDbGVhciB0aGUg Y29tcCB1bml0IHBvaW50ZXIgaW4gdGhlCmR5bmFtaWNhbGx5LWxvYWRlZCBvYmplY3QuCi0tLQog c3JjL2FsbG9jLmMgfCAzICsrKwogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQoKZGlm ZiAtLWdpdCBhL3NyYy9hbGxvYy5jIGIvc3JjL2FsbG9jLmMKaW5kZXggYWYwODMzNjE3NzA3MC4u ZTAzOTQ0MWVhODI2YyAxMDA2NDQKLS0tIGEvc3JjL2FsbG9jLmMKKysrIGIvc3JjL2FsbG9jLmMK QEAgLTMxNTUsOSArMzE1NSwxMiBAQCBjbGVhbnVwX3ZlY3RvciAoc3RydWN0IExpc3BfVmVjdG9y ICp2ZWN0b3IpCiAgIGVsc2UgaWYgKE5BVElWRV9DT01QX0ZMQUcKIAkgICAmJiBQU0VVRE9WRUNU T1JfVFlQRVAgKCZ2ZWN0b3ItPmhlYWRlciwgUFZFQ19OQVRJVkVfQ09NUF9VTklUKSkKICAgICB7 CisjZGVmaW5lIENPTVBfVU5JVF9TWU0gImNvbXBfdW5pdCIKICAgICAgIHN0cnVjdCBMaXNwX05h dGl2ZV9Db21wX1VuaXQgKmN1ID0KIAlQU0VVRE9WRUNfU1RSVUNUICh2ZWN0b3IsIExpc3BfTmF0 aXZlX0NvbXBfVW5pdCk7CiAgICAgICBlYXNzZXJ0IChjdS0+aGFuZGxlKTsKKyAgICAgIExpc3Bf T2JqZWN0ICpzYXZlZF9jdSA9IGR5bmxpYl9zeW0gKGN1LT5oYW5kbGUsIENPTVBfVU5JVF9TWU0p OworICAgICAgKnNhdmVkX2N1ID0gUW5pbDsKICAgICAgIGR5bmxpYl9jbG9zZSAoY3UtPmhhbmRs ZSk7CiAgICAgfQogICBlbHNlIGlmIChOQVRJVkVfQ09NUF9GTEFHCi0tIAoyLjMwLjEKCg== --000000000000d78f3c05bcf8ff60--