From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Fri, 5 Mar 2021 15:18:12 +0000 Message-ID: References: <86wnut8fb9.fsf@gmail.com> <861rd1tbpa.fsf@gmail.com> <83pn0km6y3.fsf@gnu.org> <86ft1f8ara.fsf@gmail.com> <83sg5cjdn8.fsf@gnu.org> <83r1kwjcy2.fsf@gnu.org> <83k0qoj9zv.fsf@gnu.org> <83im68j963.fsf@gnu.org> <83tuprhur0.fsf@gnu.org> <831rcu25o2.fsf@gnu.org> <83v9a6zr22.fsf@gnu.org> <83o8fyzjrz.fsf@gnu.org> <83wnulyfv8.fsf@gnu.org> <83lfb1y7la.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35077"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46256@debbugs.gnu.org, Andrea Corallo To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 05 16:29:45 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lICOe-0008zD-9A for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 16:29:44 +0100 Original-Received: from localhost ([::1]:46294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lICOd-0000GO-BV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Mar 2021 10:29:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lICEH-00083K-Uw for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 10:19:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lICEH-0003bA-N7 for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 10:19:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lICEH-0003w8-Im for bug-gnu-emacs@gnu.org; Fri, 05 Mar 2021 10:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Mar 2021 15:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.161495753615118 (code B ref 46256); Fri, 05 Mar 2021 15:19:01 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 5 Mar 2021 15:18:56 +0000 Original-Received: from localhost ([127.0.0.1]:35153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lICEC-0003vl-CC for submit@debbugs.gnu.org; Fri, 05 Mar 2021 10:18:56 -0500 Original-Received: from mail-oi1-f175.google.com ([209.85.167.175]:41149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lICEA-0003vY-54 for 46256@debbugs.gnu.org; Fri, 05 Mar 2021 10:18:55 -0500 Original-Received: by mail-oi1-f175.google.com with SMTP id o3so2854608oic.8 for <46256@debbugs.gnu.org>; Fri, 05 Mar 2021 07:18:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kOicbhMbWUe89WNUU3S9cZ46hI1eA4GazUdr1apODPw=; b=B6Ax0jrW06a9pijym7z4iK4ChnLyxpEOi+bLVT3gjQhmOCRy07jiqMCjbwpYmpkFjI hzmqse9WL3tSu6Oe09Rof8BKxJptwpDeZIyTNSceb+VzmoiSSx1UjzQkPByYo6IddVwy zHcwZRAkQfAxr5b2oKvk/VTnZm/GB8QrvOQkmkAPVCYG0CXj20C4Fco8siPucWvxQs9C 2MVOeqVuDo/PTt8ouuBbfXEeofgq/u7pQKGNDdEZc5FBC4wOLB8SpsFELefvnW0sOYuX rrm3WDBQi9b9PMB5xyQP9o1tirxbWQzy5vdLn8tquYm2D3raFVaZvSFUtORk9KSY8Xkw Ge1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kOicbhMbWUe89WNUU3S9cZ46hI1eA4GazUdr1apODPw=; b=B+J6DLJUxN0/3aGUTnuflZ1+nEStKhMo2rE3hqxVQn/8J4xYzbby9GW2HJ6N8EuXDn de6Ymvz6JUy6EoxhJml/zBCM2deaGzpOYZGuWe7KNaANf69iUX9VElKrGHbT3/2LbeAi eY0lFDXlUNLjRFtnQVUcaqRokVzuzF2XE2V5lxJOujpipqhNUUGamoYvGXpHb5qO38r5 4yRmKkostnyD3+bYGXeM4LsmrvgEEoJq7DdKeaHYI5t4WOjXegJ/KtHuDftij887VikR XjOVmiNLVzOmJCLvoezxB1D+cDUJFMMpye9kw6HfLDOQmQaQo/EwhNtpYmQHXS0JdBq4 jBSA== X-Gm-Message-State: AOAM531sDFppFj7lgaruSi4E+j5s+HZ956TflyF2TDt5eAlIwPGS5IFy Yzhfl+8V7KJUEOF+4Eu8oWTGoVz0cweCk3fWP1U= X-Google-Smtp-Source: ABdhPJynfDOuHRxSbrv2KElRdAvXaDwW1WJ+i91OypxBnTQmp5ziMupBW8Tezhh7fFPfnhApe8Jj084hgQO+41FjCfw= X-Received: by 2002:aca:aad6:: with SMTP id t205mr7572152oie.122.1614957528663; Fri, 05 Mar 2021 07:18:48 -0800 (PST) In-Reply-To: <83lfb1y7la.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201551 Archived-At: On Fri, Mar 5, 2021 at 2:55 PM Eli Zaretskii wrote: > > From: Andrea Corallo > > Cc: 46256@debbugs.gnu.org > > Date: Fri, 05 Mar 2021 13:56:24 +0000 > > > > > Why can't we have a rule in the Makefile conditioned by > > > HAVE_NATIVE_COMP? > > > > We certainly can, the difficult part is to generate the rule as the .eln > > filename is known only by the Emacs binary. I'm probably missing > > something. > > Oh, you mean because of the ABI hash? Yes, that'd preclude using Make > to decide when a .eln file needs to be regenerated. I think storing the ABI hash somewhere accessible in the build tree is a good idea, anyway, and then we could do it with some make magic. > > [ To be considered also that as of today libgccjit is not meant to work > > for cross compilation. ] > > Then perhaps we could invoke Emacs only in order to detect when the > ABI has changed. IIUC, the ABI only changes when DEFUNs do, and then we regenerate most of the Emacs binaries anyway, so we could make abi-hash depend on gl-stamp/globals.h? > Because when that happens, we need to regenerate all > the preloaded *.eln files anyway, so there's no need to test > individual files. Right? But do we want to keep the old files around in case the ABI changes back? I don't think we do. Pip